1593: Fix VVL on halmark example r=kvark a=kvark
**Connections**
We have a bunch of VVL related to resource destruction on the halmark example.
It also seems to leak memory quite a ton and eventually hang the system.
**Description**
This PR fixes the logic of changing the command pools in halmark, its initialization sequence, and its destruction.
**Testing**
Tested on halmark and others
Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
1592: Detailed limits check and error r=cwfitzgerald a=kvark
**Connections**
Related to #1590
**Description**
The old comparison "A < B" was simply wrong, because it would do every field in order and could bail out mid-way without reaching for all limits.
**Testing**
Untested
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
1591: Expose calayer r=kvark a=Sineaggi
**Description**
This pr restores the ability to create a surface from a pre-existing CAMetalLayer. This is required for wgpu-native.
Co-authored-by: Clayton Walker <cwalker@sofi.org>
1585: hal/egl fix support for context extensions r=cwfitzgerald a=kvark
**Connections**
Follow-up to #1584
Closes #1577
**Description**
TIL that EGL extensions work differently from the EGL-1.5 stuff, and we are now treating them properly.
**Testing**
Basic testing on AMD
Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
1587: hal/metal: mark buffer immutability r=kvark a=kvark
**Connections**
This improves Metal performance.
**Description**
Extracting data from Naga to mark some buffers as immutable.
**Testing**
Just ran the examples.
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
1586: Assorted Fixes of Testing-Infra r=kvark a=cwfitzgerald
**Connections**
Couple of low hanging fruit issues solved here. The biggest thing done is moving the masks to associated functions instead of being members of the bitflags, this is done so `all()` only includes the actual members.
Follows up on 579de425e5 to mark vk/mipmap as passing
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
1584: Update testing limits for rpi4 r=kvark a=cwfitzgerald
**Connections**
Related to #1574. Exposed #1583.
**Description**
Changes the reftesting limits to be tolerant of how the RPI4 renders. Fixes the debug half of #1577.
Fixes some naming issues as well.
**Testing**
It is
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
1578: Fix destruction of resources r=kvark a=kvark
**Connections**
Fixes#1552
Also fixes the VVL about swapchain frame destruction.
**Description**
Swapchain view was never registered in the device's root Hub. So the old logic of adding it to "suspected resources" didn't fire up correctly. The new logic goes straight into the submission tracker.
This path will cease to exist when either Hubs are removed, or API changes of https://github.com/webgpu-native/webgpu-headers/issues/89 are accepted.
The other resource destruction errors happened because we gathered all the resources that were abandoned by the user, and held alive only by the submitted command buffers, and we added them to the suspected list. Then we'd scan the list in `maintain`, see that they can be removed, and try to associate their destruction with one of the submissions. But the current submission was not added yet! So the logic thinks it can just remove the resources right away in this case, assuming the submission is not found because it's long gone in past.
**Testing**
Tested on our examples.
Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
1576: Switch all bitflag names to plural r=cwfitzgerald a=kvark
**Connections**
#1471 added a lot of singular bitflag names. Previously, we weren't really consistent.
**Description**
This PR changes all of the names to be plural, except for a few that don't imply singularity, and are matching WebGPU upstream. Maybe we need to convert them too?
**Testing**
self-tested
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
1510: OpenGL ES3 backend r=cwfitzgerald,Gordon-F,kvark a=kvark
**Connections**
Follow-up to #1471
**Description**
The new wgpu-hal backend for GLES3 ~~and WebGL2~~
Edit: WebGL2 is not included here
**Testing**
Examples!
Current status:
- all examples work, minus the next issue
- "mipmap" is buggy because we don't have a good way to do mipmap/layer selection
- automated testing?
Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
