from_data needs flat memory structures. Types which implement
Copy (either implicity or explicitly) ensure this property.
This commit adds the Copy trait bound to
{CpuAccessibleBuffer,ImmutableBuffer}::from_data and adapts the unit
tests accordingly.
* Add pipeline barriers when executing secondary command buffers
* Add locking for secondary command buffers when executed on a primary
* Propagate flags of secondary to primary
* Forgot the vec variant
* Add poisoning as a stopgap measure to protect against inconsistent builder state
* vulkano: instance: derive Ord, PartialOrd for PhysicalDeviceType
Useful for want differeniating integrated and discrete GPUs in a
hash table.
* vulkano: don't pull in all of crossbeam
Just pull in crossbeam-queue, since that's what used.
Having a smaller set of packages is easier for system integrators
such as myself.
* vulkano: memory: add import support, separate device memory and mappings, and much more!
- Chaining structs copied shamelessly and poorly from Ash :-)
- Import support, as previously promised.
- DeviceMemoryMappings so we can maybe one day expose the binding model.
- Attempts to rigorously check Valid Usage IDs (VUIDs).
A note about error handling:
- Currently, Vulkano error handling is a bit unclear. For example, I
didn't define a "DeviceMemoryMappingError" and simply reused the
"DeviceMemoryAllocError" already present in the file. In reality,
both a theoretical "DeviceMemoryMappingError" and the already
present "DeviceMemoryAllocError" should mostly just check the valid
usage IDs present in the Vulkan spec (or return an error from the
implementation). This code pattern is common throughout Vulkano.
Perhaps we should go to a simpler VulkanoResult<T>??? Just an idea.
- Also, is Vulkano a validation layer??? LunarG tracks every single
VUIDs in their uber layer already:
https://www.lunarg.com/wp-content/uploads/2019/04/UberLayer_V3.pdf
Of course, given how Vulkan drivers are relatively straigtforward
compared to OpenGL, it's generally possible to match LunarG *using
Rust* if we just have a big enough community. Whether we want to or
not may be up for debate. For now, I just followed the original
vision of tomaka and added validation. If we do want to do it, then
we have to be more rigorous about it.
* Add posix handle type shortcut
* Expose device local buffer's memory
* Add exportable memory option for pools & device local memory
* Add test for device local with exportable fd
* Use a convenience function in test
* Dont expose memory, but instead allow export fd directly
* Fix mistakes & clean
* Remove test due to IncompatibleDriver error
* Rename Dimensions > ImageViewDimensions, ViewType > ImageViewType
* Remove cubemap_compatible from ImageDimensions, add ImageCreateFlags to UnsafeImage creation
* Replace various UnsafeImage features/usage methods with new ones that return them directly
* Create image::view module, move view-related types into it
* Create safe ImageView type, remove some of the validity checks from UnsafeImageView
* Removed ImageViewAccess::samples and moved the descriptor_set_* functions to ImageAccess
* Remove ImageViewAccess::dimensions
* Impl ImageAccess for ImageView, remove impl on image types
* Rename ImageViewAccess to ImageViewAbstract, move some methods around
* Remove ImageViewDimensions (formerly Dimensions)
* impl Error for ImageViewCreationError
* Missing pub
* Typo
* Some small documentation changes
* Check for ImageCreateFlags that are currently not properly supported
* Write descriptor set layout structs for each entrypoint rather than for the entire module
Signed-off-by: Arc-blroth <45273859+Arc-blroth@users.noreply.github.com>
* Fix descriptor set calculation for all storage classes across all SPIRV versions by inspecting each entrypoint's instruction tree. Also adds 27 instructions to parse.rs.
Signed-off-by: Arc-blroth <45273859+Arc-blroth@users.noreply.github.com>
* Add unit tests for descriptor set calculations
Signed-off-by: Arc-blroth <45273859+Arc-blroth@users.noreply.github.com>
* Fix BufferBlock not counting as a Block decoration on structs (this fixes the unit tests from 4875bcc2)
Signed-off-by: Arc-blroth <45273859+Arc-blroth@users.noreply.github.com>
* cargo fmt
Signed-off-by: Arc-blroth <45273859+Arc-blroth@users.noreply.github.com>
* Update changelog
Signed-off-by: Arc-blroth <45273859+Arc-blroth@users.noreply.github.com>
* Fix file out of alignment with `cargo fmt`.
* Make the reuse_command_buffers test more stable.
The per-thread weak reference to StandardCommandPoolPerThread in
StandardCommandPool can expire forcing the recreation of the pool and
its internal objects. This is a problem for the reuse_command_buffers
test which asserts that a destroyed command pool must be reused if
possible.
This change fixes the test by introducing an extra command buffer that
is held through the rest of the test, introducing an extra strong
reference to the command pool that keeps the weak reference alive for
the duration of the test.
This test fails consistently on my machine with a NVidia 1070 Max-Q
otherwise.
* Fix invalid reference to dropped cache object in compute pipeline
This is achieved by preventing the cache object from being partially
moved.
This fixes issue #1466.
* Add entry to changelog
* vulkano: image: improve formatting
Ran cargo fmt --all. Should we use clippy too ?
* vk_sys: add additional formats
This updates the vk formats enum to the header that's on my
system (vk 1.2-ish).
* vulkano: image: Add NV12 and YV12 support
These formats are commonly used as targets for hardware and
software video decode. The common case is the swapchain allocator
(gralloc in the Android use case) allocates some memory, the video
stack decodes to it, and then memory can be composited by Vulkan
or sent directly to the display.
* vk_sys: update structure types
This updates the structure types to a VK 1.2-ish state. Long term,
it makes a ton of sense to autogenerate vk-sys to make adding
additional features and enumerations easier [1]. For now, we can
hand edit.
[1] (https://github.com/vulkano-rs/vulkano/issues/89)
* vk_sys: add VK_KHR_external_memory_fd bindings
This adds some basic external memory features. Most of these
features are core in VK1.1.
* vulkano: memory: add and use DeviceMemoryBuilder
We'll need to:
(a) Create exportable memory
(b) import from a OS descriptor to create DeviceMemory
(c) Also support dedicated allocations
The device memory API is becoming rather complicated. Let's use
the common builder pattern to simplify this.
* vulkano: memory: implement some external features
This change is sufficient to create exportable memory and
export it. It's only been tested on Linux platforms and depends
on Unix file descriptors, so enable it only there for now.
Import support will be added later. Support for external buffers
and images can also be added later if someone needs it.
creation
To do so, we created a SubImage that implements the ImageAccess trait
This SubImage will decorate an ImageAccess image and will represent
one or more mip level / array layer level
* Unlock images correctly on Err
If the CommandBuffer encountered an error in the lock_submit function,
it would unlock all the previously locked resources and return the
error. It would unlock all the images with a None value which would
panic in an assertion in the unlock method of the images. Now it checks
for the final_layout and unlocks the image this way.
This change should help with the panics mentioned in #1441 and #1447.
With this fix it should return the error that is occuring instead of
panicking.
* Add fix to the change log to inform users.
