mirror of
https://gitlab.freedesktop.org/wlroots/wlroots.git
synced 2024-11-21 22:52:20 +00:00
3187479c07
Color transform can have multiple types and these different types want to store different metadata. We previously stored this metadata directly on wlr_color_transform even for transforms that don't use it. Instead, let's take the prior art from wlr_scene where each scene node is built on a base node. Notice how wlr_color_transform_lut3d now has a `struct wlr_color_transform base`. This is advantageous in multiple ways: 1. We don't allocate memory for metadata that will never be used. 2. This is more type safe: Compositors can pass around a struct wlr_color_transform_lut3d if they know they only want to use a 3d_lut. 3. This is more scalable. As we add more transform types, we don't have to keep growing a monolithic struct.
53 lines
1.3 KiB
C
53 lines
1.3 KiB
C
#include <assert.h>
|
|
#include <stdlib.h>
|
|
#include <wlr/render/color.h>
|
|
#include "render/color.h"
|
|
|
|
struct wlr_color_transform *wlr_color_transform_init_srgb(void) {
|
|
struct wlr_color_transform *tx = calloc(1, sizeof(struct wlr_color_transform));
|
|
if (!tx) {
|
|
return NULL;
|
|
}
|
|
tx->type = COLOR_TRANSFORM_SRGB;
|
|
tx->ref_count = 1;
|
|
wlr_addon_set_init(&tx->addons);
|
|
return tx;
|
|
}
|
|
|
|
static void color_transform_destroy(struct wlr_color_transform *tr) {
|
|
switch (tr->type) {
|
|
case COLOR_TRANSFORM_SRGB:
|
|
break;
|
|
case COLOR_TRANSFORM_LUT_3D:;
|
|
struct wlr_color_transform_lut3d *lut3d =
|
|
wlr_color_transform_lut3d_from_base(tr);
|
|
free(lut3d->lut_3d);
|
|
break;
|
|
}
|
|
wlr_addon_set_finish(&tr->addons);
|
|
free(tr);
|
|
}
|
|
|
|
struct wlr_color_transform *wlr_color_transform_ref(struct wlr_color_transform *tr) {
|
|
tr->ref_count += 1;
|
|
return tr;
|
|
}
|
|
|
|
void wlr_color_transform_unref(struct wlr_color_transform *tr) {
|
|
if (!tr) {
|
|
return;
|
|
}
|
|
assert(tr->ref_count > 0);
|
|
tr->ref_count -= 1;
|
|
if (tr->ref_count == 0) {
|
|
color_transform_destroy(tr);
|
|
}
|
|
}
|
|
|
|
struct wlr_color_transform_lut3d *wlr_color_transform_lut3d_from_base(
|
|
struct wlr_color_transform *tr) {
|
|
assert(tr->type == COLOR_TRANSFORM_LUT_3D);
|
|
struct wlr_color_transform_lut3d *lut3d = wl_container_of(tr, lut3d, base);
|
|
return lut3d;
|
|
}
|