mirror of
https://github.com/gfx-rs/wgpu.git
synced 2024-11-26 08:44:08 +00:00
59f0996eab
895: Improve validation in B2B copies and RenderCommands r=kvark a=kunalmohan **Connections** _Link to the issues addressed by this PR, or dependent PRs in other repositories_ **Description** _Describe what problem this is solving, and how it's solved._ Validation for the following have been added- - Validate all parameters in B2B copy even if `copy_size == 0`. - Check for copy operations issued within same buffer. - `RenderPass.setViewport()` - `RenderPass.setScissorRect()` **Testing** _Explain how this change is tested._ Tested with CTS in Servo. More tests pass now. Will test on wgpu-rs now. <!-- Non-trivial functional changes would need to be tested through: - [wgpu-rs](https://github.com/gfx-rs/wgpu-rs) - test the examples. - [wgpu-native](https://github.com/gfx-rs/wgpu-native/) - check the generated C header for sanity. Ideally, a PR needs to link to the draft PRs in these projects with relevant modifications. See https://github.com/gfx-rs/wgpu/pull/666 for an example. If you can add a unit/integration test here in `wgpu`, that would be best. --> Co-authored-by: Kunal Mohan <kunalmohan99@gmail.com> |
||
---|---|---|
.. | ||
src | ||
Cargo.toml |