Commit Graph

1798 Commits

Author SHA1 Message Date
Dzmitry Malyshau
4d324bc38d Move depth clamping to primitive state 2021-04-05 16:01:23 -04:00
bors[bot]
eef478fc5d
Merge #1307
1307: Update gfx with fixed Metal cross feature r=kvark a=kvark

Just another update

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-04-05 04:48:59 +00:00
Dzmitry Malyshau
2e9d9d8267 Update gfx with fixed Metal cross feature 2021-04-05 00:48:17 -04:00
bors[bot]
31f52202c5
Merge #1305
1305: Don't flip SPIR-V coordinate space on input r=kvark a=kvark

**Connections**
fixes https://github.com/gfx-rs/wgpu-rs/issues/842

**Description**
The SPV-in by default changes the coordinate space, but for WebGPU we don't want it.

**Testing**
Untested...

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-04-04 22:42:24 +00:00
Dzmitry Malyshau
1dddfa6234 Don't flip SPIR-V coordinate space on input 2021-04-04 18:38:56 -04:00
bors[bot]
11666be077
Merge #1304
1304: Update naga to gfx-20 r=kvark a=kvark

See https://github.com/gfx-rs/gfx/pull/3714

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-04-04 15:26:57 +00:00
Dzmitry Malyshau
0bd8526239 Update naga to gfx-20 2021-04-04 11:25:10 -04:00
bors[bot]
8a0bb3327a
Merge #1302
1302: removed autocapture from cargo.toml r=cwfitzgerald a=adamnemecek



Co-authored-by: adamnemecek <adamnemecek@gmail.com>
2021-04-02 19:46:35 +00:00
adamnemecek
af8b94c729 removed autocapture 2021-04-02 09:43:38 -07:00
bors[bot]
1f9958a88f
Merge #1301
1301: framecapture r=kvark a=adamnemecek



Co-authored-by: adamnemecek <adamnemecek@gmail.com>
2021-04-01 19:54:26 +00:00
adamnemecek
d91ad13482 framecapture 2021-04-01 12:51:50 -07:00
bors[bot]
45f890c11c
Merge #1297
1297: Downlevel Infrastructure and Validate Compute Shader Presence r=kvark a=cwfitzgerald

**Connections**

Provides the core infrastructure for #1244.

**Description**

Nothing too crazy in here. Includes the infrastructure and the beginnings of validation. Some of the properties can't easily be verified, but I will follow up with the rest of the low-hanging fruit in another PR.

**Testing**

Testing on https://github.com/gfx-rs/wgpu-rs/pull/829.


Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2021-04-01 15:50:23 +00:00
Connor Fitzgerald
3073a454ff Update to flag-based downlevel bools 2021-04-01 11:48:09 -04:00
Connor Fitzgerald
fca72f54f9 Validate compute shader's presence 2021-03-31 01:08:53 -04:00
Connor Fitzgerald
4db9a4522e Add downlevel infrastructure 2021-03-31 01:08:48 -04:00
bors[bot]
41f106d7fc
Merge #1296
1296: Update gfx to the MSL entry point fix r=kvark a=kvark

See https://github.com/gfx-rs/gfx/pull/3705

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-03-31 01:26:36 +00:00
Dzmitry Malyshau
49c59ec063 Update gfx to the MSL entry point fix 2021-03-30 21:25:40 -04:00
bors[bot]
be16c7f2f2
Merge #1294
1294: Update naga to gfx-19 r=kvark a=Gordon-F

Just a naga update. Also fix https://github.com/gfx-rs/wgpu/issues/1293.

Co-authored-by: Gordon-F <ishaposhnik@icloud.com>
2021-03-30 23:34:59 +00:00
Gordon-F
7fc70bf349 Force-enable EXPERIMENTAL_TRANSLATION flag when running without cross feature 2021-03-31 02:01:43 +03:00
Gordon-F
124d5e3a7c Update naga to gfx-19 2021-03-31 02:00:48 +03:00
bors[bot]
569f87ebda
Merge #1291
1291: Add color blend modes r=kvark a=cwfitzgerald

Continuation of #1289, because apparently you can't re-open an accidentally closed pull request if you force pushed...

Should be GTG.

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2021-03-30 17:39:26 +00:00
Connor Fitzgerald
0616a08c65 Add color blend modes 2021-03-30 13:37:43 -04:00
bors[bot]
456525d9c7
Merge #1290
1290: Update to latest gpu-alloc r=kvark a=Gordon-F



Co-authored-by: Igor Shaposhnik <Gordon-F@users.noreply.github.com>
2021-03-29 13:38:13 +00:00
Igor Shaposhnik
6097421647 Update to latest gpu-alloc 2021-03-29 09:33:40 +00:00
bors[bot]
b7ba481a91
Merge #1282
1282: Update naga to gfx-18 r=kvark a=Gordon-F

Same as https://github.com/gfx-rs/gfx/pull/3695. Just waiting for new naga relese.

Co-authored-by: Gordon-F <ishaposhnik@icloud.com>
2021-03-25 14:01:12 +00:00
Gordon-F
c1f8203f3c Update naga to gfx-18 2021-03-25 16:59:16 +03:00
bors[bot]
e5dfafb3cc
Merge #1281
1281: Rename `level_count` to `mip_level_count` r=kvark a=grovesNL

**Description**
This PR renames `level_count` to `mip_level_count` on `TextureViewDescriptor`. This follows the naming in the specification, located at https://gpuweb.github.io/gpuweb/#texture-view-creation

**Testing**
`cargo build` and `cargo test` only, naming changes will be made downstream in wgpu-rs too.

Co-authored-by: Joshua Groves <josh@joshgroves.com>
2021-03-24 14:56:00 +00:00
Joshua Groves
9885bdf320 Rename level_count to mip_level_count
This follows the naming in the specification, located at
https://gpuweb.github.io/gpuweb/#texture-view-creation
2021-03-24 09:14:30 -02:30
bors[bot]
9c98ebc48c
Merge #1276
1276: Align create_swap_chain function signature r=cwfitzgerald a=kvark

**Connections**
Follow-up to #1034

**Description**
Swapchains are a bit special. Browsers don't use wgpu-core's swapchains, so we never bothered to convert them into the error model. But we still need this for Deno and webgpu-headers.

**Testing**
Untested, but also harmless

Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
2021-03-23 14:39:57 +00:00
Dzmitry Malyshau
f953266bbe Align create_swap_chain function signature 2021-03-23 10:39:13 -04:00
bors[bot]
2bc5526fbe
Merge #1280
1280: Rename color/depth attachments to match spec r=kvark a=grovesNL

**Description**
- Rename `ColorAttachmentDescriptor` to `RenderPassColorAttachment` (https://gpuweb.github.io/gpuweb/#color-attachments)
- Rename `DepthStencilAttachmentDescriptor` to `RenderPassDepthStencilAttachment` (https://gpuweb.github.io/gpuweb/#depth-stencil-attachments)
- Rename `attachment` fields on both attachments to `view`

**Testing**
None (just `cargo build`) because the renaming downstream should be trivial.

Co-authored-by: Joshua Groves <josh@joshgroves.com>
2021-03-23 14:27:52 +00:00
Joshua Groves
a5693ab2a3 Rename color/depth attachments to match spec
- Rename `ColorAttachmentDescriptor` to `RenderPassColorAttachment`
- Rename `DepthStencilAttachmentDescriptor` to `RenderPassDepthStencilAttachment`
- Rename `attachment` fields on both attachments to `view`
2021-03-23 09:31:59 -02:30
bors[bot]
fb0288a377
Merge #1279
1279: Fix some typos r=kvark a=grovesNL

**Description**
Fix a few small typos in doc comments

**Testing**
None

Co-authored-by: Joshua Groves <josh@joshgroves.com>
2021-03-23 06:44:11 +00:00
bors[bot]
b90199bec3
Merge #1278
1278: Rename copy views and layout to match spec r=kvark a=grovesNL

**Description**
Match the specification naming changes from https://github.com/gpuweb/gpuweb/pull/1375

**Testing**
None because the changes downstream to wgpu-rs and wgpu-native should be trivial (renaming only)

Co-authored-by: Joshua Groves <josh@joshgroves.com>
2021-03-23 03:41:46 +00:00
Joshua Groves
306eaf3969 Fix some typos 2021-03-23 01:01:32 -02:30
Joshua Groves
9058f3ba62 Rename copy views and layout to match spec 2021-03-23 00:48:42 -02:30
bors[bot]
8dd9bd8af9
Merge #1275
1275: rows_per_image & rows_per_image are now optional r=kvark a=Wumpf

Fixes #988
Was surprisingly hard, hope it's correct; testing could be more extensive...
Ideas for more elegant handling very welcome.

**Testing**
Tested against wgpu-rs samples


Co-authored-by: Andreas Reich <r_andreas2@web.de>
2021-03-22 02:36:36 +00:00
Andreas Reich
720c73fa9c Review feedback / fix validate_linear_texture_data 2021-03-21 09:01:31 +01:00
Andreas Reich
50043875e5 rows_per_image & rows_per_image are now optional
Fixes #988
2021-03-20 12:33:28 +01:00
bors[bot]
c831c5512a
Merge #1273
1273: Properly return native shader module errors to users r=kvark a=Gordon-F

**Testing**
Disable `cross` feature, break `naga` and see what happens 😄 

```log
wgpu error: Validation Error

Caused by:
    In Device::create_render_pipeline
    Internal error in stage VERTEX: Error compiling the shader "\"Compilation failed: \\n\\nprogram_source:1:1: error: unknown type name \\\'sadgasdgasdgasdg\\\'\\nsadgasdgasdgasdg aasdgadsgb>\\n^\\nprogram_source:1:28: error: expected \\\';\\\' after top level declarator\\nsadgasdgasdgasdg aasdgadsgb>\\n   
```



Co-authored-by: Gordon-F <ishaposhnik@icloud.com>
2021-03-19 18:13:28 +00:00
Gordon-F
d20c0199d7 Properly return native shader module errors to users 2021-03-19 21:09:54 +03:00
bors[bot]
92936954d8
Merge #1274
1274: Update naga to gfx-17 r=kvark a=kvark

**Connections**
Includes https://github.com/gfx-rs/gfx/pull/3688

**Description**
Here comes the "gfx-17" naga train!

**Testing**
Tested on wgpu-rs examples

Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
2021-03-19 17:44:28 +00:00
Dzmitry Malyshau
c52dad9d47 Update naga to gfx-17 2021-03-19 13:43:11 -04:00
bors[bot]
ba6015e2c7
Merge #1272
1272: Add sample count to framebuffer key r=kvark a=kvark

**Connections**
Fixes #1271

**Description**
The framebuffer is created for a pass, so naturally the hashmap key for a framebuffer has to include the pass key. Otherwise, we'd be overwriting the framebuffer entry, or using a framebuffer from a different pass. The sample count was missing from our FB key.

**Testing**
Tested on a trace from #1271 that I hand-ported to latest master.

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
2021-03-17 16:15:30 +00:00
Dzmitry Malyshau
9673635125 Add sample count to framebuffer key 2021-03-17 12:13:11 -04:00
bors[bot]
bb9a5a85d2
Merge #1270
1270: Update naga to gfx-16 r=kvark a=kvark

**Connections**
Picks up https://github.com/gfx-rs/gfx/pull/3684

**Description**
Just an update

**Testing**
Tested on wgpu-rs examples

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-03-17 13:08:07 +00:00
Dzmitry Malyshau
b97f5a5b24 Update naga to gfx-16 2021-03-17 09:07:08 -04:00
bors[bot]
2f3b398e38
Merge #1268
1268: Move from `tracing` to `log` + `profiling` r=kvark a=cwfitzgerald

**Connections**

Fixes #1211. Fixes #1189.

**Description**

Moves from `tracing` to `log` + `profiling`. I also removed some of the offending spans that were only for pushing commands onto a vector of commands.

**Testing**

Tested on wgpu-rs

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2021-03-17 05:30:36 +00:00
Connor Fitzgerald
cf6f9c3ca8 Move from tracing to log + profiling 2021-03-17 01:22:30 -04:00
bors[bot]
5d993efc85
Merge #1267
1267: Update naga to gfx-15 r=kvark a=kvark

**Connections**
Fixes #1228 (huge DX12 leak in command allocation)
Includes https://github.com/gfx-rs/gfx/pull/3676, https://github.com/gfx-rs/gfx/pull/3679, https://github.com/gfx-rs/gfx/pull/3680, https://github.com/gfx-rs/gfx/pull/3681, and the relevant Naga stuff.

**Description**
Updates Naga and gfx.

**Testing**
Tested on wgpu-rs examplse

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
2021-03-16 17:07:20 +00:00