Disable validate_global_variables check for now (#2593)

This commit is contained in:
Rua 2024-10-28 00:53:05 +01:00 committed by GitHub
parent 2df8003408
commit 3e4ed4831d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -52,7 +52,7 @@ pub(crate) fn validate_runtime(
validator.validate_decorations()?; validator.validate_decorations()?;
validator.validate_execution_modes()?; validator.validate_execution_modes()?;
validator.validate_types()?; validator.validate_types()?;
validator.validate_global_variables()?; // FIXME: validator.validate_global_variables()?;
validator.validate_functions()?; validator.validate_functions()?;
Ok(()) Ok(())
@ -1040,6 +1040,9 @@ impl<'a> RuntimeValidator<'a> {
Ok(()) Ok(())
} }
// FIXME: this needs to use only the global variables that are statically used by the
// entry point's call tree. That requires analysing the call tree during `Spirv::new`.
#[allow(dead_code)]
fn validate_global_variables(&self) -> Result<(), Box<ValidationError>> { fn validate_global_variables(&self) -> Result<(), Box<ValidationError>> {
let properties = self.device.physical_device().properties(); let properties = self.device.physical_device().properties();