From 3e4ed4831df30979301df7926f7213a0ce09e20e Mon Sep 17 00:00:00 2001 From: Rua Date: Mon, 28 Oct 2024 00:53:05 +0100 Subject: [PATCH] Disable `validate_global_variables` check for now (#2593) --- vulkano/src/pipeline/shader/validate_runtime.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vulkano/src/pipeline/shader/validate_runtime.rs b/vulkano/src/pipeline/shader/validate_runtime.rs index bd23fd8f..1450da10 100644 --- a/vulkano/src/pipeline/shader/validate_runtime.rs +++ b/vulkano/src/pipeline/shader/validate_runtime.rs @@ -52,7 +52,7 @@ pub(crate) fn validate_runtime( validator.validate_decorations()?; validator.validate_execution_modes()?; validator.validate_types()?; - validator.validate_global_variables()?; + // FIXME: validator.validate_global_variables()?; validator.validate_functions()?; Ok(()) @@ -1040,6 +1040,9 @@ impl<'a> RuntimeValidator<'a> { Ok(()) } + // FIXME: this needs to use only the global variables that are statically used by the + // entry point's call tree. That requires analysing the call tree during `Spirv::new`. + #[allow(dead_code)] fn validate_global_variables(&self) -> Result<(), Box> { let properties = self.device.physical_device().properties();