mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-02 21:17:39 +00:00

detects redundant imports that can be eliminated. for #117772 : In order to facilitate review and modification, split the checking code and removing redundant imports code into two PR.
185 lines
6.1 KiB
Rust
185 lines
6.1 KiB
Rust
use rustc_index::bit_set::BitSet;
|
|
use rustc_index::IndexSlice;
|
|
use rustc_middle::mir::visit::*;
|
|
use rustc_middle::mir::*;
|
|
use rustc_middle::ty::TyCtxt;
|
|
use rustc_mir_dataflow::impls::borrowed_locals;
|
|
|
|
use crate::ssa::SsaLocals;
|
|
|
|
/// Unify locals that copy each other.
|
|
///
|
|
/// We consider patterns of the form
|
|
/// _a = rvalue
|
|
/// _b = move? _a
|
|
/// _c = move? _a
|
|
/// _d = move? _c
|
|
/// where each of the locals is only assigned once.
|
|
///
|
|
/// We want to replace all those locals by `_a`, either copied or moved.
|
|
pub struct CopyProp;
|
|
|
|
impl<'tcx> MirPass<'tcx> for CopyProp {
|
|
fn is_enabled(&self, sess: &rustc_session::Session) -> bool {
|
|
sess.mir_opt_level() >= 1
|
|
}
|
|
|
|
#[instrument(level = "trace", skip(self, tcx, body))]
|
|
fn run_pass(&self, tcx: TyCtxt<'tcx>, body: &mut Body<'tcx>) {
|
|
debug!(def_id = ?body.source.def_id());
|
|
propagate_ssa(tcx, body);
|
|
}
|
|
}
|
|
|
|
fn propagate_ssa<'tcx>(tcx: TyCtxt<'tcx>, body: &mut Body<'tcx>) {
|
|
let borrowed_locals = borrowed_locals(body);
|
|
let ssa = SsaLocals::new(body);
|
|
|
|
let fully_moved = fully_moved_locals(&ssa, body);
|
|
debug!(?fully_moved);
|
|
|
|
let mut storage_to_remove = BitSet::new_empty(fully_moved.domain_size());
|
|
for (local, &head) in ssa.copy_classes().iter_enumerated() {
|
|
if local != head {
|
|
storage_to_remove.insert(head);
|
|
}
|
|
}
|
|
|
|
let any_replacement = ssa.copy_classes().iter_enumerated().any(|(l, &h)| l != h);
|
|
|
|
Replacer {
|
|
tcx,
|
|
copy_classes: ssa.copy_classes(),
|
|
fully_moved,
|
|
borrowed_locals,
|
|
storage_to_remove,
|
|
}
|
|
.visit_body_preserves_cfg(body);
|
|
|
|
if any_replacement {
|
|
crate::simplify::remove_unused_definitions(body);
|
|
}
|
|
}
|
|
|
|
/// `SsaLocals` computed equivalence classes between locals considering copy/move assignments.
|
|
///
|
|
/// This function also returns whether all the `move?` in the pattern are `move` and not copies.
|
|
/// A local which is in the bitset can be replaced by `move _a`. Otherwise, it must be
|
|
/// replaced by `copy _a`, as we cannot move multiple times from `_a`.
|
|
///
|
|
/// If an operand copies `_c`, it must happen before the assignment `_d = _c`, otherwise it is UB.
|
|
/// This means that replacing it by a copy of `_a` if ok, since this copy happens before `_c` is
|
|
/// moved, and therefore that `_d` is moved.
|
|
#[instrument(level = "trace", skip(ssa, body))]
|
|
fn fully_moved_locals(ssa: &SsaLocals, body: &Body<'_>) -> BitSet<Local> {
|
|
let mut fully_moved = BitSet::new_filled(body.local_decls.len());
|
|
|
|
for (_, rvalue, _) in ssa.assignments(body) {
|
|
let (Rvalue::Use(Operand::Copy(place) | Operand::Move(place))
|
|
| Rvalue::CopyForDeref(place)) = rvalue
|
|
else {
|
|
continue;
|
|
};
|
|
|
|
let Some(rhs) = place.as_local() else { continue };
|
|
if !ssa.is_ssa(rhs) {
|
|
continue;
|
|
}
|
|
|
|
if let Rvalue::Use(Operand::Copy(_)) | Rvalue::CopyForDeref(_) = rvalue {
|
|
fully_moved.remove(rhs);
|
|
}
|
|
}
|
|
|
|
ssa.meet_copy_equivalence(&mut fully_moved);
|
|
|
|
fully_moved
|
|
}
|
|
|
|
/// Utility to help performing substitution of `*pattern` by `target`.
|
|
struct Replacer<'a, 'tcx> {
|
|
tcx: TyCtxt<'tcx>,
|
|
fully_moved: BitSet<Local>,
|
|
storage_to_remove: BitSet<Local>,
|
|
borrowed_locals: BitSet<Local>,
|
|
copy_classes: &'a IndexSlice<Local, Local>,
|
|
}
|
|
|
|
impl<'tcx> MutVisitor<'tcx> for Replacer<'_, 'tcx> {
|
|
fn tcx(&self) -> TyCtxt<'tcx> {
|
|
self.tcx
|
|
}
|
|
|
|
fn visit_local(&mut self, local: &mut Local, ctxt: PlaceContext, _: Location) {
|
|
let new_local = self.copy_classes[*local];
|
|
match ctxt {
|
|
// Do not modify the local in storage statements.
|
|
PlaceContext::NonUse(NonUseContext::StorageLive | NonUseContext::StorageDead) => {}
|
|
// The local should have been marked as non-SSA.
|
|
PlaceContext::MutatingUse(_) => assert_eq!(*local, new_local),
|
|
// We access the value.
|
|
_ => *local = new_local,
|
|
}
|
|
}
|
|
|
|
fn visit_place(&mut self, place: &mut Place<'tcx>, ctxt: PlaceContext, loc: Location) {
|
|
if let Some(new_projection) = self.process_projection(place.projection, loc) {
|
|
place.projection = self.tcx().mk_place_elems(&new_projection);
|
|
}
|
|
|
|
let observes_address = match ctxt {
|
|
PlaceContext::NonMutatingUse(
|
|
NonMutatingUseContext::SharedBorrow
|
|
| NonMutatingUseContext::FakeBorrow
|
|
| NonMutatingUseContext::AddressOf,
|
|
) => true,
|
|
// For debuginfo, merging locals is ok.
|
|
PlaceContext::NonUse(NonUseContext::VarDebugInfo) => {
|
|
self.borrowed_locals.contains(place.local)
|
|
}
|
|
_ => false,
|
|
};
|
|
if observes_address && !place.is_indirect() {
|
|
// We observe the address of `place.local`. Do not replace it.
|
|
} else {
|
|
self.visit_local(
|
|
&mut place.local,
|
|
PlaceContext::NonMutatingUse(NonMutatingUseContext::Copy),
|
|
loc,
|
|
)
|
|
}
|
|
}
|
|
|
|
fn visit_operand(&mut self, operand: &mut Operand<'tcx>, loc: Location) {
|
|
if let Operand::Move(place) = *operand
|
|
// A move out of a projection of a copy is equivalent to a copy of the original projection.
|
|
&& !place.is_indirect_first_projection()
|
|
&& !self.fully_moved.contains(place.local)
|
|
{
|
|
*operand = Operand::Copy(place);
|
|
}
|
|
self.super_operand(operand, loc);
|
|
}
|
|
|
|
fn visit_statement(&mut self, stmt: &mut Statement<'tcx>, loc: Location) {
|
|
// When removing storage statements, we need to remove both (#107511).
|
|
if let StatementKind::StorageLive(l) | StatementKind::StorageDead(l) = stmt.kind
|
|
&& self.storage_to_remove.contains(l)
|
|
{
|
|
stmt.make_nop();
|
|
return;
|
|
}
|
|
|
|
self.super_statement(stmt, loc);
|
|
|
|
// Do not leave tautological assignments around.
|
|
if let StatementKind::Assign(box (lhs, ref rhs)) = stmt.kind
|
|
&& let Rvalue::Use(Operand::Copy(rhs) | Operand::Move(rhs)) | Rvalue::CopyForDeref(rhs) =
|
|
*rhs
|
|
&& lhs == rhs
|
|
{
|
|
stmt.make_nop();
|
|
}
|
|
}
|
|
}
|