rust/compiler/rustc_mir_transform/src/copy_prop.rs

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

185 lines
6.1 KiB
Rust
Raw Normal View History

2023-01-12 18:23:48 +00:00
use rustc_index::bit_set::BitSet;
use rustc_index::IndexSlice;
2023-01-12 18:23:48 +00:00
use rustc_middle::mir::visit::*;
use rustc_middle::mir::*;
2023-01-19 22:23:41 +00:00
use rustc_middle::ty::TyCtxt;
use rustc_mir_dataflow::impls::borrowed_locals;
2023-01-12 18:23:48 +00:00
2023-01-19 22:23:41 +00:00
use crate::ssa::SsaLocals;
2023-01-12 18:23:48 +00:00
/// Unify locals that copy each other.
///
/// We consider patterns of the form
/// _a = rvalue
/// _b = move? _a
/// _c = move? _a
/// _d = move? _c
/// where each of the locals is only assigned once.
///
/// We want to replace all those locals by `_a`, either copied or moved.
pub struct CopyProp;
impl<'tcx> MirPass<'tcx> for CopyProp {
fn is_enabled(&self, sess: &rustc_session::Session) -> bool {
sess.mir_opt_level() >= 1
2023-01-12 18:23:48 +00:00
}
#[instrument(level = "trace", skip(self, tcx, body))]
fn run_pass(&self, tcx: TyCtxt<'tcx>, body: &mut Body<'tcx>) {
debug!(def_id = ?body.source.def_id());
propagate_ssa(tcx, body);
}
}
fn propagate_ssa<'tcx>(tcx: TyCtxt<'tcx>, body: &mut Body<'tcx>) {
let borrowed_locals = borrowed_locals(body);
let ssa = SsaLocals::new(body);
2023-01-12 18:23:48 +00:00
2023-01-19 22:23:41 +00:00
let fully_moved = fully_moved_locals(&ssa, body);
debug!(?fully_moved);
2023-01-12 18:23:48 +00:00
let mut storage_to_remove = BitSet::new_empty(fully_moved.domain_size());
2023-01-19 22:23:41 +00:00
for (local, &head) in ssa.copy_classes().iter_enumerated() {
2023-01-12 18:23:48 +00:00
if local != head {
storage_to_remove.insert(head);
}
}
2023-01-19 22:23:41 +00:00
let any_replacement = ssa.copy_classes().iter_enumerated().any(|(l, &h)| l != h);
2023-01-12 18:23:48 +00:00
Replacer {
tcx,
copy_classes: ssa.copy_classes(),
fully_moved,
borrowed_locals,
storage_to_remove,
}
.visit_body_preserves_cfg(body);
2023-01-12 18:23:48 +00:00
if any_replacement {
crate::simplify::remove_unused_definitions(body);
}
}
2023-01-19 22:23:41 +00:00
/// `SsaLocals` computed equivalence classes between locals considering copy/move assignments.
2023-01-12 18:23:48 +00:00
///
/// This function also returns whether all the `move?` in the pattern are `move` and not copies.
2023-01-19 16:57:32 +00:00
/// A local which is in the bitset can be replaced by `move _a`. Otherwise, it must be
2023-01-12 18:23:48 +00:00
/// replaced by `copy _a`, as we cannot move multiple times from `_a`.
///
/// If an operand copies `_c`, it must happen before the assignment `_d = _c`, otherwise it is UB.
/// This means that replacing it by a copy of `_a` if ok, since this copy happens before `_c` is
/// moved, and therefore that `_d` is moved.
#[instrument(level = "trace", skip(ssa, body))]
2023-01-19 22:23:41 +00:00
fn fully_moved_locals(ssa: &SsaLocals, body: &Body<'_>) -> BitSet<Local> {
let mut fully_moved = BitSet::new_filled(body.local_decls.len());
2023-01-12 18:23:48 +00:00
for (_, rvalue, _) in ssa.assignments(body) {
2023-01-12 18:23:48 +00:00
let (Rvalue::Use(Operand::Copy(place) | Operand::Move(place))
| Rvalue::CopyForDeref(place)) = rvalue
else {
continue;
};
let Some(rhs) = place.as_local() else { continue };
2023-01-19 22:23:41 +00:00
if !ssa.is_ssa(rhs) {
continue;
}
2023-01-12 18:23:48 +00:00
if let Rvalue::Use(Operand::Copy(_)) | Rvalue::CopyForDeref(_) = rvalue {
fully_moved.remove(rhs);
}
}
2023-01-19 22:23:41 +00:00
ssa.meet_copy_equivalence(&mut fully_moved);
2023-01-12 18:23:48 +00:00
2023-01-19 22:23:41 +00:00
fully_moved
2023-01-12 18:23:48 +00:00
}
/// Utility to help performing substitution of `*pattern` by `target`.
2023-01-19 22:23:41 +00:00
struct Replacer<'a, 'tcx> {
2023-01-12 18:23:48 +00:00
tcx: TyCtxt<'tcx>,
fully_moved: BitSet<Local>,
storage_to_remove: BitSet<Local>,
borrowed_locals: BitSet<Local>,
copy_classes: &'a IndexSlice<Local, Local>,
2023-01-12 18:23:48 +00:00
}
2023-01-19 22:23:41 +00:00
impl<'tcx> MutVisitor<'tcx> for Replacer<'_, 'tcx> {
2023-01-12 18:23:48 +00:00
fn tcx(&self) -> TyCtxt<'tcx> {
self.tcx
}
fn visit_local(&mut self, local: &mut Local, ctxt: PlaceContext, _: Location) {
let new_local = self.copy_classes[*local];
match ctxt {
// Do not modify the local in storage statements.
PlaceContext::NonUse(NonUseContext::StorageLive | NonUseContext::StorageDead) => {}
// The local should have been marked as non-SSA.
PlaceContext::MutatingUse(_) => assert_eq!(*local, new_local),
// We access the value.
_ => *local = new_local,
}
}
fn visit_place(&mut self, place: &mut Place<'tcx>, ctxt: PlaceContext, loc: Location) {
if let Some(new_projection) = self.process_projection(place.projection, loc) {
Rename many interner functions. (This is a large commit. The changes to `compiler/rustc_middle/src/ty/context.rs` are the most important ones.) The current naming scheme is a mess, with a mix of `_intern_`, `intern_` and `mk_` prefixes, with little consistency. In particular, in many cases it's easy to use an iterator interner when a (preferable) slice interner is available. The guiding principles of the new naming system: - No `_intern_` prefixes. - The `intern_` prefix is for internal operations. - The `mk_` prefix is for external operations. - For cases where there is a slice interner and an iterator interner, the former is `mk_foo` and the latter is `mk_foo_from_iter`. Also, `slice_interners!` and `direct_interners!` can now be `pub` or non-`pub`, which helps enforce the internal/external operations division. It's not perfect, but I think it's a clear improvement. The following lists show everything that was renamed. slice_interners - const_list - mk_const_list -> mk_const_list_from_iter - intern_const_list -> mk_const_list - substs - mk_substs -> mk_substs_from_iter - intern_substs -> mk_substs - check_substs -> check_and_mk_substs (this is a weird one) - canonical_var_infos - intern_canonical_var_infos -> mk_canonical_var_infos - poly_existential_predicates - mk_poly_existential_predicates -> mk_poly_existential_predicates_from_iter - intern_poly_existential_predicates -> mk_poly_existential_predicates - _intern_poly_existential_predicates -> intern_poly_existential_predicates - predicates - mk_predicates -> mk_predicates_from_iter - intern_predicates -> mk_predicates - _intern_predicates -> intern_predicates - projs - intern_projs -> mk_projs - place_elems - mk_place_elems -> mk_place_elems_from_iter - intern_place_elems -> mk_place_elems - bound_variable_kinds - mk_bound_variable_kinds -> mk_bound_variable_kinds_from_iter - intern_bound_variable_kinds -> mk_bound_variable_kinds direct_interners - region - intern_region (unchanged) - const - mk_const_internal -> intern_const - const_allocation - intern_const_alloc -> mk_const_alloc - layout - intern_layout -> mk_layout - adt_def - intern_adt_def -> mk_adt_def_from_data (unusual case, hard to avoid) - alloc_adt_def(!) -> mk_adt_def - external_constraints - intern_external_constraints -> mk_external_constraints Other - type_list - mk_type_list -> mk_type_list_from_iter - intern_type_list -> mk_type_list - tup - mk_tup -> mk_tup_from_iter - intern_tup -> mk_tup
2023-02-17 03:33:08 +00:00
place.projection = self.tcx().mk_place_elems(&new_projection);
}
let observes_address = match ctxt {
PlaceContext::NonMutatingUse(
NonMutatingUseContext::SharedBorrow
| NonMutatingUseContext::FakeBorrow
| NonMutatingUseContext::AddressOf,
) => true,
// For debuginfo, merging locals is ok.
PlaceContext::NonUse(NonUseContext::VarDebugInfo) => {
self.borrowed_locals.contains(place.local)
}
_ => false,
};
if observes_address && !place.is_indirect() {
// We observe the address of `place.local`. Do not replace it.
} else {
self.visit_local(
&mut place.local,
PlaceContext::NonMutatingUse(NonMutatingUseContext::Copy),
loc,
)
}
2023-01-12 18:23:48 +00:00
}
fn visit_operand(&mut self, operand: &mut Operand<'tcx>, loc: Location) {
if let Operand::Move(place) = *operand
2023-02-06 17:14:24 +00:00
// A move out of a projection of a copy is equivalent to a copy of the original projection.
&& !place.is_indirect_first_projection()
&& !self.fully_moved.contains(place.local)
2023-01-12 18:23:48 +00:00
{
*operand = Operand::Copy(place);
}
self.super_operand(operand, loc);
}
fn visit_statement(&mut self, stmt: &mut Statement<'tcx>, loc: Location) {
// When removing storage statements, we need to remove both (#107511).
if let StatementKind::StorageLive(l) | StatementKind::StorageDead(l) = stmt.kind
&& self.storage_to_remove.contains(l)
{
stmt.make_nop();
return;
}
self.super_statement(stmt, loc);
// Do not leave tautological assignments around.
if let StatementKind::Assign(box (lhs, ref rhs)) = stmt.kind
&& let Rvalue::Use(Operand::Copy(rhs) | Operand::Move(rhs)) | Rvalue::CopyForDeref(rhs) =
*rhs
&& lhs == rhs
{
stmt.make_nop();
2023-01-12 18:23:48 +00:00
}
}
}