bors[bot]
92faa2225a
Merge #815
...
815: Fix another crash r=matklad a=flodiebold
Found while typechecking rustc with better name resolution...
`walk_mut` doing a preorder walk can lead to an infinite recursion when substituting type parameters; postorder is actually what we want.
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
2019-02-12 21:05:09 +00:00
Florian Diebold
e5f9d54661
Fix another crash
2019-02-12 21:49:54 +01:00
bors[bot]
61324a845b
Merge #811
...
811: Filter attributes from the completion details/label r=kjeremy a=lnicola
Before:
![image](https://user-images.githubusercontent.com/308347/52657254-efba9a00-2f00-11e9-952f-901910cfc459.png )
After:
![image](https://user-images.githubusercontent.com/308347/52657278-fb0dc580-2f00-11e9-9267-8aff44c93447.png )
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2019-02-12 19:31:22 +00:00
Laurențiu Nicola
040fb91387
Filter attributes from the completion details/label
2019-02-12 20:35:10 +02:00
bors[bot]
24287d024d
Merge #810
...
810: make token trees eq r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-02-12 17:57:39 +00:00
Aleksey Kladov
5f89180fd9
make token trees eq
2019-02-12 20:57:13 +03:00
bors[bot]
3e367b5760
Merge #809
...
809: what goes bump in the night? r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
2019-02-12 16:11:19 +00:00
bors[bot]
afdcfb79b9
Merge #808
...
808: rename yellow -> syntax_node r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-02-12 16:03:47 +00:00
kjeremy
c15d0e0194
what goes bump in the night?
2019-02-12 11:03:28 -05:00
Aleksey Kladov
4e91c23c79
rename yellow -> syntax_node
...
why yellow in the first place? Its red + green.
2019-02-12 19:02:30 +03:00
bors[bot]
abc5d377e2
Merge #807
...
807: Specify vscode 1.31 r=matklad a=kjeremy
This is for #796
It doesn't seem to fix the problem if you manually install the extension but it is the "right thing to do".
Co-authored-by: kjeremy <kjeremy@gmail.com>
2019-02-12 15:33:02 +00:00
kjeremy
50383ceae1
Specify vscode 1.31
2019-02-12 10:31:11 -05:00
Aleksey Kladov
72a122092b
mention no compatability gurantee
2019-02-12 18:28:39 +03:00
Aleksey Kladov
03691c797a
update readme to point to the WG
2019-02-12 17:55:02 +03:00
bors[bot]
74ecfc2729
Merge #804
...
804: Fix some typos r=killercup a=killercup
Cherry-picked and updated from my now-closed PR. All credit goes to [Code Spell Checker](https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker ).
Co-authored-by: Pascal Hertleif <killercup@gmail.com>
2019-02-12 14:08:20 +00:00
Pascal Hertleif
4fd3613434
Fix some typos
2019-02-12 15:02:57 +01:00
bors[bot]
a36e310229
Merge #805
...
805: don't distinguish Create and Write events in VFS r=pnkfelix a=matklad
r? @pnkfelix
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-02-12 13:06:16 +00:00
Aleksey Kladov
7820fb38f4
don't distinguish Create and Write events in VFS
2019-02-12 16:01:01 +03:00
bors[bot]
19718ea109
Merge #801
...
801: Implement completion for associated items r=matklad a=lnicola
Fixes #747 .
r? @matklad
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2019-02-12 11:07:21 +00:00
Laurențiu Nicola
7e8527f748
Implement completion for associated items
2019-02-12 12:51:01 +02:00
bors[bot]
37148000dc
Merge #802
...
802: fix obsolete comment r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-02-12 10:33:17 +00:00
Aleksey Kladov
60524771fd
replace clone with copy
2019-02-12 13:32:34 +03:00
Aleksey Kladov
fa2e6e0bda
fix obsolete comment
2019-02-12 13:29:27 +03:00
bors[bot]
db43080693
Merge #794
...
794: fix regression in self-referential completion r=flodiebold a=matklad
r? @flodiebold
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-02-11 22:05:39 +00:00
Aleksey Kladov
8ef80086a0
fix regression in self-referential completion
2019-02-11 23:43:24 +03:00
bors[bot]
db6d214411
Merge #793
...
793: remove hard-coded query-group macro r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-02-11 19:25:26 +00:00
Aleksey Kladov
0d060b073c
remove hard-coded query-group macro
2019-02-11 22:24:39 +03:00
bors[bot]
a78142cc64
Merge #791
...
791: docs r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-02-11 18:32:18 +00:00
Aleksey Kladov
ae312680d6
docs
2019-02-11 21:31:54 +03:00
Aleksey Kladov
0d34a256de
assign ids when converting tt
2019-02-11 21:12:06 +03:00
Aleksey Kladov
58897dd8dd
assign ids to tokens
2019-02-11 21:02:19 +03:00
bors[bot]
b356ab46f2
Merge #781
...
781: Refactor to allow for multiple assists r=matklad a=eulerdisk
This is necessary to allow assist "providers" (which currently are simple free function) to produce multiple assists. I'm not sure this is the best possible refactoring tough.
Co-authored-by: Andrea Pretto <eulerdisk@gmail.com>
2019-02-11 17:30:53 +00:00
Andrea Pretto
5c9c0d3ae2
ra_assists: assist "providers" can produce multiple assists
2019-02-11 18:07:21 +01:00
bors[bot]
77ccac74f9
Merge #790
...
790: make macro-rules eq r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-02-11 16:24:39 +00:00
Aleksey Kladov
2efdf41bdb
make macro a NameOwner
2019-02-11 19:24:13 +03:00
Aleksey Kladov
e7b370226c
make macro-rules eq
2019-02-11 19:19:23 +03:00
bors[bot]
a180674986
Merge #789
...
789: remove useless hash r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-02-11 16:10:34 +00:00
Aleksey Kladov
dc951098f6
typo
2019-02-11 19:09:53 +03:00
Aleksey Kladov
bbcd3566de
remove useless hash
2019-02-11 19:09:53 +03:00
bors[bot]
af62fde57f
Merge #788
...
788: remove query_definitions r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-02-11 14:45:32 +00:00
Aleksey Kladov
28fd228c70
remove query_definitions
2019-02-11 17:44:54 +03:00
bors[bot]
6596793c0c
Merge #787
...
787: rename combine -> or r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-02-11 14:30:35 +00:00
Aleksey Kladov
8cafdb3a99
rename combine -> or
...
This way we match API of Option
https://doc.rust-lang.org/std/option/enum.Option.html#method.or
2019-02-11 17:29:20 +03:00
bors[bot]
821d980fd9
Merge #785
...
785: Fix completion of paths r=flodiebold a=matklad
r? @flodiebold
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-02-11 14:02:59 +00:00
bors[bot]
ca1b0a1231
Merge #786
...
786: ⬆️ insta r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-02-11 12:46:58 +00:00
Aleksey Kladov
9a7890c14e
⬆️ insta
2019-02-11 15:46:35 +03:00
Aleksey Kladov
58ed8ee665
use extern prelude in Resolver
...
This fixes two bugs:
- completion for paths works again
- we handle extern prelude shadowing more correctly
2019-02-11 15:41:39 +03:00
bors[bot]
2babbbb978
Merge #784
...
784: WIP: improve multi-crate fixtures r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2019-02-11 10:54:27 +00:00
Aleksey Kladov
9923383d53
add graph fixture
2019-02-11 13:47:17 +03:00
Aleksey Kladov
dced2f4ed4
Handle SourceRoots automatically in fixtures
2019-02-11 12:53:10 +03:00