reviewer comments and rebase fallout

This commit is contained in:
Nick Cameron 2018-03-16 20:57:35 +13:00
parent 0cf80dcce7
commit bf9f175336
2 changed files with 15 additions and 14 deletions

View File

@ -1297,27 +1297,28 @@ Reorder import statements in group
**Note:** This option takes effect only when [`reorder_imports`](#reorder_imports) is set to `true`. **Note:** This option takes effect only when [`reorder_imports`](#reorder_imports) is set to `true`.
#### `false` (default): #### `true` (default):
```rust ```rust
use std::io;
use std::mem;
use dolor; use dolor;
use ipsum; use ipsum;
use lorem; use lorem;
use sit; use sit;
use std::io;
use std::mem;
``` ```
#### `true`: #### `false`:
```rust ```rust
use std::io;
use std::mem;
use dolor; use dolor;
use ipsum; use ipsum;
use lorem; use lorem;
use sit; use sit;
use std::io;
use std::mem;
``` ```
See also [`reorder_imports`](#reorder_imports). See also [`reorder_imports`](#reorder_imports).
@ -1359,7 +1360,11 @@ Reorder `extern crate` statements in group
- **Possible values**: `true`, `false` - **Possible values**: `true`, `false`
- **Stable**: No - **Stable**: No
#### `true` (default): #### `false` (default):
This value has no influence beyond the effect of the [`reorder_extern_crates`](#reorder_extern_crates) option. Set [`reorder_extern_crates`](#reorder_extern_crates) to `false` if you do not want `extern crate` groups to be collapsed and ordered.
#### `true`:
**Note:** This only takes effect when [`reorder_extern_crates`](#reorder_extern_crates) is set to `true`. **Note:** This only takes effect when [`reorder_extern_crates`](#reorder_extern_crates) is set to `true`.
@ -1373,10 +1378,6 @@ extern crate lorem;
extern crate sit; extern crate sit;
``` ```
#### `false`:
This value has no influence beyond the effect of the [`reorder_extern_crates`](#reorder_extern_crates) option. Set [`reorder_extern_crates`](#reorder_extern_crates) to `false` if you do not want `extern crate` groups to be collapsed and ordered.
## `reorder_modules` ## `reorder_modules`
Reorder `mod` declarations alphabetically in group. Reorder `mod` declarations alphabetically in group.
@ -1385,7 +1386,7 @@ Reorder `mod` declarations alphabetically in group.
- **Possible values**: `true`, `false` - **Possible values**: `true`, `false`
- **Stable**: No - **Stable**: No
#### `true` #### `true` (default)
```rust ```rust
mod a; mod a;

View File

@ -41,8 +41,8 @@ use std::time::Duration;
use syntax::ast; use syntax::ast;
pub use syntax::codemap::FileName; pub use syntax::codemap::FileName;
use syntax::codemap::{CodeMap, FilePathMapping}; use syntax::codemap::{CodeMap, FilePathMapping};
use syntax::errors::{DiagnosticBuilder, Handler};
use syntax::errors::emitter::{ColorConfig, EmitterWriter}; use syntax::errors::emitter::{ColorConfig, EmitterWriter};
use syntax::errors::{DiagnosticBuilder, Handler};
use syntax::parse::{self, ParseSess}; use syntax::parse::{self, ParseSess};
use checkstyle::{output_footer, output_header}; use checkstyle::{output_footer, output_header};