From bf9f17533636f580de9b5971d17d3d5fa6d2bc16 Mon Sep 17 00:00:00 2001 From: Nick Cameron Date: Fri, 16 Mar 2018 20:57:35 +1300 Subject: [PATCH] reviewer comments and rebase fallout --- Configurations.md | 27 ++++++++++++++------------- src/lib.rs | 2 +- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/Configurations.md b/Configurations.md index 975cb890ed7..f7fa88b61f2 100644 --- a/Configurations.md +++ b/Configurations.md @@ -1297,27 +1297,28 @@ Reorder import statements in group **Note:** This option takes effect only when [`reorder_imports`](#reorder_imports) is set to `true`. -#### `false` (default): +#### `true` (default): ```rust +use std::io; +use std::mem; + use dolor; use ipsum; use lorem; use sit; -use std::io; -use std::mem; ``` -#### `true`: +#### `false`: + ```rust -use std::io; -use std::mem; - use dolor; use ipsum; use lorem; use sit; +use std::io; +use std::mem; ``` See also [`reorder_imports`](#reorder_imports). @@ -1359,7 +1360,11 @@ Reorder `extern crate` statements in group - **Possible values**: `true`, `false` - **Stable**: No -#### `true` (default): +#### `false` (default): + +This value has no influence beyond the effect of the [`reorder_extern_crates`](#reorder_extern_crates) option. Set [`reorder_extern_crates`](#reorder_extern_crates) to `false` if you do not want `extern crate` groups to be collapsed and ordered. + +#### `true`: **Note:** This only takes effect when [`reorder_extern_crates`](#reorder_extern_crates) is set to `true`. @@ -1373,10 +1378,6 @@ extern crate lorem; extern crate sit; ``` -#### `false`: - -This value has no influence beyond the effect of the [`reorder_extern_crates`](#reorder_extern_crates) option. Set [`reorder_extern_crates`](#reorder_extern_crates) to `false` if you do not want `extern crate` groups to be collapsed and ordered. - ## `reorder_modules` Reorder `mod` declarations alphabetically in group. @@ -1385,7 +1386,7 @@ Reorder `mod` declarations alphabetically in group. - **Possible values**: `true`, `false` - **Stable**: No -#### `true` +#### `true` (default) ```rust mod a; diff --git a/src/lib.rs b/src/lib.rs index c080f1396cb..4fdb7d0f47d 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -41,8 +41,8 @@ use std::time::Duration; use syntax::ast; pub use syntax::codemap::FileName; use syntax::codemap::{CodeMap, FilePathMapping}; -use syntax::errors::{DiagnosticBuilder, Handler}; use syntax::errors::emitter::{ColorConfig, EmitterWriter}; +use syntax::errors::{DiagnosticBuilder, Handler}; use syntax::parse::{self, ParseSess}; use checkstyle::{output_footer, output_header};