layer-shell: fix use-after-free when client requests an invalid layer

This commit is contained in:
emersion 2018-04-26 15:58:41 +01:00
parent ce64bb7d83
commit fcb7ad925d
No known key found for this signature in database
GPG Key ID: 0FDE7BE0E88F5E48

View File

@ -338,7 +338,7 @@ static void layer_shell_handle_get_layer_surface(struct wl_client *wl_client,
surface->layer = layer;
if (layer > ZWLR_LAYER_SHELL_V1_LAYER_OVERLAY) {
free(surface);
wl_resource_post_error(surface->resource,
wl_resource_post_error(client_resource,
ZWLR_LAYER_SHELL_V1_ERROR_INVALID_LAYER,
"Invalid layer %d", layer);
return;