From f440c601280c13c65fe81368f1542ef77f806587 Mon Sep 17 00:00:00 2001 From: Kenny Levinsen Date: Thu, 7 Nov 2024 22:27:03 +0100 Subject: [PATCH] backend/drm: Remove redundant error logs wlr_renderer and wlr_allocator will print out errors as they go, and end with a final error if they fail to create anything. The caller of this function will also log when it fails. Skip the redundant errors emitted here. --- backend/drm/renderer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/backend/drm/renderer.c b/backend/drm/renderer.c index b07984984..1253d22bd 100644 --- a/backend/drm/renderer.c +++ b/backend/drm/renderer.c @@ -17,7 +17,6 @@ bool init_drm_renderer(struct wlr_drm_backend *drm, struct wlr_drm_renderer *renderer) { renderer->wlr_rend = renderer_autocreate_with_drm_fd(drm->fd); if (!renderer->wlr_rend) { - wlr_log(WLR_ERROR, "Failed to create renderer"); return false; } if (wlr_renderer_get_texture_formats(renderer->wlr_rend, WLR_BUFFER_CAP_DMABUF) == NULL) { @@ -29,7 +28,6 @@ bool init_drm_renderer(struct wlr_drm_backend *drm, renderer->allocator = wlr_allocator_autocreate(&drm->backend, renderer->wlr_rend); if (renderer->allocator == NULL) { - wlr_log(WLR_ERROR, "Failed to create allocator"); wlr_renderer_destroy(renderer->wlr_rend); renderer->wlr_rend = NULL; return false;