nordic-dev.net/wlroots
2
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2024-11-22 23:22:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix resize issues with some xdg-shell apps.

Browse Source 
Also renames view_get_size to view_get_box to be more consistent with wlroots API and make it more obvious that x,y are set (while in roots_view.get_size this isn't the case).
Fixes #407
This commit is contained in:
emersion 2017-11-11 15:39:15 +01:00
parent 698a172701
commit eb89f1dcd2
No known key found for this signature in database
GPG Key ID: 0FDE7BE0E88F5E48
4 changed files with 22 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/rootston/view.h
View File

@ -94,7 +94,7 @@ struct roots_view {
void (*close)(struct roots_view *view);
};
void view_get_size(const struct roots_view *view, struct wlr_box *box);
void view_get_box(const struct roots_view *view, struct wlr_box *box);
void view_activate(struct roots_view *view, bool active);
void view_move(struct roots_view *view, double x, double y);
void view_resize(struct roots_view *view, uint32_t width, uint32_t height);

8
rootston/cursor.c
View File

@ -72,10 +72,10 @@ void view_begin_resize(struct roots_input *input, struct wlr_cursor *cursor,
} else {
input->view_x = view->x;
input->view_y = view->y;
struct wlr_box size;
view_get_size(view, &size);
input->view_width = size.width;
input->view_height = size.height;
struct wlr_box box;
view_get_box(view, &box);
input->view_width = box.width;
input->view_height = box.height;
}
input->resize_edges = edges;

18
rootston/desktop.c
View File

@ -35,15 +35,15 @@ void view_destroy(struct roots_view *view) {
free(view);
}
void view_get_size(const struct roots_view *view, struct wlr_box *box) {
void view_get_box(const struct roots_view *view, struct wlr_box *box) {
box->x = view->x;
box->y = view->y;
if (view->get_size) {
view->get_size(view, box);
} else {
box->width = view->wlr_surface->current->width;
box->height = view->wlr_surface->current->height;
}
box->x = view->x;
box->y = view->y;
}
static void view_update_output(const struct roots_view *view,
@ -51,7 +51,7 @@ static void view_update_output(const struct roots_view *view,
struct roots_desktop *desktop = view->desktop;
struct roots_output *output;
struct wlr_box box;
view_get_size(view, &box);
view_get_box(view, &box);
wl_list_for_each(output, &desktop->outputs, link) {
bool intersected = before->x != -1 && wlr_output_layout_intersects(
desktop->layout, output->wlr_output,
@ -71,7 +71,7 @@ static void view_update_output(const struct roots_view *view,
void view_move(struct roots_view *view, double x, double y) {
struct wlr_box before;
view_get_size(view, &before);
view_get_box(view, &before);
if (view->move) {
view->move(view, x, y);
} else {
@ -88,7 +88,7 @@ void view_activate(struct roots_view *view, bool activate) {
void view_resize(struct roots_view *view, uint32_t width, uint32_t height) {
struct wlr_box before;
view_get_size(view, &before);
view_get_box(view, &before);
if (view->resize) {
view->resize(view, width, height);
}
@ -117,7 +117,7 @@ void view_maximize(struct roots_view *view, bool maximized) {
if (!view->maximized && maximized) {
struct wlr_box view_box;
view_get_size(view, &view_box);
view_get_box(view, &view_box);
view->maximized = true;
view->saved.x = view->x;
@ -158,7 +158,7 @@ void view_close(struct roots_view *view) {
bool view_center(struct roots_view *view) {
struct wlr_box box;
view_get_size(view, &box);
view_get_box(view, &box);
struct roots_desktop *desktop = view->desktop;
struct wlr_cursor *cursor = desktop->server->input->cursor;
@ -193,7 +193,7 @@ void view_setup(struct roots_view *view) {
view_center(view);
set_view_focus(input, view->desktop, view);
struct wlr_box before;
view_get_size(view, &before);
view_get_box(view, &before);
view_update_output(view, &before);
}

10
rootston/xdg_shell_v6.c
View File

@ -13,8 +13,14 @@
static void get_size(const struct roots_view *view, struct wlr_box *box) {
assert(view->type == ROOTS_XDG_SHELL_V6_VIEW);
struct wlr_xdg_surface_v6 *surf = view->xdg_surface_v6;
// TODO: surf->geometry can be NULL
memcpy(box, surf->geometry, sizeof(struct wlr_box));
if (surf->geometry->width > 0 && surf->geometry->height > 0) {
box->width = surf->geometry->width;
box->height = surf->geometry->height;
} else {
box->width = view->wlr_surface->current->width;
box->height = view->wlr_surface->current->height;
}
}
static void activate(struct roots_view *view, bool active) {