From eae8952e176fcb63fe611d73f1459ab0f24252c9 Mon Sep 17 00:00:00 2001 From: Simon Zeni Date: Tue, 8 Mar 2022 15:53:21 -0500 Subject: [PATCH] types/wlr_keyboard: remove destroy event The destroy event from the base wlr_input_device must be used --- include/wlr/types/wlr_keyboard.h | 1 - types/wlr_input_method_v2.c | 2 +- types/wlr_keyboard.c | 3 --- types/wlr_keyboard_group.c | 2 +- 4 files changed, 2 insertions(+), 6 deletions(-) diff --git a/include/wlr/types/wlr_keyboard.h b/include/wlr/types/wlr_keyboard.h index b3be053a5..063d6e3f6 100644 --- a/include/wlr/types/wlr_keyboard.h +++ b/include/wlr/types/wlr_keyboard.h @@ -89,7 +89,6 @@ struct wlr_keyboard { struct wl_signal modifiers; struct wl_signal keymap; struct wl_signal repeat_info; - struct wl_signal destroy; } events; void *data; diff --git a/types/wlr_input_method_v2.c b/types/wlr_input_method_v2.c index 559927eb1..fe1568690 100644 --- a/types/wlr_input_method_v2.c +++ b/types/wlr_input_method_v2.c @@ -410,7 +410,7 @@ void wlr_input_method_keyboard_grab_v2_set_keyboard( &keyboard_grab->keyboard_repeat_info); keyboard_grab->keyboard_destroy.notify = handle_keyboard_destroy; - wl_signal_add(&keyboard->events.destroy, + wl_signal_add(&keyboard->base.events.destroy, &keyboard_grab->keyboard_destroy); wlr_input_method_keyboard_grab_v2_send_modifiers(keyboard_grab, diff --git a/types/wlr_keyboard.c b/types/wlr_keyboard.c index 1d6090943..52d9a06d7 100644 --- a/types/wlr_keyboard.c +++ b/types/wlr_keyboard.c @@ -124,7 +124,6 @@ void wlr_keyboard_init(struct wlr_keyboard *kb, wl_signal_init(&kb->events.modifiers); wl_signal_init(&kb->events.keymap); wl_signal_init(&kb->events.repeat_info); - wl_signal_init(&kb->events.destroy); kb->keymap_fd = -1; @@ -147,8 +146,6 @@ void wlr_keyboard_finish(struct wlr_keyboard *kb) { wlr_keyboard_notify_key(kb, &event); // updates num_keycodes } - wlr_signal_emit_safe(&kb->events.destroy, kb); - wlr_input_device_finish(&kb->base); /* Finish xkbcommon resources */ diff --git a/types/wlr_keyboard_group.c b/types/wlr_keyboard_group.c index 465e9944f..7f575810e 100644 --- a/types/wlr_keyboard_group.c +++ b/types/wlr_keyboard_group.c @@ -279,7 +279,7 @@ bool wlr_keyboard_group_add_keyboard(struct wlr_keyboard_group *group, wl_signal_add(&keyboard->events.repeat_info, &device->repeat_info); device->repeat_info.notify = handle_keyboard_repeat_info; - wl_signal_add(&keyboard->events.destroy, &device->destroy); + wl_signal_add(&keyboard->base.events.destroy, &device->destroy); device->destroy.notify = handle_keyboard_destroy; struct wlr_keyboard *group_kb = &group->keyboard;