From 769cabbadf295fbe26cd2c3eb6efd5233c4d14e8 Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Wed, 23 Nov 2022 15:56:37 +0100 Subject: [PATCH] util/time: use int64_t return value for get_current_time_msec() 0xFFFFFFFF milliseconds is 4,294,967,295 ms so about 50 days. A little bit too close for comfort. Use int64_t instead of uint64_t to avoid C's implicit conversion footguns in computations. --- include/util/time.h | 2 +- util/time.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/util/time.h b/include/util/time.h index 287698dec..890fe55fb 100644 --- a/include/util/time.h +++ b/include/util/time.h @@ -6,7 +6,7 @@ /** * Get the current time, in milliseconds. */ -uint32_t get_current_time_msec(void); +int64_t get_current_time_msec(void); /** * Convert a timespec to milliseconds. diff --git a/util/time.c b/util/time.c index 06e42b40d..c561d23ab 100644 --- a/util/time.c +++ b/util/time.c @@ -15,7 +15,7 @@ void timespec_from_nsec(struct timespec *r, int64_t nsec) { r->tv_nsec = nsec % NSEC_PER_SEC; } -uint32_t get_current_time_msec(void) { +int64_t get_current_time_msec(void) { struct timespec now; clock_gettime(CLOCK_MONOTONIC, &now); return timespec_to_msec(&now);