From 21e96c459d75b81216c4047d9ec418985d0f0e00 Mon Sep 17 00:00:00 2001 From: Evyatar Stalinsky Date: Thu, 29 Jun 2023 15:58:56 +0300 Subject: [PATCH] util/log: fix buffer overflow --- util/log.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/util/log.c b/util/log.c index cbec3e86e..ae84f7e75 100644 --- a/util/log.c +++ b/util/log.c @@ -72,8 +72,9 @@ static wlr_log_func_t log_callback = log_stderr; static void log_wl(const char *fmt, va_list args) { static char wlr_fmt[1024]; int n = snprintf(wlr_fmt, sizeof(wlr_fmt), "[wayland] %s", fmt); - if (n > 0 && wlr_fmt[n - 1] == '\n') { - wlr_fmt[n - 1] = '\0'; + size_t len = strlen(wlr_fmt); + if (n > 0 && wlr_fmt[len - 1] == '\n') { + wlr_fmt[len - 1] = '\0'; } _wlr_vlog(WLR_INFO, wlr_fmt, args); }