nordic-dev.net/wlroots
2
0
Fork 0
mirror of https://gitlab.freedesktop.org/wlroots/wlroots.git synced 2024-11-21 22:52:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

util/shm: clear mode permission bits in allocate_shm_file_pair

Browse Source 
This ensures the file cannot be re-opened with write permissions.

Closes: https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3429
This commit is contained in:
Simon Ser 2022-05-12 19:58:50 +02:00
parent e646d882cf
commit 19896e7fb6
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
util/shm.c
View File

@ -3,6 +3,7 @@
#include <fcntl.h> #include <fcntl.h>
#include <string.h> #include <string.h>
#include <sys/mman.h> #include <sys/mman.h>
#include <sys/stat.h>
#include <time.h> #include <time.h>
#include <unistd.h> #include <unistd.h>
#include <wlr/config.h> #include <wlr/config.h>
@ -73,6 +74,14 @@ bool allocate_shm_file_pair(size_t size, int *rw_fd_ptr, int *ro_fd_ptr) {
shm_unlink(name); shm_unlink(name);
// Make sure the file cannot be re-opened in read-write mode (e.g. via
// "/proc/self/fd/" on Linux)
if (fchmod(rw_fd, 0) != 0) {
close(rw_fd);
close(ro_fd);
return false;
}
int ret; int ret;
do { do {
ret = ftruncate(rw_fd, size); ret = ftruncate(rw_fd, size);