refactor(naga): remove extraneous leading path qualifiers (#5612)

Implemented by `cargo fix -p naga --lib`.
This commit is contained in:
Erich Gubler 2024-04-28 10:33:13 -04:00 committed by GitHub
parent 1ea96391ea
commit e8e33ede11
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 14 additions and 16 deletions

View File

@ -950,10 +950,10 @@ impl<'a> ConstantEvaluator<'a> {
pattern: [crate::SwizzleComponent; 4], pattern: [crate::SwizzleComponent; 4],
) -> Result<Handle<Expression>, ConstantEvaluatorError> { ) -> Result<Handle<Expression>, ConstantEvaluatorError> {
let mut get_dst_ty = |ty| match self.types[ty].inner { let mut get_dst_ty = |ty| match self.types[ty].inner {
crate::TypeInner::Vector { size: _, scalar } => Ok(self.types.insert( TypeInner::Vector { size: _, scalar } => Ok(self.types.insert(
Type { Type {
name: None, name: None,
inner: crate::TypeInner::Vector { size, scalar }, inner: TypeInner::Vector { size, scalar },
}, },
span, span,
)), )),
@ -1244,13 +1244,11 @@ impl<'a> ConstantEvaluator<'a> {
Expression::ZeroValue(ty) | Expression::Compose { ty, .. } => { Expression::ZeroValue(ty) | Expression::Compose { ty, .. } => {
match self.types[ty].inner { match self.types[ty].inner {
TypeInner::Array { size, .. } => match size { TypeInner::Array { size, .. } => match size {
crate::ArraySize::Constant(len) => { ArraySize::Constant(len) => {
let expr = Expression::Literal(Literal::U32(len.get())); let expr = Expression::Literal(Literal::U32(len.get()));
self.register_evaluated_expr(expr, span) self.register_evaluated_expr(expr, span)
} }
crate::ArraySize::Dynamic => { ArraySize::Dynamic => Err(ConstantEvaluatorError::ArrayLengthDynamic),
Err(ConstantEvaluatorError::ArrayLengthDynamic)
}
}, },
_ => Err(ConstantEvaluatorError::InvalidArrayLengthArg), _ => Err(ConstantEvaluatorError::InvalidArrayLengthArg),
} }
@ -1313,7 +1311,7 @@ impl<'a> ConstantEvaluator<'a> {
Expression::ZeroValue(ty) Expression::ZeroValue(ty)
if matches!( if matches!(
self.types[ty].inner, self.types[ty].inner,
crate::TypeInner::Scalar(crate::Scalar { TypeInner::Scalar(crate::Scalar {
kind: ScalarKind::Uint, kind: ScalarKind::Uint,
.. ..
}) })
@ -1628,7 +1626,7 @@ impl<'a> ConstantEvaluator<'a> {
return self.cast(expr, target, span); return self.cast(expr, target, span);
}; };
let crate::TypeInner::Array { let TypeInner::Array {
base: _, base: _,
size, size,
stride: _, stride: _,

View File

@ -239,7 +239,7 @@ pub enum GuardedIndex {
pub fn find_checked_indexes( pub fn find_checked_indexes(
module: &crate::Module, module: &crate::Module,
function: &crate::Function, function: &crate::Function,
info: &crate::valid::FunctionInfo, info: &valid::FunctionInfo,
policies: BoundsCheckPolicies, policies: BoundsCheckPolicies,
) -> BitSet { ) -> BitSet {
use crate::Expression as Ex; use crate::Expression as Ex;
@ -321,7 +321,7 @@ pub fn access_needs_check(
mut index: GuardedIndex, mut index: GuardedIndex,
module: &crate::Module, module: &crate::Module,
function: &crate::Function, function: &crate::Function,
info: &crate::valid::FunctionInfo, info: &valid::FunctionInfo,
) -> Option<IndexableLength> { ) -> Option<IndexableLength> {
let base_inner = info[base].ty.inner_with(&module.types); let base_inner = info[base].ty.inner_with(&module.types);
// Unwrap safety: `Err` here indicates unindexable base types and invalid // Unwrap safety: `Err` here indicates unindexable base types and invalid

View File

@ -136,7 +136,7 @@ impl<E> fmt::Display for WithSpan<E>
where where
E: fmt::Display, E: fmt::Display,
{ {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> std::fmt::Result { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
self.inner.fmt(f) self.inner.fmt(f)
} }
} }
@ -304,7 +304,7 @@ impl<E> WithSpan<E> {
use term::termcolor::NoColor; use term::termcolor::NoColor;
let files = files::SimpleFile::new(path, source); let files = files::SimpleFile::new(path, source);
let config = codespan_reporting::term::Config::default(); let config = term::Config::default();
let mut writer = NoColor::new(Vec::new()); let mut writer = NoColor::new(Vec::new());
term::emit(&mut writer, &config, &files, &self.diagnostic()).expect("cannot write error"); term::emit(&mut writer, &config, &files, &self.diagnostic()).expect("cannot write error");
String::from_utf8(writer.into_inner()).unwrap() String::from_utf8(writer.into_inner()).unwrap()

View File

@ -835,7 +835,7 @@ impl FunctionInfo {
let req = self.expressions[expr.index()].uniformity.requirements; let req = self.expressions[expr.index()].uniformity.requirements;
if self if self
.flags .flags
.contains(super::ValidationFlags::CONTROL_FLOW_UNIFORMITY) .contains(ValidationFlags::CONTROL_FLOW_UNIFORMITY)
&& !req.is_empty() && !req.is_empty()
{ {
if let Some(cause) = disruptor { if let Some(cause) = disruptor {

View File

@ -194,7 +194,7 @@ impl super::Validator {
use crate::Expression as E; use crate::Expression as E;
if !global_expr_kind.is_const_or_override(handle) { if !global_expr_kind.is_const_or_override(handle) {
return Err(super::ConstExpressionError::NonConstOrOverride); return Err(ConstExpressionError::NonConstOrOverride);
} }
match gctx.global_expressions[handle] { match gctx.global_expressions[handle] {
@ -211,10 +211,10 @@ impl super::Validator {
} }
E::Splat { value, .. } => match *mod_info[value].inner_with(gctx.types) { E::Splat { value, .. } => match *mod_info[value].inner_with(gctx.types) {
crate::TypeInner::Scalar { .. } => {} crate::TypeInner::Scalar { .. } => {}
_ => return Err(super::ConstExpressionError::InvalidSplatType(value)), _ => return Err(ConstExpressionError::InvalidSplatType(value)),
}, },
_ if global_expr_kind.is_const(handle) || !self.allow_overrides => { _ if global_expr_kind.is_const(handle) || !self.allow_overrides => {
return Err(super::ConstExpressionError::NonFullyEvaluatedConst) return Err(ConstExpressionError::NonFullyEvaluatedConst)
} }
// the constant evaluator will report errors about override-expressions // the constant evaluator will report errors about override-expressions
_ => {} _ => {}