nordic-dev.net/wgpu
nordic-dev.net/wgpu
2
0
Fork 0
mirror of https://github.com/gfx-rs/wgpu.git synced 2024-11-22 14:55:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

[naga] Remove unneeded PartialEq derivations.

Browse Source 
Remove `PartialEq` derivations from various Naga IR types on which
equality doesn't really make sense. In some cases, derive only in
`cfg(test)` builds, so tests can check for expected output.

In the GLSL front end, use `append` to add new constants, not
`fetch_or_append`, since the latter requires `PartialEq` yet GLSL
doesn't permit duplicate declarations anyway.
This commit is contained in:
Jim Blandy 2024-06-14 15:16:48 -07:00 committed by Teodor Tanasoaia
parent 4a1174b5ed
commit 975ccbd77b
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
naga/src/front/glsl/variables.rs
View File

@ -475,7 +475,7 @@ impl Frontend {
ty, ty,
init, init,
}; };
let handle = ctx.module.constants.fetch_or_append(constant, meta); let handle = ctx.module.constants.append(constant, meta);
let lookup = GlobalLookup { let lookup = GlobalLookup {
kind: GlobalLookupKind::Constant(handle, ty), kind: GlobalLookupKind::Constant(handle, ty),

10
naga/src/lib.rs
View File

@ -891,7 +891,7 @@ pub enum Literal {
} }
/// Pipeline-overridable constant. /// Pipeline-overridable constant.
#[derive(Debug, PartialEq, Clone)] #[derive(Debug, Clone)]
#[cfg_attr(feature = "serialize", derive(Serialize))] #[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))] #[cfg_attr(feature = "deserialize", derive(Deserialize))]
#[cfg_attr(feature = "arbitrary", derive(Arbitrary))] #[cfg_attr(feature = "arbitrary", derive(Arbitrary))]
@ -909,7 +909,8 @@ pub struct Override {
} }
/// Constant value. /// Constant value.
#[derive(Debug, PartialEq, Clone)] #[derive(Debug, Clone)]
#[cfg_attr(test, derive(PartialEq))]
#[cfg_attr(feature = "serialize", derive(Serialize))] #[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))] #[cfg_attr(feature = "deserialize", derive(Deserialize))]
#[cfg_attr(feature = "arbitrary", derive(Arbitrary))] #[cfg_attr(feature = "arbitrary", derive(Arbitrary))]
@ -971,7 +972,7 @@ pub struct ResourceBinding {
} }
/// Variable defined at module level. /// Variable defined at module level.
#[derive(Clone, Debug, PartialEq)] #[derive(Clone, Debug)]
#[cfg_attr(feature = "serialize", derive(Serialize))] #[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))] #[cfg_attr(feature = "deserialize", derive(Deserialize))]
#[cfg_attr(feature = "arbitrary", derive(Arbitrary))] #[cfg_attr(feature = "arbitrary", derive(Arbitrary))]
@ -1371,7 +1372,8 @@ bitflags::bitflags! {
/// ///
/// [`Constant`]: Expression::Constant /// [`Constant`]: Expression::Constant
/// [`Override`]: Expression::Override /// [`Override`]: Expression::Override
#[derive(Clone, Debug, PartialEq)] #[derive(Clone, Debug)]
#[cfg_attr(test, derive(PartialEq))]
#[cfg_attr(feature = "serialize", derive(Serialize))] #[cfg_attr(feature = "serialize", derive(Serialize))]
#[cfg_attr(feature = "deserialize", derive(Deserialize))] #[cfg_attr(feature = "deserialize", derive(Deserialize))]
#[cfg_attr(feature = "arbitrary", derive(Arbitrary))] #[cfg_attr(feature = "arbitrary", derive(Arbitrary))]