Minor fixes in Gecko

This commit is contained in:
Dzmitry Malyshau 2020-05-26 16:35:20 -04:00
parent d529526e7f
commit 79eb7b9c17
2 changed files with 4 additions and 5 deletions

View File

@ -7,6 +7,6 @@ Launch as:
player <trace-dir>
```
When built with "winit" feature, it's able to replay the workloads that operate on a swapchain. It renders each frame consequently, then waits for the user to close the window. When built without "winit", it launches in console mode and can replay any trace that doesn't use swapchains.
When built with "winit" feature, it's able to replay the workloads that operate on a swapchain. It renders each frame sequentially, then waits for the user to close the window. When built without "winit", it launches in console mode and can replay any trace that doesn't use swapchains.
Note: replaying is currently restricted to the same backend, as one used for recording a trace. It is straightforward, however, to just replace the backend in RON, since it's serialized as plain text. Valid values are: Vulkan, Metal, Dx12, and Dx11.

View File

@ -1717,10 +1717,9 @@ impl<G: GlobalIdentityHandlerFactory> Global<G> {
unsafe { slice::from_raw_parts(desc.color_states, desc.color_states_length) };
let depth_stencil_state = unsafe { desc.depth_stencil_state.as_ref() };
let rasterization_state = unsafe { desc.rasterization_state.as_ref() }.cloned();
let rasterizer = conv::map_rasterization_state_descriptor(
&unsafe { desc.rasterization_state.as_ref() }
.cloned()
.unwrap_or_default(),
&rasterization_state.clone().unwrap_or_default(),
);
let desc_vbs = unsafe {
@ -2015,7 +2014,7 @@ impl<G: GlobalIdentityHandlerFactory> Global<G> {
fragment_stage: unsafe { desc.fragment_stage.as_ref() }
.map(trace::ProgrammableStageDescriptor::new),
primitive_topology: desc.primitive_topology,
rasterization_state: unsafe { desc.rasterization_state.as_ref() }.cloned(),
rasterization_state,
color_states: color_states.to_vec(),
depth_stencil_state: depth_stencil_state.cloned(),
vertex_state: trace::VertexStateDescriptor {