nordic-dev.net/wgpu
nordic-dev.net/wgpu
2
0
Fork 0
mirror of https://github.com/gfx-rs/wgpu.git synced 2024-11-25 16:24:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make assertions in wgpu-core device/mod.rs verbose (#622)

Browse Source 
Co-authored-by: Paul Kernfeld <paulkernfeld@gmail.com>
This commit is contained in:
Paul Kernfeld 2020-05-01 00:05:13 -04:00 committed by GitHub
parent f64b2dd3bb
commit 29fe9a935a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 55 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

71
wgpu-core/src/device/mod.rs
View File

@ -386,9 +386,12 @@ impl<B: GfxBackend> Device<B> {
// Ensure `D24Plus` textures cannot be copied
match desc.format {
TextureFormat::Depth24Plus | TextureFormat::Depth24PlusStencil8 => {
assert!(!desc
.usage
.intersects(wgt::TextureUsage::COPY_SRC | wgt::TextureUsage::COPY_DST));
assert!(
!desc
.usage
.intersects(wgt::TextureUsage::COPY_SRC | wgt::TextureUsage::COPY_DST),
"D24Plus textures cannot be copied"
);
}
_ => {}
}
@ -398,7 +401,12 @@ impl<B: GfxBackend> Device<B> {
let aspects = format.surface_desc().aspects;
let usage = conv::map_texture_usage(desc.usage, aspects);
assert!((desc.mip_level_count as usize) < MAX_MIP_LEVELS);
assert!(
(desc.mip_level_count as usize) < MAX_MIP_LEVELS,
"Texture descriptor mip level count ({}) must be less than device max mip levels ({})",
desc.mip_level_count,
MAX_MIP_LEVELS
);
let mut view_capabilities = hal::image::ViewCapabilities::empty();
// 2D textures with array layer counts that are multiples of 6 could be cubemaps
@ -655,7 +663,11 @@ impl<G: GlobalIdentityHandlerFactory> Global<G> {
let (mut buffer_guard, _) = hub.buffers.write(&mut token);
let device = &device_guard[device_id];
let mut buffer = &mut buffer_guard[buffer_id];
assert!(buffer.usage.contains(wgt::BufferUsage::MAP_WRITE));
assert!(
buffer.usage.contains(wgt::BufferUsage::MAP_WRITE),
"Buffer usage {:?} must contain usage flag MAP_WRITE",
buffer.usage
);
//assert!(buffer isn't used by the GPU);
#[cfg(feature = "trace")]
@ -707,7 +719,11 @@ impl<G: GlobalIdentityHandlerFactory> Global<G> {
let (mut buffer_guard, _) = hub.buffers.write(&mut token);
let device = &device_guard[device_id];
let mut buffer = &mut buffer_guard[buffer_id];
assert!(buffer.usage.contains(wgt::BufferUsage::MAP_READ));
assert!(
buffer.usage.contains(wgt::BufferUsage::MAP_READ),
"Buffer usage {:?} must contain usage flag MAP_READ",
buffer.usage
);
//assert!(buffer isn't used by the GPU);
match map_buffer(
@ -1121,8 +1137,12 @@ impl<G: GlobalIdentityHandlerFactory> Global<G> {
slice::from_raw_parts(desc.bind_group_layouts, desc.bind_group_layouts_length)
};
assert!(desc.bind_group_layouts_length <= (device.limits.max_bind_groups as usize),
"Cannot set a bind group which is beyond the `max_bind_groups` limit requested on device creation");
assert!(
desc.bind_group_layouts_length <= (device.limits.max_bind_groups as usize),
"Cannot set more bind groups ({}) than the `max_bind_groups` limit requested on device creation ({})",
desc.bind_group_layouts_length,
device.limits.max_bind_groups
);
// TODO: push constants
let pipeline_layout = {
@ -1269,8 +1289,9 @@ impl<G: GlobalIdentityHandlerFactory> Global<G> {
assert_eq!(
bb.offset % alignment,
0,
"Misaligned buffer offset {}",
bb.offset
"Buffer offset {} must be a multiple of alignment {}",
bb.offset,
alignment
);
let buffer = used
.buffers
@ -1278,7 +1299,8 @@ impl<G: GlobalIdentityHandlerFactory> Global<G> {
.unwrap();
assert!(
buffer.usage.contains(pub_usage),
"Expected buffer usage {:?}",
"Buffer usage {:?} must contain usage flag(s) {:?}",
buffer.usage,
pub_usage
);
@ -1352,7 +1374,8 @@ impl<G: GlobalIdentityHandlerFactory> Global<G> {
.unwrap();
assert!(
texture.usage.contains(pub_usage),
"Expected buffer usage {:?}",
"Texture usage {:?} must contain usage flag(s) {:?}",
texture.usage,
pub_usage
);
@ -1813,7 +1836,7 @@ impl<G: GlobalIdentityHandlerFactory> Global<G> {
let sc = desc.sample_count;
assert!(
sc == 1 || sc == 2 || sc == 4 || sc == 8 || sc == 16 || sc == 32,
"Invalid sample_count of {}",
"Invalid sample_count of {}; must be 1, 2, 4, 8, 16, or 32",
sc
);
let sc = sc as u8;
@ -1855,7 +1878,13 @@ impl<G: GlobalIdentityHandlerFactory> Global<G> {
let desc_atts =
unsafe { slice::from_raw_parts(vb_state.attributes, vb_state.attributes_length) };
for attribute in desc_atts {
assert_eq!(0, attribute.offset >> 32);
assert_eq!(
0,
attribute.offset >> 32,
"Offset for attribute {:?} must be < 2^32, but was {}",
attribute,
attribute.offset
);
attributes.alloc().init(hal::pso::AttributeDesc {
location: attribute.shader_location,
binding: i as u32,
@ -2285,7 +2314,12 @@ impl<G: GlobalIdentityHandlerFactory> Global<G> {
let (caps, formats) = {
let suf = B::get_surface_mut(surface);
let adapter = &adapter_guard[device.adapter_id];
assert!(suf.supports_queue_family(&adapter.raw.queue_families[0]));
assert!(
suf.supports_queue_family(&adapter.raw.queue_families[0]),
"Surface {:?} doesn't support queue family {:?}",
suf,
&adapter.raw.queue_families[0]
);
let formats = suf.supported_formats(&adapter.raw.physical_device);
let caps = suf.capabilities(&adapter.raw.physical_device);
(caps, formats)
@ -2433,7 +2467,12 @@ impl<G: GlobalIdentityHandlerFactory> Global<G> {
let (mut buffer_guard, _) = hub.buffers.write(&mut token);
let buffer = &mut buffer_guard[buffer_id];
assert!(buffer.usage.contains(pub_usage));
assert!(
buffer.usage.contains(pub_usage),
"Buffer usage {:?} must contain usage flag(s) {:?}",
buffer.usage,
pub_usage
);
buffer.map_state = match buffer.map_state {
resource::BufferMapState::Active { .. } => panic!("Buffer already mapped"),
resource::BufferMapState::Waiting(_) => {