chore: remove unimpl. diag. filt. err. check

This commit is contained in:
Erich Gubler 2024-10-24 15:28:05 -04:00
parent 7a5d505896
commit 290ea1553b
3 changed files with 0 additions and 34 deletions

View File

@ -84,13 +84,6 @@ impl FilterableTriggeringRule {
Self::DerivativeUniformity => Self::DERIVATIVE_UNIFORMITY, Self::DerivativeUniformity => Self::DERIVATIVE_UNIFORMITY,
} }
} }
#[cfg(feature = "wgsl-in")]
pub(crate) const fn tracking_issue_num(self) -> u16 {
match self {
FilterableTriggeringRule::DerivativeUniformity => 5320,
}
}
} }
/// A filter that modifies how diagnostics are emitted for shaders. /// A filter that modifies how diagnostics are emitted for shaders.

View File

@ -296,10 +296,6 @@ pub(crate) enum Error<'a> {
severity_control_name_span: Span, severity_control_name_span: Span,
}, },
DiagnosticDuplicateTriggeringRule(ConflictingDiagnosticRuleError), DiagnosticDuplicateTriggeringRule(ConflictingDiagnosticRuleError),
DiagnosticNotYetImplemented {
triggering_rule: FilterableTriggeringRule,
span: Span,
},
} }
impl<'a> From<ConflictingDiagnosticRuleError> for Error<'a> { impl<'a> From<ConflictingDiagnosticRuleError> for Error<'a> {
@ -1047,24 +1043,6 @@ impl<'a> Error<'a> {
.into()], .into()],
} }
} }
Error::DiagnosticNotYetImplemented {
triggering_rule,
span,
} => ParseError {
message: format!(
"the `{}` diagnostic filter is not yet supported",
triggering_rule.to_ident()
),
labels: vec![(span, "".into())],
notes: vec![format!(
concat!(
"Let Naga maintainers know that you ran into this at ",
"<https://github.com/gfx-rs/wgpu/issues/{}>, ",
"so they can prioritize it!"
),
triggering_rule.tracking_issue_num()
)],
},
} }
} }
} }

View File

@ -2534,13 +2534,8 @@ impl Parser {
match kind { match kind {
DirectiveKind::Diagnostic => { DirectiveKind::Diagnostic => {
if let Some(diagnostic_filter) = self.diagnostic_filter(&mut lexer)? { if let Some(diagnostic_filter) = self.diagnostic_filter(&mut lexer)? {
let triggering_rule = diagnostic_filter.triggering_rule;
let span = self.peek_rule_span(&lexer); let span = self.peek_rule_span(&lexer);
diagnostic_filters.add(diagnostic_filter, span)?; diagnostic_filters.add(diagnostic_filter, span)?;
Err(Error::DiagnosticNotYetImplemented {
triggering_rule,
span,
})?;
} }
lexer.expect(Token::Separator(';'))?; lexer.expect(Token::Separator(';'))?;
} }