From 238c3732a42ca1b5eb20ca3afcb8c8f4078ee620 Mon Sep 17 00:00:00 2001
From: Mauro Gentile <62186646+gents83@users.noreply.github.com>
Date: Mon, 27 Nov 2023 13:37:09 +0100
Subject: [PATCH] Don't keep a strong ref in storage for destroyed resources
 (#4786)

---
 wgpu-core/src/storage.rs | 25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/wgpu-core/src/storage.rs b/wgpu-core/src/storage.rs
index e5d5daa16..9b9288391 100644
--- a/wgpu-core/src/storage.rs
+++ b/wgpu-core/src/storage.rs
@@ -16,7 +16,7 @@ pub(crate) enum Element<T> {
 
     /// Like `Occupied`, but the resource has been marked as destroyed
     /// and hasn't been dropped yet.
-    Destroyed(Arc<T>, Epoch),
+    Destroyed(Epoch),
 
     /// Like `Occupied`, but an error occurred when creating the
     /// resource.
@@ -80,7 +80,7 @@ where
             Some(&Element::Vacant) => false,
             Some(
                 &Element::Occupied(_, storage_epoch)
-                | &Element::Destroyed(_, storage_epoch)
+                | &Element::Destroyed(storage_epoch)
                 | &Element::Error(storage_epoch, _),
             ) => storage_epoch == epoch,
             None => false,
@@ -145,7 +145,7 @@ where
         }
         match std::mem::replace(&mut self.map[index], element) {
             Element::Vacant => {}
-            Element::Destroyed(_, storage_epoch) => {
+            Element::Destroyed(storage_epoch) => {
                 assert_ne!(
                     epoch,
                     storage_epoch,
@@ -208,20 +208,15 @@ where
         let slot = &mut self.map[index as usize];
         // borrowck dance: we have to move the element out before we can replace it
         // with another variant with the same value.
-        if let &mut Element::Occupied(..) = slot {
+        if let &mut Element::Occupied(_, e) = slot {
             if let Element::Occupied(value, storage_epoch) =
-                std::mem::replace(slot, Element::Vacant)
+                std::mem::replace(slot, Element::Destroyed(e))
             {
                 debug_assert_eq!(storage_epoch, epoch);
-                *slot = Element::Destroyed(value, storage_epoch);
+                return Ok(value);
             }
         }
-
-        if let Element::Destroyed(ref value, ..) = *slot {
-            Ok(value.clone())
-        } else {
-            Err(InvalidId)
-        }
+        Err(InvalidId)
     }
 
     pub(crate) fn force_replace(&mut self, id: I, value: T) {
@@ -234,10 +229,14 @@ where
         log::trace!("User is removing {}{:?}", T::TYPE, id);
         let (index, epoch, _) = id.unzip();
         match std::mem::replace(&mut self.map[index as usize], Element::Vacant) {
-            Element::Occupied(value, storage_epoch) | Element::Destroyed(value, storage_epoch) => {
+            Element::Occupied(value, storage_epoch) => {
                 assert_eq!(epoch, storage_epoch);
                 Some(value)
             }
+            Element::Destroyed(storage_epoch) => {
+                assert_eq!(epoch, storage_epoch);
+                None
+            }
             Element::Error(..) => None,
             Element::Vacant => panic!("Cannot remove a vacant resource"),
         }