nordic-dev.net/vulkano
nordic-dev.net/vulkano
2
0
Fork 0
mirror of https://github.com/vulkano-rs/vulkano.git synced 2024-11-22 23:05:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed potential overflow in multiview vertex buffer validation (#1855)

Browse Source
This commit is contained in:
m3x3 2022-03-10 20:11:17 +01:00 committed by GitHub
parent 5d20cc4c1d
commit e1558f6913
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
vulkano/src/command_buffer/validity/vertex_buffers.rs
View File

@ -95,7 +95,10 @@ pub(in super::super) fn check_vertex_buffers(
.max_multiview_instance_index
.unwrap_or(0);
if first_instance + instance_count > max_instance_index + 1 {
// The condition is somewhat convoluted to avoid integer overflows.
let out_of_range = first_instance > max_instance_index
|| (instance_count > 0 && instance_count - 1 > max_instance_index - first_instance);
if out_of_range {
return Err(CheckVertexBufferError::TooManyInstances {
instance_count,
max_instance_count: max_instance_index + 1, // TODO: this can overflow