nordic-dev.net/vulkano
nordic-dev.net/vulkano
2
0
Fork 0
mirror of https://github.com/vulkano-rs/vulkano.git synced 2024-11-23 23:35:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix and enforce line endings + stray whitespace (#1099)

Browse Source
This commit is contained in:
Lucas Kent 2018-11-01 14:45:30 +11:00 committed by GitHub
parent 7189c7fa84
commit 64d67b5d0d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
17 changed files with 337 additions and 337 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.travis.yml
View File

@ -22,6 +22,7 @@ addons:
- cmake-data - cmake-data
script: script:
- git diff-tree --check $(git hash-object -t tree /dev/null) HEAD
- travis_wait cargo test --all -j 1 - travis_wait cargo test --all -j 1
- cd examples - cd examples
- cargo build - cargo build

2
CHANGELOG.md
View File

@ -41,7 +41,7 @@ borrowed `str`s.
- Allow `Surface` to own the window it references. - Allow `Surface` to own the window it references.
- Clear value validation for `AutoCommandBufferBuilder::begin_render_pass()` - Clear value validation for `AutoCommandBufferBuilder::begin_render_pass()`
- Fix occasional truncation of glslang_validator when glsl-to-spirv is rebuilt - Fix occasional truncation of glslang_validator when glsl-to-spirv is rebuilt
- Fix linking against MoltenVK >= 0.19.0 - Fix linking against MoltenVK >= 0.19.0
- Fix panic on DeviceLost error after resizing swapchain on nvidia/amd hardware - Fix panic on DeviceLost error after resizing swapchain on nvidia/amd hardware
- Added `AutoCommandBufferBuilder::copy_image` - Added `AutoCommandBufferBuilder::copy_image`
- Added `VulkanObject::TYPE` to look up the `DebugReportObjectTypeEXT` of an object - Added `VulkanObject::TYPE` to look up the `DebugReportObjectTypeEXT` of an object

540
DESIGN.md
View File

@ -1,270 +1,270 @@
This document contains the global design decisions made by the vulkano library. It can also be a This document contains the global design decisions made by the vulkano library. It can also be a
good start if you want to contribute to some internal parts of vulkano and don't know how it works. good start if you want to contribute to some internal parts of vulkano and don't know how it works.
This document assumes that you're already familiar with Vulkan and does not introduce the various This document assumes that you're already familiar with Vulkan and does not introduce the various
concepts. However it can still be a good read if you are not so familiar. concepts. However it can still be a good read if you are not so familiar.
If you notice any mistake, feel free to open a PR. If you want to suggest something, feel free to If you notice any mistake, feel free to open a PR. If you want to suggest something, feel free to
open a PR as well. open a PR as well.
# The three kinds of objects # The three kinds of objects
Vulkano provides wrappers around all objects of the Vulkan API. However these objects are split in Vulkano provides wrappers around all objects of the Vulkan API. However these objects are split in
three categories, depending on their access pattern: three categories, depending on their access pattern:
- Objects that are not created often and in very small numbers. - Objects that are not created often and in very small numbers.
- Objects that are typically created at initialization and which are often accessed without mutation - Objects that are typically created at initialization and which are often accessed without mutation
by performance-critical code. by performance-critical code.
- Objects that are created, destroyed or modified during performance-critical code, and that - Objects that are created, destroyed or modified during performance-critical code, and that
usually require a synchronization strategy to avoid race conditions. usually require a synchronization strategy to avoid race conditions.
The first category are objects that are not created often and created in very small numbers: The first category are objects that are not created often and created in very small numbers:
Instances, Devices, Surfaces, Swapchains. In a typical application each of these objects is only Instances, Devices, Surfaces, Swapchains. In a typical application each of these objects is only
created once and destroyed when the application exits. Vulkano's API provides a struct that created once and destroyed when the application exits. Vulkano's API provides a struct that
corresponds to each of these objects, and this struct is typically wrapped in an `Arc`. corresponds to each of these objects, and this struct is typically wrapped in an `Arc`.
Their `new` method in fact returns an `Arc<T>` instead of just a `T` in order to encourage users to Their `new` method in fact returns an `Arc<T>` instead of just a `T` in order to encourage users to
use `Arc`s. You use these objects by cloning them around like you would use objects in a use `Arc`s. You use these objects by cloning them around like you would use objects in a
garbage-collected language such as Java. garbage-collected language such as Java.
The second category are objects like the GraphicsPipeline, ComputePipeline, PipelineLayout, The second category are objects like the GraphicsPipeline, ComputePipeline, PipelineLayout,
RenderPass and Framebuffer. They are usually created at initialization and don't perform any RenderPass and Framebuffer. They are usually created at initialization and don't perform any
operations themselves, but they describe to the Vulkan implementation operations that we are going operations themselves, but they describe to the Vulkan implementation operations that we are going
to perform and are thus frequently accessed in order to determine whether the operation that the to perform and are thus frequently accessed in order to determine whether the operation that the
vulkano user requested is compliant to what was described. Just like the first category, each of vulkano user requested is compliant to what was described. Just like the first category, each of
these objects has a struct that corresponds to them, but in order to make these checks as fast as these objects has a struct that corresponds to them, but in order to make these checks as fast as
possible these structs have a template parameter that describes in a strongly-typed fashion the possible these structs have a template parameter that describes in a strongly-typed fashion the
operation on the CPU side. This makes it possible to move many checks to compile-time instead of operation on the CPU side. This makes it possible to move many checks to compile-time instead of
runtime. More information in another section of this document. runtime. More information in another section of this document.
The third category are objects like CommandBuffers, CommandPools, DescriptorSets, DescriptorPools, The third category are objects like CommandBuffers, CommandPools, DescriptorSets, DescriptorPools,
Buffers, Images, and memory pools (although not technically a Vulkan object). The way they are Buffers, Images, and memory pools (although not technically a Vulkan object). The way they are
implemented has a huge impact on the performance of the application. Contrary to the first two implemented has a huge impact on the performance of the application. Contrary to the first two
categories, each of these objects is represented in vulkano by an unsafe trait (and not by a categories, each of these objects is represented in vulkano by an unsafe trait (and not by a
struct) that can be freely implemented by the user if they wish. Vulkano provides unsafe structs struct) that can be freely implemented by the user if they wish. Vulkano provides unsafe structs
such as `UnsafeBuffer`, `UnsafeImage`, etc. which have zero overhead and do not perform any safety such as `UnsafeBuffer`, `UnsafeImage`, etc. which have zero overhead and do not perform any safety
checks, and are the tools used by the safe implementations of the traits. Vulkano also provides checks, and are the tools used by the safe implementations of the traits. Vulkano also provides
some safe implementations for convenience such as `CpuAccessibleBuffer` or `AttachmentImage`. some safe implementations for convenience such as `CpuAccessibleBuffer` or `AttachmentImage`.
# Runtime vs compile-time checks # Runtime vs compile-time checks
The second category of objects described above are objects that describe to the Vulkan The second category of objects described above are objects that describe to the Vulkan
implementation an operation that we are going to perform later. For example a `ComputePipeline` implementation an operation that we are going to perform later. For example a `ComputePipeline`
object describes to the Vulkan implementation a compute operation and contains the shader's code object describes to the Vulkan implementation a compute operation and contains the shader's code
and the list of resources that we are going to bind and that are going to be accessed by the shader. and the list of resources that we are going to bind and that are going to be accessed by the shader.
Since vulkano is a safe library, it needs to check whether the operation the user requests (eg. Since vulkano is a safe library, it needs to check whether the operation the user requests (eg.
executing a compute operation) matches the corresponding `ComputePipeline` (for example, check executing a compute operation) matches the corresponding `ComputePipeline` (for example, check
that the list of resources passed by the user matches what the compute pipeline expects). that the list of resources passed by the user matches what the compute pipeline expects).
These checks can be expensive. For example when it comes to buffers, vulkano needs to check whether These checks can be expensive. For example when it comes to buffers, vulkano needs to check whether
the layout of the buffers passed by the user is the same as what is expected, by looping through all the layout of the buffers passed by the user is the same as what is expected, by looping through all
the members and following several indirections. If you multiply this by several dozens or hundreds the members and following several indirections. If you multiply this by several dozens or hundreds
of operations, it can become very expensive. of operations, it can become very expensive.
In order to reduce the stress caused by these checks, structs such as `ComputePipeline` have a In order to reduce the stress caused by these checks, structs such as `ComputePipeline` have a
template parameter which describes the operation. Whenever vulkano performs a check, it queries template parameter which describes the operation. Whenever vulkano performs a check, it queries
the templated object through a trait, and each safety check has its own trait. This means the templated object through a trait, and each safety check has its own trait. This means
that we can build strongly-typed objects at compile-time that describe a very precise operation and that we can build strongly-typed objects at compile-time that describe a very precise operation and
whose method implementations are trivial. For example, we can create a `MyComputeOpDesc` type which whose method implementations are trivial. For example, we can create a `MyComputeOpDesc` type which
implements the `ResourcesListMatch<MyResourcesList>` trait (which was made up for the sake of the implements the `ResourcesListMatch<MyResourcesList>` trait (which was made up for the sake of the
example), and the user will only be able to pass a `MyResourcesList` object for the list of example), and the user will only be able to pass a `MyResourcesList` object for the list of
resources. This moves the check to compile-time and totally eliminates any runtime check. The resources. This moves the check to compile-time and totally eliminates any runtime check. The
compute pipeline is then expressed as `ComputePipeline<MyComputeOpDesc>`. compute pipeline is then expressed as `ComputePipeline<MyComputeOpDesc>`.
However this design has a drawback, which is that is can be difficult to explicitly express such a However this design has a drawback, which is that is can be difficult to explicitly express such a
type. A compute pipeline in the example above could be expressed as type. A compute pipeline in the example above could be expressed as
`ComputePipeline<MyComputeOpDesc>`, but in practice these types (like `MyComputeOpDesc`) would be `ComputePipeline<MyComputeOpDesc>`, but in practice these types (like `MyComputeOpDesc`) would be
built by builders and can become extremely long and annoying to put in a struct (just like for built by builders and can become extremely long and annoying to put in a struct (just like for
example the type of `(10..).filter(|n| n*2).skip(3).take(5)` can be very long and annoying to put example the type of `(10..).filter(|n| n*2).skip(3).take(5)` can be very long and annoying to put
in a struct). This is especially problematic as it concerns objects that are usually created at in a struct). This is especially problematic as it concerns objects that are usually created at
initialization and stay alive for a long time, in other words the kind of objects that you would initialization and stay alive for a long time, in other words the kind of objects that you would
put in a struct. put in a struct.
In order to solve this naming problem, all the traits that are used to describe operations must be In order to solve this naming problem, all the traits that are used to describe operations must be
boxable so that we can turn `ComputePipeline<Very<Long<And<Complicated, Type>>>>` into boxable so that we can turn `ComputePipeline<Very<Long<And<Complicated, Type>>>>` into
`ComputePipeline<Box<ComputePipelineDesc>>`. This means that we can't use associated types and `ComputePipeline<Box<ComputePipelineDesc>>`. This means that we can't use associated types and
templates for any of the trait methods. Ideologically it is a bit annoying to have to restrict templates for any of the trait methods. Ideologically it is a bit annoying to have to restrict
ourselves in what we can do just because the user needs to be able to write out the precise type, ourselves in what we can do just because the user needs to be able to write out the precise type,
but it's the only pragmatic solution for now. but it's the only pragmatic solution for now.
# Submissions # Submissions
Any object that can be submitted to a GPU queue (for example a command buffer) implements Any object that can be submitted to a GPU queue (for example a command buffer) implements
the `Submit` trait. the `Submit` trait.
The `Submit` trait provides a function named `build` which returns a `Submission<Self>` object The `Submit` trait provides a function named `build` which returns a `Submission<Self>` object
(where `Self` is the type that implements the `Submit` trait). The `Submission` object must be kept (where `Self` is the type that implements the `Submit` trait). The `Submission` object must be kept
alive by the user for as long as the GPU hasn't finished executing the submission. Trying to alive by the user for as long as the GPU hasn't finished executing the submission. Trying to
destroy a `Submission` will block until it is the case. Since the `Submission` holds the object destroy a `Submission` will block until it is the case. Since the `Submission` holds the object
that was submitted, this object is also kept alive for as long as the GPU hasn't finished executing that was submitted, this object is also kept alive for as long as the GPU hasn't finished executing
it. it.
For the moment submitting an object always creates a fence, which is how the `Submission` knows For the moment submitting an object always creates a fence, which is how the `Submission` knows
whether the GPU has finished executing it. Eventually this will need to be modified for the sake of whether the GPU has finished executing it. Eventually this will need to be modified for the sake of
performance. performance.
In order to make the `Submit` trait safer to implement, the method that actually needs to be In order to make the `Submit` trait safer to implement, the method that actually needs to be
implemented is not `build` but `append_submission`. This method uses a API/lifetime trick to implemented is not `build` but `append_submission`. This method uses a API/lifetime trick to
guarantee that the GPU only executes command buffers that outlive the struct that implements guarantee that the GPU only executes command buffers that outlive the struct that implements
`Submit`. `Submit`.
SAFETY ISSUE HERE HOWEVER: the user can use mem::forget on the Submission and then drop the SAFETY ISSUE HERE HOWEVER: the user can use mem::forget on the Submission and then drop the
objects referenced by it. There are two solutions to this: either store a bunch of Arc<Fence> in objects referenced by it. There are two solutions to this: either store a bunch of Arc<Fence> in
every single object referenced by submissions (eg. pipeline objects), or force the user to use every single object referenced by submissions (eg. pipeline objects), or force the user to use
either Arcs or give ownership of the object. The latter is preferred but not yet implemented. either Arcs or give ownership of the object. The latter is preferred but not yet implemented.
# Pools # Pools
There are three kinds of pools in vulkano: memory pools, descriptor pools, and command pools. Only There are three kinds of pools in vulkano: memory pools, descriptor pools, and command pools. Only
the last two are technically Vulkan concepts, but using a memory pool is also a very common the last two are technically Vulkan concepts, but using a memory pool is also a very common
pattern that you are strongly encouraged to embrace when you write a Vulkan application. pattern that you are strongly encouraged to embrace when you write a Vulkan application.
These three kinds of pools are each represented in vulkano by a trait. When you use the Vulkan API, These three kinds of pools are each represented in vulkano by a trait. When you use the Vulkan API,
you are expected to create multiple command pools and multiple descriptor pools for maximum you are expected to create multiple command pools and multiple descriptor pools for maximum
performance. In vulkano however, it is the implementation of the pool trait that is responsible performance. In vulkano however, it is the implementation of the pool trait that is responsible
for managing multiple actual pool objects. In other words a pool in vulkano is just a trait that for managing multiple actual pool objects. In other words a pool in vulkano is just a trait that
provides a method to allocate or free some resource, and the advanced functionality of Vulkan provides a method to allocate or free some resource, and the advanced functionality of Vulkan
pools (like resetting a command buffer, resetting a pool, or managing the descriptor pool's pools (like resetting a command buffer, resetting a pool, or managing the descriptor pool's
capacity) is handled internally by the implementation of the trait. For example freeing a capacity) is handled internally by the implementation of the trait. For example freeing a
command buffer can be implemented by resetting it and reusing it, instead of actually freeing it. command buffer can be implemented by resetting it and reusing it, instead of actually freeing it.
One of the goals of vulkano is to be easy to use by default. Therefore vulkano provides a default One of the goals of vulkano is to be easy to use by default. Therefore vulkano provides a default
implementation for each of these pools, and the `new` constructors of types that need a pool (ie. implementation for each of these pools, and the `new` constructors of types that need a pool (ie.
buffers, images, descriptor sets, and command buffers) will use the default implementation. It is buffers, images, descriptor sets, and command buffers) will use the default implementation. It is
possible for the user to use an alternative implementation of a pool by using an alternative possible for the user to use an alternative implementation of a pool by using an alternative
constructor, but the default implementations should be good for most usages. This is similar to constructor, but the default implementations should be good for most usages. This is similar to
memory allocators in languages such as C++ and Rust, in the sense that some users want to be able memory allocators in languages such as C++ and Rust, in the sense that some users want to be able
to use a custom allocator but most of the time it's not worth bothering with that. to use a custom allocator but most of the time it's not worth bothering with that.
# Command buffers # Command buffers
Command buffer objects belong to the last category of objects that were described above. They are Command buffer objects belong to the last category of objects that were described above. They are
represented by an unsafe trait and can be implemented manually by the user if they wish. represented by an unsafe trait and can be implemented manually by the user if they wish.
However this poses a practical problem, which is that creating a command buffer in a safe way However this poses a practical problem, which is that creating a command buffer in a safe way
is really complicated. There are tons of commands to implement, and each command has a ton of is really complicated. There are tons of commands to implement, and each command has a ton of
safety requirements. If a user wants to create a custom command buffer type, it is just not an safety requirements. If a user wants to create a custom command buffer type, it is just not an
option to ask them to reimplement these safety checks themselves. option to ask them to reimplement these safety checks themselves.
The reason why users may want to create their own command buffer types is to implement The reason why users may want to create their own command buffer types is to implement
synchronization themselves. Vulkano's default implementation (which is `AutobarriersCommandBuffer`) synchronization themselves. Vulkano's default implementation (which is `AutobarriersCommandBuffer`)
will automatically place pipeline barriers in order to handle cache flushes and image layout will automatically place pipeline barriers in order to handle cache flushes and image layout
transitions and avoid data races, but this automatic computation can be seen as expensive. transitions and avoid data races, but this automatic computation can be seen as expensive.
In order to make it possible to customize the synchronization story of command buffers, vulkano has In order to make it possible to customize the synchronization story of command buffers, vulkano has
split the command buffer building process in two steps. First the user builds a list of commands split the command buffer building process in two steps. First the user builds a list of commands
through an iterator-like API (and vulkano will check their validity), and then they are turned into through an iterator-like API (and vulkano will check their validity), and then they are turned into
a command buffer through a trait. This means that the user can customize the synchronization a command buffer through a trait. This means that the user can customize the synchronization
strategy (by customizing the second step) while still using the same command-building process strategy (by customizing the second step) while still using the same command-building process
(the first step). Commands are not opinionated towards one strategy or another. The (the first step). Commands are not opinionated towards one strategy or another. The
command-building code is totally isolated from the synchronization strategy and only checks command-building code is totally isolated from the synchronization strategy and only checks
whether the commands themselves are valid. whether the commands themselves are valid.
The fact that all the commands are added at once can be a little surprising for a user coming from The fact that all the commands are added at once can be a little surprising for a user coming from
Vulkan. Vulkano's API looks very similar to Vulkan's API, but there is a major difference: in Vulkan. Vulkano's API looks very similar to Vulkan's API, but there is a major difference: in
Vulkan the cost of creating a command buffer is distributed between each function call, but in Vulkan the cost of creating a command buffer is distributed between each function call, but in
vulkano it is done all at once. For example creating a command buffer with 6 commands with Vulkan vulkano it is done all at once. For example creating a command buffer with 6 commands with Vulkan
requires 8 function calls that take say 5µs each, while creating the same command buffer with requires 8 function calls that take say 5µs each, while creating the same command buffer with
vulkano requires 8 function calls, but the first 7 are almost free and the last one takes 40µs. vulkano requires 8 function calls, but the first 7 are almost free and the last one takes 40µs.
After some thinking, it was considered to not be a problem. After some thinking, it was considered to not be a problem.
Creating a list of commands with an iterator-like API has the problem that the type of the list of Creating a list of commands with an iterator-like API has the problem that the type of the list of
commands changes every time you add a new command to the list commands changes every time you add a new command to the list
(just like for example `let iterator = iterator.skip(1)` changes the type of `iterator`). This is (just like for example `let iterator = iterator.skip(1)` changes the type of `iterator`). This is
a problem in situations where we don't know at compile-time the number of commands that we are a problem in situations where we don't know at compile-time the number of commands that we are
going to add. In order to solve this, it is required that the `CommandsList` trait be boxable, going to add. In order to solve this, it is required that the `CommandsList` trait be boxable,
so that the user can use a `Box<CommandsList>`. This is unfortunately not optimal as you will need so that the user can use a `Box<CommandsList>`. This is unfortunately not optimal as you will need
a memory allocation for each command that is added to the list. The situation here could still be a memory allocation for each command that is added to the list. The situation here could still be
improved. improved.
# The auto-barriers builder # The auto-barriers builder
As explained above, the default implementation of a command buffer provided by vulkano As explained above, the default implementation of a command buffer provided by vulkano
automatically places pipeline barriers to avoid issues such as caches not being flushed, commands automatically places pipeline barriers to avoid issues such as caches not being flushed, commands
being executed simultaneously when they shouldn't, or images having the wrong layout. being executed simultaneously when they shouldn't, or images having the wrong layout.
This is not an easy job, because Vulkan allows lots of weird access patterns that we want to make This is not an easy job, because Vulkan allows lots of weird access patterns that we want to make
available in vulkano. You can for example create a buffer object split into multiple sub-buffer available in vulkano. You can for example create a buffer object split into multiple sub-buffer
objects, or make some images and buffers share the same memory. objects, or make some images and buffers share the same memory.
In order to make it possible to handle everything properly, the `Buffer` and `Image` traits need to In order to make it possible to handle everything properly, the `Buffer` and `Image` traits need to
help us with the `conflicts` methods. Each buffer and image can be queried to know whether it help us with the `conflicts` methods. Each buffer and image can be queried to know whether it
potentially uses the same memory as any other buffer or image. When two resources conflict, this potentially uses the same memory as any other buffer or image. When two resources conflict, this
means that you can't write to one and read from the other one simultaneously or write to both means that you can't write to one and read from the other one simultaneously or write to both
simultaneously. simultaneously.
But we don't want to check every single combination of buffer and image every time to check whether But we don't want to check every single combination of buffer and image every time to check whether
they conflict. So in order to improve performance, buffers and images also need to provide a key they conflict. So in order to improve performance, buffers and images also need to provide a key
that identifies them. Two resources that can potentially conflict must always return the same key. that identifies them. Two resources that can potentially conflict must always return the same key.
The regular `conflict` functions are still necessary to handle the situation where buffers or The regular `conflict` functions are still necessary to handle the situation where buffers or
images accidentally return the same key but don't actually conflict. images accidentally return the same key but don't actually conflict.
This conflict system is also used to make sure that the attachments of a framebuffer don't conflict This conflict system is also used to make sure that the attachments of a framebuffer don't conflict
with each other or that the resources in a descriptor set don't conflict with each other (both with each other or that the resources in a descriptor set don't conflict with each other (both
situations are forbidden). situations are forbidden).
# Image layouts # Image layouts
Tracking image layouts can be tedious. Vulkano uses a simple solution, which is that images must Tracking image layouts can be tedious. Vulkano uses a simple solution, which is that images must
always be in a specific layout at the beginning and the end of a command buffer. If a transition always be in a specific layout at the beginning and the end of a command buffer. If a transition
is performed during a command buffer, the image must be transitioned back before the end of the is performed during a command buffer, the image must be transitioned back before the end of the
command buffer. The layout in question is queried with a method on the `Image` trait. command buffer. The layout in question is queried with a method on the `Image` trait.
For example an `AttachmentImage` must always be in the `ColorAttachmentOptimal` layout for color For example an `AttachmentImage` must always be in the `ColorAttachmentOptimal` layout for color
attachment, and the `DepthStencilAttachmentOptimal` layout for depth-stencil attachments. If any attachment, and the `DepthStencilAttachmentOptimal` layout for depth-stencil attachments. If any
command switches the image to another layout, then it will need to be switched back before the end command switches the image to another layout, then it will need to be switched back before the end
of the command buffer. of the command buffer.
This system works very nicely in practice, and unnecessary layout transitions almost never happen. This system works very nicely in practice, and unnecessary layout transitions almost never happen.
The only situation where unnecessary transitions tend to happen in practice is for swapchain images The only situation where unnecessary transitions tend to happen in practice is for swapchain images
that are transitioned from `PresentSrc` to `ColorAttachmentOptimal` before the start of the that are transitioned from `PresentSrc` to `ColorAttachmentOptimal` before the start of the
render pass, because the initial layout of the render pass attachment is `ColorAttachmentOptimal` render pass, because the initial layout of the render pass attachment is `ColorAttachmentOptimal`
by default for color attachments. Vulkano should make it clear in the documentation of render by default for color attachments. Vulkano should make it clear in the documentation of render
passes that the user is encouraged to specify when an attachment is expected to be in the passes that the user is encouraged to specify when an attachment is expected to be in the
`PresentSrc` layout. `PresentSrc` layout.
The only problematic area concerns the first usage of an image, where it must be transitioned from The only problematic area concerns the first usage of an image, where it must be transitioned from
the `Undefined` or `Preinitialized` layout. This is done by making the user pass a command buffer the `Undefined` or `Preinitialized` layout. This is done by making the user pass a command buffer
builder in the constructor of images, and the constructor adds a transition command to it. The builder in the constructor of images, and the constructor adds a transition command to it. The
image implementation is responsible for making sure that the transition command has been submitted image implementation is responsible for making sure that the transition command has been submitted
before any further command that uses the image. before any further command that uses the image.
# Inter-queue synchronization # Inter-queue synchronization
When users submit two command buffers to two different queues, they expect the two command buffers When users submit two command buffers to two different queues, they expect the two command buffers
to execute in parallel. However this is forbidden if doing so could result in a data race, to execute in parallel. However this is forbidden if doing so could result in a data race,
like for example if one command buffer writes to an image and the other one reads from that same like for example if one command buffer writes to an image and the other one reads from that same
image. image.
In this situation, the only possible technical solution is to make the execution of the second In this situation, the only possible technical solution is to make the execution of the second
command buffer block until the first command buffer has finished executing. command buffer block until the first command buffer has finished executing.
This case is similar to spawning two threads that each access the same resource protected by This case is similar to spawning two threads that each access the same resource protected by
a `RwLock` or a `Mutex`. One of the two threads will need to block until the first one is finished. a `RwLock` or a `Mutex`. One of the two threads will need to block until the first one is finished.
This raises the question: should vulkano implicitly block command buffers to avoid data races, This raises the question: should vulkano implicitly block command buffers to avoid data races,
or should it force the user to explicitly add wait operations? By comparing a CPU-side or should it force the user to explicitly add wait operations? By comparing a CPU-side
multithreaded program and a GPU-side multithreaded program, then the answer is to make it implicit, multithreaded program and a GPU-side multithreaded program, then the answer is to make it implicit,
as a CPU will also implicitly block when calling a function that happens to lock a `Mutex` or as a CPU will also implicitly block when calling a function that happens to lock a `Mutex` or
a `RwLock`. In CPU code, these locking problems are always "fixed" by properly documenting the a `RwLock`. In CPU code, these locking problems are always "fixed" by properly documenting the
behavior of the functions you call. Similarly, vulkano should precisely document its behavior. behavior of the functions you call. Similarly, vulkano should precisely document its behavior.
More generally users are encouraged to avoid sharing resources between multiple queues unless these More generally users are encouraged to avoid sharing resources between multiple queues unless these
resources are read-only, and in practice in a video game it is indeed rarely needed to share resources are read-only, and in practice in a video game it is indeed rarely needed to share
resources between multiple queues. Just like for CPU-side multithreading, users are encouraged to resources between multiple queues. Just like for CPU-side multithreading, users are encouraged to
have a graph of the ways queues interact with each other. have a graph of the ways queues interact with each other.
However another problem arises. In order to make a command buffer wait for another, you need to However another problem arises. In order to make a command buffer wait for another, you need to
make the queue of the first command buffer submit a semaphore after execution, and the queue of make the queue of the first command buffer submit a semaphore after execution, and the queue of
the second command buffer wait on that same semaphore before execution. Semaphores can only be used the second command buffer wait on that same semaphore before execution. Semaphores can only be used
once. This means that when you submit a command buffer to a queue, you must already know if any once. This means that when you submit a command buffer to a queue, you must already know if any
other command buffers are going to wait on the one you are submitting, and if so how many. This is not other command buffers are going to wait on the one you are submitting, and if so how many. This is not
something that vulkano can automatically determine. The fact that there is therefore no optimal something that vulkano can automatically determine. The fact that there is therefore no optimal
algorithm for implicit synchronization would be a good point in favor of explicit synchronization. algorithm for implicit synchronization would be a good point in favor of explicit synchronization.
The decision was taken to encourage users to explicitly handle synchronization between multiple The decision was taken to encourage users to explicitly handle synchronization between multiple
queues, but if they forget to do so then vulkano will automatically fall back to a dumb queues, but if they forget to do so then vulkano will automatically fall back to a dumb
worst-case-scenario but safe behavior. Whenever this dumb behavior is triggered, a debug message worst-case-scenario but safe behavior. Whenever this dumb behavior is triggered, a debug message
is outputted by vulkano with the `vkDebugReportMessageEXT` function. This message can easily be is outputted by vulkano with the `vkDebugReportMessageEXT` function. This message can easily be
caught by the user by registering a callback, or with a debugger. caught by the user by registering a callback, or with a debugger.
It is yet to be determined what exactly the user needs to handle. The user will at least need to It is yet to be determined what exactly the user needs to handle. The user will at least need to
specify an optional list of semaphores to signal at each submission, but maybe not the list of specify an optional list of semaphores to signal at each submission, but maybe not the list of
semaphores to wait upon if these can be determined automatically. This has yet to be seen. semaphores to wait upon if these can be determined automatically. This has yet to be seen.

6
README.md
View File

@ -100,14 +100,14 @@ Vulkan is not natively supported by macOS and iOS. However, there exists [Molten
a Vulkan implementation on top of Apple's Metal API. This allows vulkano to build and run on macOS a Vulkan implementation on top of Apple's Metal API. This allows vulkano to build and run on macOS
and iOS platforms. and iOS platforms.
The easiest way to get vulkano up and running on macOS is to install the The easiest way to get vulkano up and running on macOS is to install the
[Vulkan SDK for macOS](https://vulkan.lunarg.com/sdk/home). To install the SDK so that [Vulkan SDK for macOS](https://vulkan.lunarg.com/sdk/home). To install the SDK so that
Vulkano will find it and dynamically link with `libvulkan.dylib`: Vulkano will find it and dynamically link with `libvulkan.dylib`:
1. Download the latest macOS release and unpack it somewhere, for the next step 1. Download the latest macOS release and unpack it somewhere, for the next step
we'll assume that's `~/vulkan_sdk`. we'll assume that's `~/vulkan_sdk`.
2. Modify your environment to contain the SDK bin directory in PATH and the SDK lib directory in 2. Modify your environment to contain the SDK bin directory in PATH and the SDK lib directory in
DYLD_LIBRARY_PATH. We also need to set VK_ICD_FILENAMES and VK_LAYER_PATH. When using the Bash DYLD_LIBRARY_PATH. We also need to set VK_ICD_FILENAMES and VK_LAYER_PATH. When using the Bash
shell, which is the default for macOS, it's easiest to do this by appending the following to the shell, which is the default for macOS, it's easiest to do this by appending the following to the
`~/.bash_profile` file and then restarting the terminal. `~/.bash_profile` file and then restarting the terminal.

2
examples/src/bin/deferred/frame/system.rs
View File

@ -349,7 +349,7 @@ impl<'a> Frame<'a> {
// If we are in pass 2 then we have finished applying lighting. // If we are in pass 2 then we have finished applying lighting.
// We take the builder, call `end_render_pass()`, and then `build()` it to obtain // We take the builder, call `end_render_pass()`, and then `build()` it to obtain
// an actual command buffer. // an actual command buffer.
let command_buffer = let command_buffer =
self.command_buffer self.command_buffer
.take() .take()
.unwrap() .unwrap()

12
examples/src/bin/deferred/main.rs
View File

@ -9,19 +9,19 @@
// Welcome to the deferred lighting example! // Welcome to the deferred lighting example!
// //
// The idea behind deferred lighting is to render the scene in two steps. // The idea behind deferred lighting is to render the scene in two steps.
// //
// First you draw all the objects of the scene. But instead of calculating the color they will // First you draw all the objects of the scene. But instead of calculating the color they will
// have on the screen, you output their characteristics such as their diffuse color and their // have on the screen, you output their characteristics such as their diffuse color and their
// normals, and write this to images. // normals, and write this to images.
// //
// After all the objects are drawn, you should obtain several images that contain the // After all the objects are drawn, you should obtain several images that contain the
// characteristics of each pixel. // characteristics of each pixel.
// //
// Then you apply lighting to the scene. In other words you draw to the final image by taking // Then you apply lighting to the scene. In other words you draw to the final image by taking
// these intermediate images and the various lights of the scene as input. // these intermediate images and the various lights of the scene as input.
// //
// This technique allows you to apply tons of light sources to a scene, which would be too // This technique allows you to apply tons of light sources to a scene, which would be too
// expensive otherwise. It has some drawbacks, which are the fact that transparent objects must be // expensive otherwise. It has some drawbacks, which are the fact that transparent objects must be
// drawn after the lighting, and that the whole process consumes more memory. // drawn after the lighting, and that the whole process consumes more memory.
@ -111,7 +111,7 @@ fn main() {
} else { } else {
return; return;
}; };
let (new_swapchain, new_images) = match swapchain.recreate_with_dimension(dimensions) { let (new_swapchain, new_images) = match swapchain.recreate_with_dimension(dimensions) {
Ok(r) => r, Ok(r) => r,
Err(SwapchainCreationError::UnsupportedDimensions) => { Err(SwapchainCreationError::UnsupportedDimensions) => {

22
examples/src/bin/msaa-renderpass.rs
View File

@ -10,53 +10,53 @@
//! Multisampling anti-aliasing example, using a render pass resolve. //! Multisampling anti-aliasing example, using a render pass resolve.
//! //!
//! # Introduction to multisampling //! # Introduction to multisampling
//! //!
//! When you draw an object on an image, this object occupies a certain set of pixels. Each pixel //! When you draw an object on an image, this object occupies a certain set of pixels. Each pixel
//! of the image is either fully covered by the object, or not covered at all. There is no such //! of the image is either fully covered by the object, or not covered at all. There is no such
//! thing as a pixel that is half-covered by the object that you're drawing. What this means is //! thing as a pixel that is half-covered by the object that you're drawing. What this means is
//! that you will sometimes see a "staircase effect" at the border of your object, also called //! that you will sometimes see a "staircase effect" at the border of your object, also called
//! aliasing. //! aliasing.
//! //!
//! The root cause of aliasing is that the resolution of the image is not high enough. If you //! The root cause of aliasing is that the resolution of the image is not high enough. If you
//! increase the size of the image you're drawing to, this effect will still exist but will be //! increase the size of the image you're drawing to, this effect will still exist but will be
//! much less visible. //! much less visible.
//! //!
//! In order to decrease aliasing, some games and programs use what we call "Super-Sampling Anti //! In order to decrease aliasing, some games and programs use what we call "Super-Sampling Anti
//! Aliasing" (SSAA). For example instead of drawing to an image of size 1024x1024, you draw to an //! Aliasing" (SSAA). For example instead of drawing to an image of size 1024x1024, you draw to an
//! image of size 4096x4096. Then at the end, you scale down your image to 1024x1024 by merging //! image of size 4096x4096. Then at the end, you scale down your image to 1024x1024 by merging
//! nearby pixels. Since the intermediate image is 4 times larger than the destination, this would //! nearby pixels. Since the intermediate image is 4 times larger than the destination, this would
//! be x4 SSAA. //! be x4 SSAA.
//! //!
//! However this technique is very expensive in terms of GPU power. The fragment shader and all //! However this technique is very expensive in terms of GPU power. The fragment shader and all
//! its calculations has to run four times more often. //! its calculations has to run four times more often.
//! //!
//! So instead of SSAA, a common alternative is MSAA (MultiSampling Anti Aliasing). The base //! So instead of SSAA, a common alternative is MSAA (MultiSampling Anti Aliasing). The base
//! principle is more or less the same: you draw to an image of a larger dimension, and then at //! principle is more or less the same: you draw to an image of a larger dimension, and then at
//! the end you scale it down to the final size. The difference is that the fragment shader is //! the end you scale it down to the final size. The difference is that the fragment shader is
//! only run once per pixel of the final size, and its value is duplicated to fill to all the //! only run once per pixel of the final size, and its value is duplicated to fill to all the
//! pixels of the intermediate image that are covered by the object. //! pixels of the intermediate image that are covered by the object.
//! //!
//! For example, let's say that you use x4 MSAA, you draw to an intermediate image of size //! For example, let's say that you use x4 MSAA, you draw to an intermediate image of size
//! 4096x4096, and your object covers the whole image. With MSAA, the fragment shader will only //! 4096x4096, and your object covers the whole image. With MSAA, the fragment shader will only
//! be 1,048,576 times (1024 * 1024), compared to 16,777,216 times (4096 * 4096) with 4x SSAA. //! be 1,048,576 times (1024 * 1024), compared to 16,777,216 times (4096 * 4096) with 4x SSAA.
//! Then the output of each fragment shader invocation is copied in each of the four pixels of the //! Then the output of each fragment shader invocation is copied in each of the four pixels of the
//! intermediate image that correspond to each pixel of the final image. //! intermediate image that correspond to each pixel of the final image.
//! //!
//! Now, let's say that your object doesn't cover the whole image. In this situation, only the //! Now, let's say that your object doesn't cover the whole image. In this situation, only the
//! pixels of the intermediate image that are covered by the object will receive the output of the //! pixels of the intermediate image that are covered by the object will receive the output of the
//! fragment shader. //! fragment shader.
//! //!
//! Because of the way it works, this technique requires direct support from the hardware, //! Because of the way it works, this technique requires direct support from the hardware,
//! contrary to SSAA which can be done on any machine. //! contrary to SSAA which can be done on any machine.
//! //!
//! # Multisampled images //! # Multisampled images
//! //!
//! Using MSAA with Vulkan is done by creating a regular image, but with a number of samples per //! Using MSAA with Vulkan is done by creating a regular image, but with a number of samples per
//! pixel different from 1. For example if you want to use 4x MSAA, you should create an image with //! pixel different from 1. For example if you want to use 4x MSAA, you should create an image with
//! 4 samples per pixel. Internally this image will have 4 times as many pixels as its dimensions //! 4 samples per pixel. Internally this image will have 4 times as many pixels as its dimensions
//! would normally require, but this is handled transparently for you. Drawing to a multisampled //! would normally require, but this is handled transparently for you. Drawing to a multisampled
//! image is exactly the same as drawing to a regular image. //! image is exactly the same as drawing to a regular image.
//! //!
//! However multisampled images have some restrictions, for example you can't show them on the //! However multisampled images have some restrictions, for example you can't show them on the
//! screen (swapchain images are always single-sampled), and you can't copy them into a buffer. //! screen (swapchain images are always single-sampled), and you can't copy them into a buffer.
//! Therefore when you have finished drawing, you have to blit your multisampled image to a //! Therefore when you have finished drawing, you have to blit your multisampled image to a

6
examples/src/bin/teapot/main.rs
View File

@ -144,7 +144,7 @@ fn main() {
} else { } else {
return; return;
}; };
let (new_swapchain, new_images) = match swapchain.recreate_with_dimension(dimensions) { let (new_swapchain, new_images) = match swapchain.recreate_with_dimension(dimensions) {
Ok(r) => r, Ok(r) => r,
Err(SwapchainCreationError::UnsupportedDimensions) => continue, Err(SwapchainCreationError::UnsupportedDimensions) => continue,
@ -205,11 +205,11 @@ fn main() {
.draw_indexed( .draw_indexed(
pipeline.clone(), pipeline.clone(),
&DynamicState::none(), &DynamicState::none(),
vec!(vertex_buffer.clone(), normals_buffer.clone()), vec!(vertex_buffer.clone(), normals_buffer.clone()),
index_buffer.clone(), set.clone(), ()).unwrap() index_buffer.clone(), set.clone(), ()).unwrap()
.end_render_pass().unwrap() .end_render_pass().unwrap()
.build().unwrap(); .build().unwrap();
let future = previous_frame.join(acquire_future) let future = previous_frame.join(acquire_future)
.then_execute(queue.clone(), command_buffer).unwrap() .then_execute(queue.clone(), command_buffer).unwrap()
.then_swapchain_present(queue.clone(), swapchain.clone(), image_num) .then_swapchain_present(queue.clone(), swapchain.clone(), image_num)

2
examples/src/bin/triangle.rs
View File

@ -255,7 +255,7 @@ void main() {
store: Store, store: Store,
// `format: <ty>` indicates the type of the format of the image. This has to // `format: <ty>` indicates the type of the format of the image. This has to
// be one of the types of the `vulkano::format` module (or alternatively one // be one of the types of the `vulkano::format` module (or alternatively one
// of your structs that implements the `FormatDesc` trait). Here we use the // of your structs that implements the `FormatDesc` trait). Here we use the
// same format as the swapchain. // same format as the swapchain.
format: swapchain.format(), format: swapchain.format(),
// TODO: // TODO:

18
vulkano-shaders/src/lib.rs
View File

@ -33,9 +33,9 @@
//! module like some normal macro crates do since derive macros cannot be used from //! module like some normal macro crates do since derive macros cannot be used from
//! the crate they are declared in. On the other hand, if you are looking for a //! the crate they are declared in. On the other hand, if you are looking for a
//! high-level overview, you can see the below section. //! high-level overview, you can see the below section.
//! //!
//! # Generated code overview //! # Generated code overview
//! //!
//! The macro generates the following items of interest: //! The macro generates the following items of interest:
//! * The `Shader` struct. This contains a single field, `shader`, which is an //! * The `Shader` struct. This contains a single field, `shader`, which is an
//! `Arc<ShaderModule>`. //! `Arc<ShaderModule>`.
@ -61,11 +61,11 @@
//! specialization constant found in the shader data. Implementations of //! specialization constant found in the shader data. Implementations of
//! `Default` and [`SpecializationConstants`][SpecializationConstants] are also //! `Default` and [`SpecializationConstants`][SpecializationConstants] are also
//! generated for the struct. //! generated for the struct.
//! //!
//! All of these generated items will be accessed through the module specified //! All of these generated items will be accessed through the module specified
//! by `mod_name: foo` If you wanted to store the `Shader` in a struct of your own, //! by `mod_name: foo` If you wanted to store the `Shader` in a struct of your own,
//! you could do something like this: //! you could do something like this:
//! //!
//! ``` //! ```
//! # extern crate vulkano_shaders; //! # extern crate vulkano_shaders;
//! # extern crate vulkano; //! # extern crate vulkano;
@ -89,11 +89,11 @@
//! # } //! # }
//! // various use statements //! // various use statements
//! // `vertex_shader` module with shader derive //! // `vertex_shader` module with shader derive
//! //!
//! pub struct Shaders { //! pub struct Shaders {
//! pub vs: vs::Shader //! pub vs: vs::Shader
//! } //! }
//! //!
//! impl Shaders { //! impl Shaders {
//! pub fn load(device: Arc<Device>) -> Result<Self, OomError> { //! pub fn load(device: Arc<Device>) -> Result<Self, OomError> {
//! Ok(Self { //! Ok(Self {
@ -102,9 +102,9 @@
//! } //! }
//! } //! }
//! ``` //! ```
//! //!
//! # Options //! # Options
//! //!
//! The options available are in the form of the following attributes: //! The options available are in the form of the following attributes:
//! //!
//! ## `ty: "..."` //! ## `ty: "..."`
@ -134,7 +134,7 @@
//! ## `dump: true` //! ## `dump: true`
//! //!
//! The crate fails to compile but prints the generated rust code to stdout. //! The crate fails to compile but prints the generated rust code to stdout.
//! //!
//! [reflect]: https://github.com/vulkano-rs/vulkano/blob/master/vulkano-shaders/src/lib.rs#L67 //! [reflect]: https://github.com/vulkano-rs/vulkano/blob/master/vulkano-shaders/src/lib.rs#L67
//! [cargo-expand]: https://github.com/dtolnay/cargo-expand //! [cargo-expand]: https://github.com/dtolnay/cargo-expand
//! [ShaderModule::new]: https://docs.rs/vulkano/*/vulkano/pipeline/shader/struct.ShaderModule.html#method.new //! [ShaderModule::new]: https://docs.rs/vulkano/*/vulkano/pipeline/shader/struct.ShaderModule.html#method.new

40
vulkano/Cargo.toml
View File

@ -1,20 +1,20 @@
[package] [package]
name = "vulkano" name = "vulkano"
version = "0.10.0" version = "0.10.0"
authors = ["Pierre Krieger <pierre.krieger1708@gmail.com>", "The vulkano contributors"] authors = ["Pierre Krieger <pierre.krieger1708@gmail.com>", "The vulkano contributors"]
repository = "https://github.com/vulkano-rs/vulkano" repository = "https://github.com/vulkano-rs/vulkano"
description = "Safe wrapper for the Vulkan graphics API" description = "Safe wrapper for the Vulkan graphics API"
license = "MIT/Apache-2.0" license = "MIT/Apache-2.0"
documentation = "https://docs.rs/vulkano" documentation = "https://docs.rs/vulkano"
readme = "../README.md" readme = "../README.md"
categories = ["rendering::graphics-api"] categories = ["rendering::graphics-api"]
build = "build.rs" build = "build.rs"
[dependencies] [dependencies]
crossbeam = "0.4" crossbeam = "0.4"
fnv = "1.0.6" fnv = "1.0.6"
shared_library = "0.1.7" shared_library = "0.1.7"
smallvec = "0.6.0" smallvec = "0.6.0"
lazy_static = "1" lazy_static = "1"
vk-sys = { version = "0.3.3", path = "../vk-sys" } vk-sys = { version = "0.3.3", path = "../vk-sys" }
half = "1" half = "1"

2
vulkano/src/command_buffer/auto.rs
View File

@ -547,7 +547,7 @@ impl<P> AutoCommandBufferBuilder<P> {
None => panic!("Not enough clear values") None => panic!("Not enough clear values")
} }
} }
if clear_values_copy.count() != 0 { if clear_values_copy.count() != 0 {
panic!("Too many clear values") panic!("Too many clear values")
} }

2
vulkano/src/format.rs
View File

@ -186,7 +186,7 @@ macro_rules! formats {
impl Format { impl Format {
/*pub fn is_supported_for_vertex_attributes(&self) -> bool { /*pub fn is_supported_for_vertex_attributes(&self) -> bool {
} }
.. other functions .. .. other functions ..

14
vulkano/src/image/mod.rs
View File

@ -306,13 +306,13 @@ impl Dimensions {
#[inline] #[inline]
pub fn to_view_type(&self) -> ViewType { pub fn to_view_type(&self) -> ViewType {
match *self { match *self {
Dimensions::Dim1d { .. } => ViewType::Dim1d, Dimensions::Dim1d { .. } => ViewType::Dim1d,
Dimensions::Dim1dArray { .. } => ViewType::Dim1dArray, Dimensions::Dim1dArray { .. } => ViewType::Dim1dArray,
Dimensions::Dim2d { .. } => ViewType::Dim2d, Dimensions::Dim2d { .. } => ViewType::Dim2d,
Dimensions::Dim2dArray { .. } => ViewType::Dim2dArray, Dimensions::Dim2dArray { .. } => ViewType::Dim2dArray,
Dimensions::Dim3d { .. } => ViewType::Dim3d, Dimensions::Dim3d { .. } => ViewType::Dim3d,
Dimensions::Cubemap { .. } => ViewType::Cubemap, Dimensions::Cubemap { .. } => ViewType::Cubemap,
Dimensions::CubemapArray { .. } => ViewType::CubemapArray, Dimensions::CubemapArray { .. } => ViewType::CubemapArray,
} }
} }

2
vulkano/src/instance/limits.rs
View File

@ -26,7 +26,7 @@ macro_rules! limits_impl {
limits limits
} }
} }
$( $(
#[inline] #[inline]
pub fn $name(&self) -> $t { pub fn $name(&self) -> $t {

1
vulkano/src/pipeline/graphics_pipeline/tests.rs
View File

@ -342,4 +342,3 @@ const BASIC_FS: [u8; 420] = [3, 2, 35, 7, 0, 0, 1, 0, 1, 0, 8, 0, 13, 0, 0, 0, 0
5, 0, 2, 0, 0, 0, 4, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 248, 0, 2, 5, 0, 2, 0, 0, 0, 4, 0, 0, 0, 0, 0, 0, 0, 3, 0, 0, 0, 248, 0, 2,
0, 5, 0, 0, 0, 62, 0, 3, 0, 9, 0, 0, 0, 12, 0, 0, 0, 253, 0, 1, 0, 5, 0, 0, 0, 62, 0, 3, 0, 9, 0, 0, 0, 12, 0, 0, 0, 253, 0, 1,
0, 56, 0, 1, 0]; 0, 56, 0, 1, 0];

2
vulkano/src/swapchain/swapchain.rs
View File

@ -1020,7 +1020,7 @@ unsafe impl<P, W> GpuFuture for PresentFuture<P, W>
// submit the command buffer by flushing previous. // submit the command buffer by flushing previous.
// Since the implementation should remember being flushed it's safe to call build_submission multiple times // Since the implementation should remember being flushed it's safe to call build_submission multiple times
self.previous.flush()?; self.previous.flush()?;
let mut builder = SubmitPresentBuilder::new(); let mut builder = SubmitPresentBuilder::new();
builder.add_swapchain(&self.swapchain, builder.add_swapchain(&self.swapchain,
self.image_id as u32, self.image_id as u32,