mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-28 01:34:21 +00:00
796be88062
When suggesting a type on inference error, do not use `{closure@..}`.
Instead, replace with an appropriate `fn` ptr.
On the error message, use `short_ty_string` and write long types to
disk.
```
error[E0284]: type annotations needed for `Select<{closure@lib.rs:2782:13}, _, Expression<'_>, _>`
--> crates/lang/src/parser.rs:41:13
|
41 | let lit = select! {
| ^^^
42 | Token::Int(i) = e => Expression::new(Expr::Lit(ast::Lit::Int(i.parse().unwrap())), e.span()),
| ---- type must be known at this point
|
= note: the full type name has been written to '/home/gh-estebank/iowo/target/debug/deps/lang-e2d6e25819442273.long-type-4587393693885174369.txt'
= note: cannot satisfy `<_ as chumsky::input::Input<'_>>::Span == SimpleSpan`
help: consider giving `lit` an explicit type, where the type for type parameter `I` is specified
|
41 | let lit: Select<for<'a, 'b> fn(tokens::Token<'_>, &'a mut MapExtra<'_, 'b, _, _>) -> Option<Expression<'_>>, _, Expression<'_>, _> = select! {
| +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
```
instead of
```
error[E0284]: type annotations needed for `Select<{closure@/home/gh-estebank/.cargo/registry/src/index.crates.io-6f17d22bba15001f/chumsky-1.0.0-alpha.6/src/lib.rs:2782:13: 2782:28}, _, Expression<'_>, _>`
--> crates/lang/src/parser.rs:41:13
|
41 | let lit = select! {
| ^^^
42 | Token::Int(i) = e => Expression::new(Expr::Lit(ast::Lit::Int(i.parse().unwrap())), e.span()),
| ---- type must be known at this point
|
= note: cannot satisfy `<_ as chumsky::input::Input<'_>>::Span == SimpleSpan`
help: consider giving `lit` an explicit type, where the type for type parameter `I` is specified
|
41 | let lit: Select<{closure@/home/gh-estebank/.cargo/registry/src/index.crates.io-6f17d22bba15001f/chumsky-1.0.0-alpha.6/src/lib.rs:2782:13: 2782:28}, _, Expression<'_>, _> = select! {
| ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
```
Fix #123630.
|
||
|---|---|---|
| .. | ||
| array_const_index-0.rs | ||
| array_const_index-0.stderr | ||
| array_const_index-1.rs | ||
| array_const_index-1.stderr | ||
| array_const_index-2.rs | ||
| array-break-length.rs | ||
| array-break-length.stderr | ||
| array-not-vector.rs | ||
| array-not-vector.stderr | ||
| bounds-check-no-overflow.rs | ||
| box-of-array-of-drop-1.rs | ||
| box-of-array-of-drop-2.rs | ||
| byte-literals.rs | ||
| cast-in-array-size.rs | ||
| check-static-slice.rs | ||
| copy-out-of-array-1.rs | ||
| destructure-array-1.rs | ||
| dst-raw-slice.rs | ||
| empty-mutable-vec.rs | ||
| estr-slice.rs | ||
| evec-slice.rs | ||
| fixed_length_copy.rs | ||
| huge-largest-array.rs | ||
| infer_array_len.rs | ||
| issue-15730.rs | ||
| issue-18425.rs | ||
| issue-69103-extra-binding-subslice.rs | ||
| issue-69103-extra-binding-subslice.stderr | ||
| ivec-pass-by-value.rs | ||
| match_arr_unknown_len.rs | ||
| match_arr_unknown_len.stderr | ||
| mut-vstore-expr.rs | ||
| mutability-inherits-through-fixed-length-vec.rs | ||
| mutable-alias-vec.rs | ||
| nested-vec-1.rs | ||
| nested-vec-2.rs | ||
| nested-vec-3.rs | ||
| new-style-fixed-length-vec.rs | ||
| rcvr-borrowed-to-slice.rs | ||
| repeat_empty_ok.rs | ||
| repeat_empty_ok.stderr | ||
| repeated-vector-syntax.rs | ||
| show-boxed-slice.rs | ||
| slice_binary_search.rs | ||
| slice_is_sorted_by_borrow.rs | ||
| slice-2.rs | ||
| slice-2.stderr | ||
| slice-mut-2.rs | ||
| slice-mut-2.stderr | ||
| slice-mut.rs | ||
| slice-mut.stderr | ||
| slice-of-zero-size-elements.rs | ||
| slice-panic-1.rs | ||
| slice-panic-2.rs | ||
| slice-pat-type-mismatches.rs | ||
| slice-pat-type-mismatches.stderr | ||
| slice-to-vec-comparison.rs | ||
| slice-to-vec-comparison.stderr | ||
| slice.rs | ||
| subslice-only-once-semantic-restriction.rs | ||
| subslice-only-once-semantic-restriction.stderr | ||
| subslice-patterns-const-eval-match.rs | ||
| subslice-patterns-const-eval.rs | ||
| suggest-array-length.fixed | ||
| suggest-array-length.rs | ||
| suggest-array-length.stderr | ||
| variance-vec-covariant.rs | ||
| vec-dst.rs | ||
| vec-fixed-length.rs | ||
| vec-late-init.rs | ||
| vec-macro-no-std.rs | ||
| vec-macro-rvalue-scope.rs | ||
| vec-macro-with-brackets.rs | ||
| vec-macro-with-comma-only.rs | ||
| vec-macro-with-comma-only.stderr | ||
| vec-macro-with-trailing-comma.rs | ||
| vec-matching-autoslice.rs | ||
| vec-matching-fixed.rs | ||
| vec-matching-fold.rs | ||
| vec-matching-legal-tail-element-borrow.rs | ||
| vec-matching.rs | ||
| vec-mut-iter-borrow.rs | ||
| vec-mut-iter-borrow.stderr | ||
| vec-overrun.rs | ||
| vec-repeat-with-cast.rs | ||
| vec-res-add.rs | ||
| vec-res-add.stderr | ||
| vec-tail-matching.rs | ||
| vector-cast-weirdness.rs | ||
| vector-cast-weirdness.stderr | ||
| vector-no-ann-2.rs | ||
| vector-no-ann.rs | ||
| vector-no-ann.stderr | ||