Matthias Krüger 7fc2b33722 Rollup merge of #132708 - estebank:const-as-binding, r=Nadrieril ... Point at `const` definition when used instead of a binding in a `let` statement Modify `PatKind::InlineConstant` to be `ExpandedConstant` standing in not only for inline `const` blocks but also for `const` items. This allows us to track named `const`s used in patterns when the pattern is a single binding. When we detect that there is a refutable pattern involving a `const` that could have been a binding instead, we point at the `const` item, and suggest renaming. We do this for both `let` bindings and `match` expressions missing a catch-all arm if there's at least one single binding pattern referenced. After: ``` error[E0005]: refutable pattern in local binding --> $DIR/bad-pattern.rs:19:13 | LL | const PAT: u32 = 0; | -------------- missing patterns are not covered because `PAT` is interpreted as a constant pattern, not a new variable ... LL | let PAT = v1; | ^^^ pattern `1_u32..=u32::MAX` not covered | = note: `let` bindings require an "irrefutable pattern", like a `struct` or an `enum` with only one variant = note: for more information, visit https://doc.rust-lang.org/book/ch18-02-refutability.html = note: the matched value is of type `u32` help: introduce a variable instead | LL | let PAT_var = v1; | ~~~~~~~ ``` Before: ``` error[E0005]: refutable pattern in local binding --> $DIR/bad-pattern.rs:19:13 | LL | let PAT = v1; | ^^^ | | | pattern `1_u32..=u32::MAX` not covered | missing patterns are not covered because `PAT` is interpreted as a constant pattern, not a new variable | help: introduce a variable instead: `PAT_var` | = note: `let` bindings require an "irrefutable pattern", like a `struct` or an `enum` with only one variant = note: for more information, visit https://doc.rust-lang.org/book/ch18-02-refutability.html = note: the matched value is of type `u32` ``` CC #132582.		2024-11-20 20:10:12 +01:00
..
auxiliary	Move existing rfc3627 tests to a dedicated folder	2024-09-24 13:45:58 +02:00
bindings-after-at	Peel off explicit (or implicit) deref before suggesting clone on move error in borrowck	2024-07-26 14:41:56 -04:00
deref-patterns	Test or-patterns inside deref patterns	2024-04-20 16:04:06 +02:00
move-ref-patterns	Better span for "make binding mutable" suggestion	2024-07-04 02:02:21 +00:00
rfc-3627-match-ergonomics-2024	Change error message	2024-10-08 00:23:28 +02:00
usefulness	Rollup merge of #132708 - estebank:const-as-binding, r=Nadrieril	2024-11-20 20:10:12 +01:00
at-in-struct-patterns.rs	Parser: better error messages for @ in struct patterns	2024-09-23 02:12:53 +03:00
at-in-struct-patterns.stderr	Parser: better error messages for @ in struct patterns	2024-09-23 02:12:53 +03:00
box-pattern-type-mismatch.rs	Replace some Option<Diag> with Result<(), Diag>	2024-06-13 06:16:12 +00:00
box-pattern-type-mismatch.stderr	Replace some Option<Diag> with Result<(), Diag>	2024-06-13 06:16:12 +00:00
by-move-pattern-binding.rs	Move 100 entries from tests/ui into subdirs	2024-05-20 19:55:59 -07:00
by-move-pattern-binding.stderr	Move 100 entries from tests/ui into subdirs	2024-05-20 19:55:59 -07:00
byte-string-inference.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
complexity_limit.rs	Add and update tests to use pattern_complexity	2024-03-03 13:10:15 +01:00
complexity_limit.stderr	Add and update tests to use pattern_complexity	2024-03-03 13:10:15 +01:00
fn-in-pat.rs	Move 100 entries from tests/ui into subdirs	2024-05-20 19:55:59 -07:00
fn-in-pat.stderr	Move 100 entries from tests/ui into subdirs	2024-05-20 19:55:59 -07:00
for-loop-bad-item.rs
for-loop-bad-item.stderr
ignore-all-the-things.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
inc-range-pat.rs	Move 100 entries from tests/ui into subdirs	2024-05-20 19:55:59 -07:00
incorrect-placement-of-pattern-modifiers.fixed	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
incorrect-placement-of-pattern-modifiers.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
incorrect-placement-of-pattern-modifiers.stderr	Account for ref and mut in the wrong place for pattern ident renaming	2023-10-30 00:15:49 +00:00
integer-range-binding.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
issue-6449.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
issue-8351-1.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
issue-8351-2.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
issue-10392.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
issue-11577.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
issue-12582.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
issue-14221.rs
issue-14221.stderr	Reword the "unreachable pattern" explanations	2024-08-19 21:39:57 +02:00
issue-15080.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
issue-17718-patterns.rs
issue-17718-patterns.stderr
issue-22546.rs	Revert "Rollup merge of #126618 - mu001999-contrib:dead/enhance, r=pnkfelix"	2024-08-03 07:57:31 -04:00
issue-22546.stderr	Revert "Rollup merge of #126618 - mu001999-contrib:dead/enhance, r=pnkfelix"	2024-08-03 07:57:31 -04:00
issue-27320.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
issue-28992-empty.rs	Move some tests	2024-02-09 15:43:08 -03:00
issue-28992-empty.stderr	Move some tests	2024-02-09 15:43:08 -03:00
issue-52240.rs
issue-52240.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
issue-66270-pat-struct-parser-recovery.rs
issue-66270-pat-struct-parser-recovery.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
issue-67037-pat-tup-scrut-ty-diff-less-fields.rs
issue-67037-pat-tup-scrut-ty-diff-less-fields.stderr
issue-67776-match-same-name-enum-variant-refs.rs
issue-67776-match-same-name-enum-variant-refs.stderr
issue-72565.rs	Avoid emitting the non_exhaustive error if other errors already occurred	2023-10-11 12:49:57 +00:00
issue-72565.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
issue-72574-1.rs
issue-72574-1.stderr
issue-72574-2.rs
issue-72574-2.stderr
issue-74539.rs
issue-74539.stderr
issue-74702.rs
issue-74702.stderr
issue-74954.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
issue-80186-mut-binding-help-suggestion.rs
issue-80186-mut-binding-help-suggestion.stderr	Make parse error suggestions verbose and fix spans	2024-07-12 03:02:57 +00:00
issue-88074-pat-range-type-inference-err.rs
issue-88074-pat-range-type-inference-err.stderr
issue-88074-pat-range-type-inference.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
issue-92074-macro-ice.rs
issue-92074-macro-ice.stderr	Change wording	2024-04-29 14:53:38 +02:00
issue-94866.rs
issue-94866.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
issue-95878.rs
issue-95878.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
issue-106552.rs
issue-106552.stderr
issue-106862.fixed	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
issue-106862.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
issue-106862.stderr
issue-110508.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
issue-115599.rs	remove StructuralEq trait	2024-01-24 07:56:23 +01:00
issue-115599.stderr	remove StructuralEq trait	2024-01-24 07:56:23 +01:00
issue-117626.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
missing_lifetime.rs	Avoid follow-up errors on erroneous patterns	2024-06-13 06:14:32 +00:00
missing_lifetime.stderr	Avoid follow-up errors on erroneous patterns	2024-06-13 06:14:32 +00:00
mut_preserve_binding_mode_2021.rs	Gate implicit mutable by-reference bindings behind mut ref	2024-05-15 16:55:54 -04:00
mut_preserve_binding_mode_2021.stderr	Fix tests	2024-04-15 23:27:22 -04:00
mut_preserve_binding_mode_2024.rs	Gate implicit mutable by-reference bindings behind mut ref	2024-05-15 16:55:54 -04:00
mut-ref-mut-2021.rs	Feature gate	2024-03-27 11:20:28 -04:00
mut-ref-mut-2021.stderr	Better span for "make binding mutable" suggestion	2024-07-04 02:02:21 +00:00
no_ref_mut_behind_and.rs	"No ref mut behind &" on all editions	2024-05-15 17:20:18 -04:00
no-match-tuple-variant-self-ctor.rs	Validate that we're only matching on unit struct for path pattern	2024-03-22 20:53:42 -04:00
no-match-tuple-variant-self-ctor.struct_.stderr	Validate that we're only matching on unit struct for path pattern	2024-03-22 20:53:42 -04:00
no-match-tuple-variant-self-ctor.tuple.stderr	Validate that we're only matching on unit struct for path pattern	2024-03-22 20:53:42 -04:00
no-patterns-in-args-2.rs	Move 100 entries from tests/ui into subdirs	2024-05-20 19:55:59 -07:00
no-patterns-in-args-2.stderr	Move 100 entries from tests/ui into subdirs	2024-05-20 19:55:59 -07:00
no-patterns-in-args.rs	Move 100 entries from tests/ui into subdirs	2024-05-20 19:55:59 -07:00
no-patterns-in-args.stderr	Move 100 entries from tests/ui into subdirs	2024-05-20 19:55:59 -07:00
non-constant-in-const-path.rs
non-constant-in-const-path.stderr
non-structural-match-types.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
non-structural-match-types.stderr	Tighten spans for async blocks	2024-06-27 15:19:08 -04:00
pat-shadow-in-nested-binding.rs
pat-shadow-in-nested-binding.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
pat-struct-field-expr-has-type.rs
pat-struct-field-expr-has-type.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
pat-tuple-bad-type.rs
pat-tuple-bad-type.stderr
pat-tuple-field-count-cross.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
pat-tuple-field-count-cross.stderr
pat-tuple-overfield.rs
pat-tuple-overfield.stderr
pat-tuple-underfield.rs
pat-tuple-underfield.stderr
pat-type-err-formal-param.rs
pat-type-err-formal-param.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
pat-type-err-let-stmt.rs
pat-type-err-let-stmt.stderr
patkind-litrange-no-expr.rs
patkind-litrange-no-expr.stderr	Add a note to duplicate diagnostics	2023-10-05 01:04:41 +00:00
patkind-ref-binding-issue-114896.fixed	Fix incorrect mutable suggestion information for binding in ref pattern.	2024-03-19 12:28:23 +08:00
patkind-ref-binding-issue-114896.rs	Fix incorrect mutable suggestion information for binding in ref pattern.	2024-03-19 12:28:23 +08:00
patkind-ref-binding-issue-114896.stderr	More accurate mutability suggestion	2024-07-04 05:36:34 +00:00
patkind-ref-binding-issue-122415.fixed	Fix incorrect mutable suggestion information for binding in ref pattern.	2024-03-19 12:28:23 +08:00
patkind-ref-binding-issue-122415.rs	Fix incorrect mutable suggestion information for binding in ref pattern.	2024-03-19 12:28:23 +08:00
patkind-ref-binding-issue-122415.stderr	More accurate mutability suggestion	2024-07-04 05:36:34 +00:00
pattern-bad-ref-box-order.fixed	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
pattern-bad-ref-box-order.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
pattern-bad-ref-box-order.stderr	Make parse error suggestions verbose and fix spans	2024-07-12 03:02:57 +00:00
pattern-binding-disambiguation.rs	Continue to borrowck even if there were previous errors	2024-02-08 08:10:43 +00:00
pattern-binding-disambiguation.stderr	Continue to borrowck even if there were previous errors	2024-02-08 08:10:43 +00:00
pattern-error-continue.rs
pattern-error-continue.stderr
pattern-ident-path-generics.rs
pattern-ident-path-generics.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
pattern-tyvar-2.rs
pattern-tyvar-2.stderr	Change E0369 diagnostic give note information for foreign items.	2024-06-25 10:00:30 +08:00
pattern-tyvar.rs
pattern-tyvar.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
patterns-dont-match-nt-statement.rs	Don't make pattern nonterminals match statement nonterminals	2024-08-26 18:30:15 -04:00
range-pattern-meant-to-be-slice-rest-pattern.rs	Stabilize exclusive_range	2024-05-02 19:42:31 -04:00
range-pattern-meant-to-be-slice-rest-pattern.stderr	Make parse error suggestions verbose and fix spans	2024-07-12 03:02:57 +00:00
rest-pat-semantic-disallowed.rs
rest-pat-semantic-disallowed.stderr
rest-pat-syntactic.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
rest-pat-syntactic.stderr	Bless tests	2024-01-13 12:46:58 -05:00
size-and-align.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
skipped-ref-pats-issue-125058.rs	rustc_hir_typeck: Account for skipped_ref_pats in expr_use_visitor	2024-05-13 18:36:49 -04:00
skipped-ref-pats-issue-125058.stderr	rustc_hir_typeck: Account for skipped_ref_pats in expr_use_visitor	2024-05-13 18:36:49 -04:00
slice-array-infer.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
slice-pattern-refutable.rs	address review	2023-07-17 22:06:32 +00:00
slice-pattern-refutable.stderr	address review	2023-07-17 22:06:32 +00:00
slice-patterns-ambiguity.rs	add tests for refutable patterns	2023-07-17 22:02:09 +00:00
slice-patterns-ambiguity.stderr	add tests for refutable patterns	2023-07-17 22:02:09 +00:00
slice-patterns-irrefutable.rs	address review	2023-07-28 11:20:11 +00:00
slice-patterns-irrefutable.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
slice-patterns-nested.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
struct-parser-recovery-issue-126344.rs	report pat no field error no recoverd struct variant	2024-07-11 00:18:47 +08:00
struct-parser-recovery-issue-126344.stderr	report pat no field error no recoverd struct variant	2024-07-11 00:18:47 +08:00
suggest-adding-appropriate-missing-pattern-excluding-comments.fixed	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
suggest-adding-appropriate-missing-pattern-excluding-comments.rs	[AUTO-GENERATED] Migrate ui tests from // to //@ directives	2024-02-16 20:02:50 +00:00
suggest-adding-appropriate-missing-pattern-excluding-comments.stderr	Show number in error message even for one error	2023-11-24 19:15:52 +01:00
type_mismatch.rs	Avoid follow-up errors on erroneous patterns	2024-06-13 06:14:32 +00:00
type_mismatch.stderr	Avoid follow-up errors on erroneous patterns	2024-06-13 06:14:32 +00:00