mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-23 15:23:46 +00:00
6181f3a566
The goal of this commit is to remove warnings using LLVM tip-of-tree `wasm-ld`. In llvm/llvm-project#78658 the `wasm-ld` LLD driver no longer looks at archive indices and instead looks at all the objects in archives. Previously `lib.rmeta` files were simply raw rustc metadata bytes, not wasm objects, meaning that `wasm-ld` would emit a warning indicating so. WebAssembly targets previously passed `--fatal-warnings` to `wasm-ld` by default which meant that if Rust were to update to LLVM 18 then all wasm targets would not work. This immediate blocker was resolved in rust-lang/rust#120278 which removed `--fatal-warnings` which enabled a theoretical update to LLVM 18 for wasm targets. This current state is ok-enough for now because rustc squashes all linker output by default if it doesn't fail. This means, for example, that rustc squashes all the linker warnings coming out of `wasm-ld` about `lib.rmeta` files with LLVM 18. This again isn't a pressing issue because the information is all hidden, but it runs the risk of being annoying if another linker error were to happen and then the output would have all these unrelated warnings that couldn't be fixed. Thus, this PR comes into the picture. The goal of this PR is to resolve these warnings by using the WebAssembly object file format on wasm targets instead of using raw rustc metadata. When I first implemented the rlib-in-objects scheme in #84449 I remember either concluding that `wasm-ld` would either include the metadata in the output or I thought we didn't have to do anything there at all. I think I was wrong on both counts as `wasm-ld` does not include the metadata in the final output unless the object is referenced and we do actually need to do something to resolve these warnings. This PR updates the object file format containing rustc metadata on WebAssembly targets to be an actual WebAssembly file. This enables the `wasm` feature of the `object` crate to be able to read the custom section in the same manner as other platforms, but currently `object` doesn't support writing wasm object files so a handwritten encoder is used instead. The only caveat I know of with this is that if `wasm-ld` does indeed look at the object file then the metadata will be included in the final output. I believe the only thing that could cause that at this time is `--whole-archive` which I don't think is passed for rlibs. I would clarify that I'm not 100% certain about this, however.
56 lines
1.7 KiB
TOML
56 lines
1.7 KiB
TOML
[package]
|
|
name = "rustc_codegen_ssa"
|
|
version = "0.0.0"
|
|
edition = "2021"
|
|
|
|
[dependencies]
|
|
# tidy-alphabetical-start
|
|
ar_archive_writer = "0.1.5"
|
|
bitflags = "2.4.1"
|
|
cc = "1.0.69"
|
|
itertools = "0.11"
|
|
jobserver = "0.1.28"
|
|
pathdiff = "0.2.0"
|
|
regex = "1.4"
|
|
rustc_arena = { path = "../rustc_arena" }
|
|
rustc_ast = { path = "../rustc_ast" }
|
|
rustc_attr = { path = "../rustc_attr" }
|
|
rustc_data_structures = { path = "../rustc_data_structures" }
|
|
rustc_errors = { path = "../rustc_errors" }
|
|
rustc_fluent_macro = { path = "../rustc_fluent_macro" }
|
|
rustc_fs_util = { path = "../rustc_fs_util" }
|
|
rustc_hir = { path = "../rustc_hir" }
|
|
rustc_incremental = { path = "../rustc_incremental" }
|
|
rustc_index = { path = "../rustc_index" }
|
|
rustc_macros = { path = "../rustc_macros" }
|
|
rustc_metadata = { path = "../rustc_metadata" }
|
|
rustc_middle = { path = "../rustc_middle" }
|
|
rustc_query_system = { path = "../rustc_query_system" }
|
|
rustc_serialize = { path = "../rustc_serialize" }
|
|
rustc_session = { path = "../rustc_session" }
|
|
rustc_span = { path = "../rustc_span" }
|
|
rustc_symbol_mangling = { path = "../rustc_symbol_mangling" }
|
|
rustc_target = { path = "../rustc_target" }
|
|
rustc_type_ir = { path = "../rustc_type_ir" }
|
|
serde_json = "1.0.59"
|
|
smallvec = { version = "1.8.1", features = ["union", "may_dangle"] }
|
|
tempfile = "3.2"
|
|
thin-vec = "0.2.12"
|
|
thorin-dwp = "0.7"
|
|
tracing = "0.1"
|
|
# tidy-alphabetical-end
|
|
|
|
[target.'cfg(unix)'.dependencies]
|
|
# tidy-alphabetical-start
|
|
libc = "0.2.50"
|
|
# tidy-alphabetical-end
|
|
|
|
[dependencies.object]
|
|
version = "0.32.1"
|
|
default-features = false
|
|
features = ["read_core", "elf", "macho", "pe", "xcoff", "unaligned", "archive", "write", "wasm"]
|
|
|
|
[target.'cfg(windows)'.dependencies.windows]
|
|
version = "0.52.0"
|
|
features = ["Win32_Globalization"]
|