rust/compiler/rustc_hir_analysis/src
bors f5355b93ba Auto merge of #124356 - fmease:fewer-magic-numbers-in-names, r=lcnr
Cleanup: Replace item names referencing GitHub issues or error codes with something more meaningful

**lcnr** in https://github.com/rust-lang/rust/pull/117164#pullrequestreview-1969935387:

> […] while I know that there's precendent to name things `Issue69420`, I really dislike this as it requires looking up the issue to figure out the purpose of such a variant. Actually referring to the underlying issue, e.g. `AliasMayNormToUncovered` or whatever and then linking to the issue in a doc comment feels a lot more desirable to me. We should ideally rename all the functions and enums which currently use issue numbers.

I've grepped through `compiler/` like crazy and think that I've found all instances of this pattern.
However, I haven't renamed `compute_2229_migrations_*`. Should I?

The first commit introduces an abhorrent and super long name for an item because naming is hard but also scary looking / unwelcoming names are good for things related to temporary-ish backcompat hacks. I'll let you discover it by yourself.

Contains a bit of drive-by cleanup and a diag migration bc that was the simplest option.

r? lcnr or compiler
2024-05-01 00:04:36 +00:00
..
check Replace item names containing an error code with something more meaningful 2024-04-30 22:27:19 +02:00
coherence Normalize trait ref before orphan check & consider ty params in alias types to be uncovered 2024-04-30 21:54:54 +02:00
collect also remap RPITITs nested in other types back to their opaques 2024-04-21 18:04:50 +02:00
errors Explicitly mention Self 2024-04-20 11:39:43 -04:00
hir_ty_lowering delegation: Support async, const, extern "ABI" and C-variadic functions 2024-04-23 23:05:39 +03:00
impl_wf_check Use expand_weak_alias_tys when collecting constrained generics params in impls 2024-02-20 17:31:59 +01:00
outlives Use FxIndexMap instead of BTreeMap to avoid sorting DefIds 2024-03-27 14:02:15 +00:00
structured_errors Suggest _ for missing generic arguments in turbofish 2024-03-17 17:34:17 +00:00
variance Don't leak unnameable types in -> _ recover 2024-04-14 11:43:05 -04:00
autoderef.rs fix ICE for deref coercions with type errors 2024-02-12 14:37:35 +01:00
bounds.rs remove push_trait_bound_inner 2024-04-23 17:54:58 +08:00
check_unused.rs Rename TyCtxt::struct_span_lint_hir as TyCtxt::node_span_lint. 2024-01-23 08:09:01 +11:00
collect.rs Fix ICE on invalid const param types 2024-04-27 09:36:38 +05:30
constrained_generic_params.rs Convert TypeVisitor and DefIdVisitor to use VisitorResult 2024-03-05 13:28:15 -05:00
errors.rs Auto merge of #124356 - fmease:fewer-magic-numbers-in-names, r=lcnr 2024-05-01 00:04:36 +00:00
hir_wf_check.rs Auto merge of #122869 - matthiaskrgr:rollup-0navj4l, r=matthiaskrgr 2024-03-22 12:29:42 +00:00
impl_wf_check.rs Merge check_mod_impl_wf and check_mod_type_wf 2024-03-07 06:27:09 +00:00
lib.rs Stabilize generic NonZero. 2024-04-22 18:48:47 +02:00
structured_errors.rs Rename StructuredDiagnostic as StructuredDiag. 2024-03-05 12:15:12 +11:00