mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-02 04:57:35 +00:00
f3faaf524c
Clarify the match ergonomics 2024 migration lint's output This makes a few changes: - Rather than using the whole pattern as a span for the lint, this collects spans for each problematic default binding mode reset and labels them with why they're problems. - The lint's suggestions are now verbose-styled, so that it's clear what's being suggested vs. what's problematic. - The wording is now less technical, and the hard error version of this diagnostic now links to the same reference material as the lint (currently an unwritten page of the edition guide). I'm not totally confident in the wording or formatting, so I'd appreciate feedback on that in particular. I tried to draw a connection with word choice between the labels and the suggestion, but it might be imprecise, unclear, or cluttered. If so, it might be worth making the labels more terse and adding notes that explain them, but that's harder to read in a way too. cc ```@Nadrieril``` ```@Jules-Bertholet``` Closes #133854. For reference, the error from that issue becomes: ``` error: pattern uses features incompatible with edition 2024 --> $DIR/remove-me.rs:6:25 | LL | map.iter().filter(|(&(_x, _y), &_c)| false); | ^ ^ cannot implicitly match against multiple layers of reference | | | cannot implicitly match against multiple layers of reference | help: make the implied reference pattern explicit | LL | map.iter().filter(|&(&(_x, _y), &_c)| false); | + ``` |
||
|---|---|---|
| .. | ||
| dep_graph | ||
| hir | ||
| hooks | ||
| infer | ||
| middle | ||
| mir | ||
| query | ||
| thir | ||
| traits | ||
| ty | ||
| util | ||
| arena.rs | ||
| error.rs | ||
| lib.rs | ||
| lint.rs | ||
| macros.rs | ||
| metadata.rs | ||
| tests.rs | ||
| thir.rs | ||
| values.rs | ||