rust/compiler/rustc_codegen_ssa/src
Matthias Krüger e9e2ebb051
Rollup merge of #124414 - lqd:subdiagnostics, r=davidtwco
remove extraneous note on `UnableToRunDsymutil` diagnostic

If I understand [this FIXME](1367827eac/compiler/rustc_macros/src/diagnostics/diagnostic.rs (L205)) correctly, it seems we don't yet validate subdiagnostics, so `#[note]` and co in the `#[derive(Diagnostic]` item could be out-of-sync with the fluent message, without causing compile errors.

It was the case for `rustc_codegen_ssa::errors::UnableToRunDsymutil`, causing the ICE in #124392.

I've grepped and scripted my way through most of our diagnostics structs and fluent bundles and the above was the only such extraneous `#[note]`/`#[note(name)]`/`#[help]`/`#[warning]` I could find, so hopefully there aren't many others like it.

I haven't checked if the opposite can happen, a `.note = ` in a fluent message that is lacking a corresponding `#[note]` on the struct and not causing an error, but maybe it's possible?

r? ``@davidtwco``
fixes #124392
2024-05-02 19:42:48 +02:00
..
back Remove extern crate rustc_middle from numerous crates. 2024-04-29 14:50:45 +10:00
debuginfo Remove extern crate rustc_middle from numerous crates. 2024-04-29 14:50:45 +10:00
mir Remove extern crate rustc_middle from numerous crates. 2024-04-29 14:50:45 +10:00
traits Remove extern crate rustc_middle from numerous crates. 2024-04-29 14:50:45 +10:00
assert_module_sources.rs Rename IntoDiagnosticArg as IntoDiagArg. 2024-03-11 09:12:19 +11:00
base.rs Remove extern crate rustc_middle from numerous crates. 2024-04-29 14:50:45 +10:00
codegen_attrs.rs Rename NestedMetaItem::name_value_literal. 2024-04-24 16:28:34 +10:00
common.rs Remove extern crate rustc_middle from numerous crates. 2024-04-29 14:50:45 +10:00
errors.rs remove extraneous note on UnableToRunDsymutil diagnostic 2024-04-26 17:24:06 +00:00
lib.rs Step bootstrap cfgs 2024-05-01 22:19:11 -04:00
meth.rs Remove extern crate rustc_middle from numerous crates. 2024-04-29 14:50:45 +10:00
mono_item.rs Remove extern crate rustc_middle from numerous crates. 2024-04-29 14:50:45 +10:00
size_of_val.rs Remove extern crate rustc_middle from numerous crates. 2024-04-29 14:50:45 +10:00
target_features.rs Remove extern crate rustc_middle from numerous crates. 2024-04-29 14:50:45 +10:00