mirror of
https://github.com/rust-lang/rust.git
synced 2025-06-21 12:07:31 +00:00
2e19658315
In PR 90877 T-lang decided not to remove `intrinsics::pref_align_of`.
However, the intrinsic and its supporting code
1. is a nightly feature, so can be removed at compiler/libs discretion
2. requires considerable effort in the compiler to support, as it
necessarily complicates every single site reasoning about alignment
3. has been justified based on relevance to codegen, but it is only a
requirement for C++ (not C, not Rust) stack frame layout for AIX,
in ways Rust would not consider even with increased C++ interop
4. is only used by rustc to overalign some globals, not correctness
5. can be adequately replaced by other rules for globals, as it mostly
affects alignments for a few types under 16 bytes of alignment
6. has only one clear benefactor: automating C -> Rust translation
for GNU extensions like `__alignof`
7. such code was likely intended to be `alignof` or `_Alignof`,
because the GNU extension is a "false friend" of the C keyword,
which makes the choice to support such a mapping very questionable
8. makes it easy to do incorrect codegen in the compiler by its mere
presence as usual Rust rules of alignment (e.g. `size == align * N`)
do not hold with preferred alignment
The implementation is clearly damaging the code quality of the compiler.
Thus it is within the compiler team's purview to simply rip it out.
If T-lang wishes to have this intrinsic restored for c2rust's benefit,
it would have to use a radically different implementation that somehow
does not cause internal incorrectness.
Until then, remove the intrinsic and its supporting code, as one tool
and an ill-considered GCC extension cannot justify risking correctness.
Because we touch a fair amount of the compiler to change this at all,
and unfortunately the duplication of AbiAndPrefAlign is deep-rooted,
we keep an "AbiAlign" type which we can wean code off later.
|
||
|---|---|---|
| .. | ||
| abi | ||
| debuginfo | ||
| driver | ||
| intrinsics | ||
| optimize | ||
| allocator.rs | ||
| analyze.rs | ||
| base.rs | ||
| cast.rs | ||
| codegen_f16_f128.rs | ||
| codegen_i128.rs | ||
| common.rs | ||
| compiler_builtins.rs | ||
| concurrency_limiter.rs | ||
| config.rs | ||
| constant.rs | ||
| discriminant.rs | ||
| global_asm.rs | ||
| inline_asm.rs | ||
| lib.rs | ||
| linkage.rs | ||
| main_shim.rs | ||
| num.rs | ||
| pointer.rs | ||
| pretty_clif.rs | ||
| toolchain.rs | ||
| unsize.rs | ||
| unwind_module.rs | ||
| value_and_place.rs | ||
| vtable.rs | ||