mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-14 02:49:40 +00:00
d71f535a6f
`Diagnostic::code` has the type `DiagnosticId`, which has `Error` and `Lint` variants. Plus `Diagnostic::is_lint` is a bool, which should be redundant w.r.t. `Diagnostic::code`. Seems simple. Except it's possible for a lint to have an error code, in which case its `code` field is recorded as `Error`, and `is_lint` is required to indicate that it's a lint. This is what happens with `derive(LintDiagnostic)` lints. Which means those lints don't have a lint name or a `has_future_breakage` field because those are stored in the `DiagnosticId::Lint`. It's all a bit messy and confused and seems unintentional. This commit: - removes `DiagnosticId`; - changes `Diagnostic::code` to `Option<String>`, which means both errors and lints can straightforwardly have an error code; - changes `Diagnostic::is_lint` to `Option<IsLint>`, where `IsLint` is a new type containing a lint name and a `has_future_breakage` bool, so all lints can have those, error code or not. |
||
|---|---|---|
| .. | ||
| diagnostics | ||
| symbols | ||
| current_version.rs | ||
| hash_stable.rs | ||
| lib.rs | ||
| lift.rs | ||
| query.rs | ||
| serialize.rs | ||
| symbols.rs | ||
| type_foldable.rs | ||
| type_visitable.rs | ||