rust/tests/ui/needless_bool.rs

// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.


#![feature(tool_lints)]

#![warn(clippy::needless_bool)]

#[allow(clippy::if_same_then_else)]
fn main() {
    let x = true;
    let y = false;
    if x { true } else { true };
    if x { false } else { false };
    if x { true } else { false };
    if x { false } else { true };
    if x && y { false } else { true };
    if x { x } else { false }; // would also be questionable, but we don't catch this yet
    bool_ret(x);
    bool_ret2(x);
    bool_ret3(x);
    bool_ret5(x, x);
    bool_ret4(x);
    bool_ret6(x, x);
}

#[allow(clippy::if_same_then_else, clippy::needless_return)]
fn bool_ret(x: bool) -> bool {
    if x { return true } else { return true };
}

#[allow(clippy::if_same_then_else, clippy::needless_return)]
fn bool_ret2(x: bool) -> bool {
    if x { return false } else { return false };
}

#[allow(clippy::needless_return)]
fn bool_ret3(x: bool) -> bool {
    if x { return true } else { return false };
}

#[allow(clippy::needless_return)]
fn bool_ret5(x: bool, y: bool) -> bool {
    if x && y { return true } else { return false };
}

#[allow(clippy::needless_return)]
fn bool_ret4(x: bool) -> bool {
    if x { return false } else { return true };
}

#[allow(clippy::needless_return)]
fn bool_ret6(x: bool, y: bool) -> bool {
    if x && y { return false } else { return true };
}