rust/compiler
bors be69926a73 Auto merge of #119074 - leohowell:new-aarch64-apple-watchos-target, r=wesleywiser
Add new tier 3 aarch64-apple-watchos target

Apple Xcode 14/15 releases add a new apple watchos target architecture arm64 out of arm64_32 and armv7k, now add a new tier 3 target support for this target.

### Tier 3 Target Requirements
Adds support for Apple WatchOS aarch64-apple-watchos target.

Below are details on how this target meets the requirements for tier 3:

> tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)

`@leohowell`  has volunteered to be the target maintainer. I am also happy to help if a second maintainer is required.

> Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.

Uses the same naming as the LLVM target, and the same convention as other Apple targets.

> Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it.

I don't believe there is any ambiguity here.

> Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users.

I don't see any legal issues here.

> The target must not introduce license incompatibilities.
> Anything added to the Rust repository must be under the standard Rust license (MIT OR Apache-2.0).
> The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the tidy tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to be subject to any new license requirements.
> If the target supports building host tools (such as rustc or cargo), those host tools must not depend on proprietary (non-FOSS) libraries, other than ordinary runtime libraries supplied by the platform and commonly used by other binaries built for the target. For instance, rustc built for the target may depend on a common proprietary C runtime library or console output library, but must not depend on a proprietary code generation library or code optimization library. Rust's license permits such combinations, but the Rust project has no interest in maintaining such combinations within the scope of Rust itself, even at tier 3.
> Targets should not require proprietary (non-FOSS) components to link a functional binary or library.
> "onerous" here is an intentionally subjective term. At a minimum, "onerous" legal/licensing terms include but are not limited to: non-disclosure requirements, non-compete requirements, contributor license agreements (CLAs) or equivalent, "non-commercial"/"research-only"/etc terms, requirements conditional on the employer or employment of any particular Rust developers, revocable terms, any requirements that create liability for the Rust project or its developers or users, or any requirements that adversely affect the livelihood or prospects of the Rust project or its developers or users.

I see no issues with any of the above.

> Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.
> This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements.

Only relevant to those making approval decisions.

> Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.

core and alloc can be used. std support will be added in a subsequent PR.

> The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running tests (even if they do not pass), the documentation must explain how to run tests for the target, using emulation if possible or dedicated hardware if necessary.

Use --target= option to cross compile, just like any target. Tests can be run using the WatchOS simulator (see https://developer.apple.com/documentation/xcode/running-your-app-in-the-simulator-or-on-a-device).

> Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via `@)` to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.
> Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications.

I don't foresee this being a problem.

> Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.
> In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target.

No other targets should be affected by the pull request.

r? compiler-team
2023-12-19 06:47:58 +00:00
..
rustc
rustc_abi Annotate panic! reasons during enum layout 2023-12-15 02:21:31 -08:00
rustc_arena rustc_arena: add alloc_str 2023-12-05 17:52:51 -08:00
rustc_ast Rollup merge of #118880 - GearsDatapacks:issue-118859-fix, r=compiler-errors 2023-12-17 21:29:59 +01:00
rustc_ast_lowering Auto merge of #119061 - compiler-errors:async-gen-abi, r=wesleywiser 2023-12-19 00:42:50 +00:00
rustc_ast_passes Auto merge of #117818 - fmease:properly-reject-defaultness-on-free-consts, r=cjgillot 2023-12-18 11:59:34 +00:00
rustc_ast_pretty Add better ICE messages for some undescriptive panics 2023-12-15 00:50:55 -05:00
rustc_attr Rename many DiagCtxt arguments. 2023-12-18 16:06:22 +11:00
rustc_baked_icu_data Bump cfg(bootstrap)s 2023-11-15 19:41:28 -05:00
rustc_borrowck Rename many DiagCtxt arguments. 2023-12-18 16:06:22 +11:00
rustc_builtin_macros Rename many DiagCtxt and EarlyDiagCtxt locals. 2023-12-18 16:06:22 +11:00
rustc_codegen_cranelift Rename many DiagCtxt and EarlyDiagCtxt locals. 2023-12-18 16:06:22 +11:00
rustc_codegen_gcc Rename many DiagCtxt arguments. 2023-12-18 16:06:22 +11:00
rustc_codegen_llvm Auto merge of #119069 - matthiaskrgr:rollup-xxk4m30, r=matthiaskrgr 2023-12-18 08:03:22 +00:00
rustc_codegen_ssa Auto merge of #119069 - matthiaskrgr:rollup-xxk4m30, r=matthiaskrgr 2023-12-18 08:03:22 +00:00
rustc_const_eval Rename many DiagCtxt and EarlyDiagCtxt locals. 2023-12-18 16:06:22 +11:00
rustc_data_structures NFC don't convert types to identical types 2023-12-15 23:56:24 +01:00
rustc_driver Bump cfg(bootstrap)s 2023-11-15 19:41:28 -05:00
rustc_driver_impl Rename many DiagCtxt and EarlyDiagCtxt locals. 2023-12-18 16:06:22 +11:00
rustc_error_codes Remove edition umbrella features. 2023-12-10 13:03:28 -08:00
rustc_error_messages Remove rustc_error_messages/messages.ftl. 2023-11-26 08:37:27 +11:00
rustc_errors Rename many DiagCtxt and EarlyDiagCtxt locals. 2023-12-18 16:06:22 +11:00
rustc_expand Rename many DiagCtxt and EarlyDiagCtxt locals. 2023-12-18 16:06:22 +11:00
rustc_feature Remove edition umbrella features. 2023-12-10 13:03:28 -08:00
rustc_fluent_macro Add a useful comment. 2023-11-26 08:38:02 +11:00
rustc_fs_util
rustc_graphviz remove unused pub fn 2023-11-23 14:11:02 +03:00
rustc_hir Rollup merge of #119004 - matthiaskrgr:conv, r=compiler-errors 2023-12-15 21:33:00 -08:00
rustc_hir_analysis Auto merge of #119047 - mu001999:fix/118772, r=wesleywiser 2023-12-19 02:41:58 +00:00
rustc_hir_pretty Rollup merge of #118396 - compiler-errors:ast-lang-items, r=cjgillot 2023-12-15 14:08:15 -08:00
rustc_hir_typeck Auto merge of #119047 - mu001999:fix/118772, r=wesleywiser 2023-12-19 02:41:58 +00:00
rustc_incremental Move some methods from tcx.hir() to tcx 2023-12-12 06:40:29 -08:00
rustc_index Replace no_ord_impl with orderable. 2023-11-22 18:38:17 +11:00
rustc_index_macros Put backticks around some attributes in doc comments. 2023-11-27 09:37:01 +11:00
rustc_infer Rename Session::span_diagnostic as Session::dcx. 2023-12-18 16:06:21 +11:00
rustc_interface Rename many DiagCtxt and EarlyDiagCtxt locals. 2023-12-18 16:06:22 +11:00
rustc_lexer Rename some unescaping functions. 2023-12-13 14:17:50 +11:00
rustc_lint Rename Session::span_diagnostic as Session::dcx. 2023-12-18 16:06:21 +11:00
rustc_lint_defs Remove the lint outright 2023-12-16 01:28:06 +00:00
rustc_llvm Rollup merge of #118941 - krasimirgg:llvm-cov, r=nikic 2023-12-18 17:03:11 +01:00
rustc_log
rustc_macros Rename many DiagCtxt and EarlyDiagCtxt locals. 2023-12-18 16:06:22 +11:00
rustc_metadata Rename many DiagCtxt arguments. 2023-12-18 16:06:22 +11:00
rustc_middle Check FnPtr/FnDef built-in fn traits correctly with effects 2023-12-18 20:28:06 +00:00
rustc_mir_build Rename many DiagCtxt arguments. 2023-12-18 16:06:22 +11:00
rustc_mir_dataflow NFC don't convert types to identical types 2023-12-15 23:56:24 +01:00
rustc_mir_transform Auto merge of #119069 - matthiaskrgr:rollup-xxk4m30, r=matthiaskrgr 2023-12-18 08:03:22 +00:00
rustc_monomorphize Rename many DiagCtxt arguments. 2023-12-18 16:06:22 +11:00
rustc_next_trait_solver Opportunistically resolve region var in canonicalizer 2023-12-15 05:02:37 +00:00
rustc_parse Rename many DiagCtxt arguments. 2023-12-18 16:06:22 +11:00
rustc_parse_format Auto merge of #117819 - fmease:rustc_parse_format-stable-rustc, r=Nilstrieb 2023-11-15 14:55:35 +00:00
rustc_passes Rename many DiagCtxt arguments. 2023-12-18 16:06:22 +11:00
rustc_pattern_analysis NFC: do not clone types that are copy 2023-12-15 23:19:51 +01:00
rustc_privacy resolve: Replace visibility table in resolver outputs with query feeding 2023-12-18 02:26:55 +03:00
rustc_query_impl QueryContext: rename try_collect_active_jobs -> collect_active_jobs and change it's return type from Option<QueryMap> to QueryMap 2023-11-27 18:13:15 +03:00
rustc_query_system Rename many DiagCtxt and EarlyDiagCtxt locals. 2023-12-18 16:06:22 +11:00
rustc_resolve Rename Session::span_diagnostic as Session::dcx. 2023-12-18 16:06:21 +11:00
rustc_serialize Call FileEncoder::finish in rmeta encoding 2023-11-22 22:49:22 -05:00
rustc_session Rename many DiagCtxt and EarlyDiagCtxt locals. 2023-12-18 16:06:22 +11:00
rustc_smir Auto merge of #119000 - celinval:smir-cstr, r=ouz-a 2023-12-17 08:18:17 +00:00
rustc_span Add better ICE messages for some undescriptive panics 2023-12-15 00:50:55 -05:00
rustc_symbol_mangling Rename many DiagCtxt arguments. 2023-12-18 16:06:22 +11:00
rustc_target Add new tier 3 aarch64-apple-watchos target 2023-12-18 16:26:54 +08:00
rustc_trait_selection Check FnPtr/FnDef built-in fn traits correctly with effects 2023-12-18 20:28:06 +00:00
rustc_traits add unused NormalizesTo predicate 2023-12-07 17:52:51 +01:00
rustc_transmute Update itertools to 0.11. 2023-11-22 08:13:21 +11:00
rustc_ty_utils Rollup merge of #118871 - tmiasko:coroutine-maybe-uninit-fields, r=compiler-errors 2023-12-13 18:03:33 +01:00
rustc_type_ir Auto merge of #118970 - aliemjay:rollup-or33al2, r=aliemjay 2023-12-15 08:51:00 +00:00
stable_mir Add a method to check if type is a CStr 2023-12-15 13:18:41 -08:00