nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-26 16:54:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
d0293c6cf2
rust/tests/crashes
History
Matthias Krüger ddbbda47eb
Rollup merge of #129168 - BoxyUwU:mismatched_ty_correct_id, r=compiler-errors 
Return correct HirId when finding body owner in diagnostics

Fixes #129145
Fixes #128810

r? ```@compiler-errors```

```rust
fn generic<const N: u32>() {}

trait Collate<const A: u32> {
    type Pass;
    fn collate(self) -> Self::Pass;
}

impl<const B: u32> Collate<B> for i32 {
    type Pass = ();
    fn collate(self) -> Self::Pass {
        generic::<{ true }>()
        //~^ ERROR: mismatched types
    }
}
```

When type checking the `{ true }` anon const we would error with a type mismatch. This then results in diagnostics code attempting to check whether its due to a type mismatch with the return type. That logic was implemented by walking up the hir until we reached the body owner, except instead of using the `enclosing_body_owner` function it special cased various hir nodes incorrectly resulting in us walking out of the anon const and stopping at `fn collate` instead.

This then resulted in diagnostics logic inside of the anon consts `ParamEnv` attempting to do trait solving involving the `<i32 as Collate<B>>::Pass` type which ICEs because it is in the wrong environment.

I have rewritten this function to just walk up until it hits the `enclosing_body_owner` and made some other changes since I found this pretty hard to read/understand. Hopefully it's easier to understand now, it also makes it more obvious that this is not implemented in a very principled way and is definitely missing cases :)
2024-08-17 18:18:19 +02:00
..
23707.rs crashes: limit a couple tests to only run on x86_64 and/or not on windows 2024-04-14 23:53:39 +02:00
34127.rs crashes: limit a couple tests to only run on x86_64 and/or not on windows 2024-04-14 23:53:39 +02:00
54888.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
57276.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
74299.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
74451.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
79409.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
79590.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
87577.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
88296.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
90110.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
91985.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
92004.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
92470.rs crashes: add more tests 2024-04-26 17:20:16 +02:00
93182.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
93237.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
94846.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
95134.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
96304.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
98322.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
100041.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
100618.rs crashes: add a couple more tests 2024-04-18 18:55:20 +02:00
101036.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
101557.rs crashes: fix ice detection which did not trigger if code compiled without error by accident 2024-04-14 11:21:58 +02:00
102047.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
102252.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
103708.rs add more known-crashes tests 2024-04-19 23:09:37 +02:00
103899.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
104685.rs add more known-crashes tests 2024-04-19 23:09:37 +02:00
105238-1.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
105238-2.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
105249.rs add more known-crashes tests 2024-04-19 23:09:37 +02:00
105275.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
105299.rs crashes: add a couple more tests 2024-04-18 18:55:20 +02:00
105937.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
106473.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
107362.rs crashes: add a couple more tests 2024-04-18 18:55:20 +02:00
108499.rs crashes: add a couple more tests 2024-04-18 18:55:20 +02:00
108814.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
109681.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
110378.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
110534.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
110627.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
110630.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
111419.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
111709-2.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
111709.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
111742.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
112201.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
112623.rs crashes: add even more tests?!? 2024-04-18 06:13:47 +02:00
113280.rs crashes: limit a couple tests to only run on x86_64 and/or not on windows 2024-04-14 23:53:39 +02:00
113379.rs add .rs crashes from https://github.com/rust-lang/glacier 2024-04-14 11:18:23 +02:00
113846.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
114198-2.rs crashes: add even more tests?!? 2024-04-18 06:13:47 +02:00
114198.rs crashes: add even more tests?!? 2024-04-18 06:13:47 +02:00
114212-2.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
114212.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
114317.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
114484.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
114663.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
114920.rs crashes: add a couple more tests 2024-04-18 18:55:20 +02:00
115435.rs crashes: fix ice detection which did not trigger if code compiled without error by accident 2024-04-14 11:21:58 +02:00
115808.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
115994.rs add more known-crashes tests 2024-04-19 23:09:37 +02:00
116519-2.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
116519.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
116554.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
116947.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
117392-2.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
117392.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
117496.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
117629.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
117696-1.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
117696-2.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
117795.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
117942.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
118038.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
118244.rs add more known-crashes tests 2024-04-19 23:09:37 +02:00
118320.rs crashes: fix ice detection which did not trigger if code compiled without error by accident 2024-04-14 11:21:58 +02:00
118545.rs crashes: add a couple more tests 2024-04-18 18:55:20 +02:00
118590.rs crashes: add a couple more tests 2024-04-18 18:55:20 +02:00
118603.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
118952-2.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
118952.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
118987-2.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
118987.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
119692.rs crashes: fix ice detection which did not trigger if code compiled without error by accident 2024-04-14 11:21:58 +02:00
119694.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
119701.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
119716-2.rs Detect non-lifetime binder params shadowing item params 2024-07-29 14:26:21 -04:00
119716.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
119729.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
119783.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
119786.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
119824.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
119924-6.rs Migrate tests to use -Znext-solver 2024-06-30 17:08:45 +00:00
120033.rs crashes: add a couple more tests 2024-04-18 18:55:20 +02:00
120241-2.rs crashes: fix ice detection which did not trigger if code compiled without error by accident 2024-04-14 11:21:58 +02:00
120241.rs crashes: fix ice detection which did not trigger if code compiled without error by accident 2024-04-14 11:21:58 +02:00
120254.rs crashes: add a couple more tests 2024-04-18 18:55:20 +02:00
120482.rs crashes: fix ice detection which did not trigger if code compiled without error by accident 2024-04-14 11:21:58 +02:00
120811.rs crashes: add even more tests?!? 2024-04-18 06:13:47 +02:00
120873.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
120911.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
121052.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
121097.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
121127.rs Make validate_mir pull optimized/ctfe MIR for all bodies 2024-08-03 15:18:09 -04:00
121161.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
121263-2.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
121263.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
121299.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
121363.rs crashes: add a couple more tests 2024-04-18 18:55:20 +02:00
121411.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
121422.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
121429.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
121538.rs crashes: add a couple more tests 2024-04-18 18:55:20 +02:00
121575.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
121623.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
121722.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
121799.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
121858.rs Partially implement ConstArgHasType 2024-05-29 17:06:54 +01:00
121963.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
122259.rs crashes: add a couple more tests 2024-04-18 18:55:20 +02:00
122529.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
122630.rs crashes: add a couple more tests 2024-04-18 18:55:20 +02:00
122681.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
122704.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
122710.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
122823.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
122903-1.rs Adjust crash bug to still reproduce. 2024-05-31 11:04:32 +00:00
122904-2.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
122904.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
123077-2.rs crashes: limit a couple tests to only run on x86_64 and/or not on windows 2024-04-14 23:53:39 +02:00
123134.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
123140.rs tests/crashes: add ICEs from matthiaskrgr/glacier2 2024-04-14 11:21:51 +02:00
123141.rs Partially implement ConstArgHasType 2024-05-29 17:06:54 +01:00
123157.rs crashes: fix ice detection which did not trigger if code compiled without error by accident 2024-04-14 11:21:58 +02:00
123456.rs crashes: add even more tests?!? 2024-04-18 06:13:47 +02:00
123690.rs crashes: add even more tests?!? 2024-04-18 06:13:47 +02:00
123693.rs crashes: add even more tests?!? 2024-04-18 06:13:47 +02:00
123809.rs Mark Parser::eat/check methods as must_use 2024-07-29 21:29:08 -04:00
123810.rs crashes: add even more tests?!? 2024-04-18 06:13:47 +02:00
123887.rs crashes: increment the number of tracked ones 2024-05-27 17:32:56 +02:00
123893.rs Give inlining bonuses to things that optimize out 2024-06-19 21:35:37 -07:00
123955.rs crashes: add a couple more ICE tests 2024-04-21 21:04:32 +02:00
123959.rs crashes: add even more tests?!? 2024-04-18 06:13:47 +02:00
124020.rs crashes: add even more tests?!? 2024-04-18 06:13:47 +02:00
124021.rs crashes: add even more tests?!? 2024-04-18 06:13:47 +02:00
124092.rs crashes: add a couple more ICE tests 2024-04-21 21:04:32 +02:00
124164.rs add more known-crashes tests 2024-04-19 23:09:37 +02:00
124182.rs crashes: add a couple more ICE tests 2024-04-21 21:04:32 +02:00
124189.rs crashes: add a couple more ICE tests 2024-04-21 21:04:32 +02:00
124207.rs crashes: add a couple more ICE tests 2024-04-21 21:04:32 +02:00
124340.rs crashes: add more tests 2024-04-26 17:20:16 +02:00
124350.rs crashes: add more tests 2024-04-26 17:20:16 +02:00
124352.rs crashes: add more tests 2024-04-26 17:20:16 +02:00
124375.rs crashes: add more tests 2024-04-26 17:20:16 +02:00
124436.rs crashes: add lastest batch of crash tests 2024-05-05 23:41:08 +02:00
124440.rs crashes: add lastest batch of crash tests 2024-05-05 23:41:08 +02:00
124751.rs crashes: add lastest batch of crash tests 2024-05-05 23:41:08 +02:00
124894.rs crashes: add more 2024-05-18 23:56:57 +02:00
125014.rs crashes: increment the number of tracked ones 2024-05-27 17:32:56 +02:00
125059.rs crashes: increment the number of tracked ones 2024-05-27 17:32:56 +02:00
125185.rs crashes: add more 2024-05-18 23:56:57 +02:00
125249.rs Change RTN to use .. again 2024-06-28 14:20:43 -04:00
125323.rs crashes: increment the number of tracked ones 2024-05-27 17:32:56 +02:00
125476.rs remove fixed crashes, add fixed crashes to tests, add new cashed found in the meantime 2024-05-27 20:41:09 +02:00
125512.rs crashes: increment the number of tracked ones 2024-05-27 17:32:56 +02:00
125553.rs remove fixed crashes, add fixed crashes to tests, add new cashed found in the meantime 2024-05-27 20:41:09 +02:00
125655.rs tests: add more crashes 2024-06-09 10:16:12 +02:00
125680.rs tests: add more crashes 2024-06-09 10:16:12 +02:00
125758.rs tests: add more crashes 2024-06-09 10:16:12 +02:00
125768.rs tests: add more crashes 2024-06-09 10:16:12 +02:00
125769.rs tests: add more crashes 2024-06-09 10:16:12 +02:00
125772.rs tests: add more crashes 2024-06-09 10:16:12 +02:00
125801.rs tests: add more crashes 2024-06-09 10:16:12 +02:00
125810.rs tests: add more crashes 2024-06-09 10:16:12 +02:00
125841.rs tests: add more crashes 2024-06-09 10:16:12 +02:00
125843.rs tests: add more crashes 2024-06-09 10:16:12 +02:00
125874.rs tests: add more crashes 2024-06-09 10:16:12 +02:00
125879.rs tests: add more crashes 2024-06-09 10:16:12 +02:00
125881.rs tests: add more crashes 2024-06-09 10:16:12 +02:00
125957.rs tests: add more crashes 2024-06-09 10:16:12 +02:00
126182.rs more ice tests 2024-06-16 20:38:08 +02:00
126267.rs more ice tests 2024-06-16 20:38:08 +02:00
126269.rs more ice tests 2024-06-16 20:38:08 +02:00
126359.rs more ice tests 2024-06-16 20:38:08 +02:00
126377.rs more ice tests 2024-06-16 20:38:08 +02:00
126646.rs crashes: add more tests 2024-06-29 09:33:28 +02:00
126667.rs crashes: add more tests 2024-06-29 09:33:28 +02:00
126680.rs crashes: add more tests 2024-06-29 09:33:28 +02:00
126696.rs crashes: add more tests 2024-06-29 09:33:28 +02:00
126725.rs crashes: add more tests 2024-06-29 09:33:28 +02:00
126850.rs crashes: add more tests 2024-06-29 09:33:28 +02:00
126896.rs Make validate_mir pull optimized/ctfe MIR for all bodies 2024-08-03 15:18:09 -04:00
126939.rs crashes: add latest 2024-07-04 23:44:10 +02:00
126942.rs crashes: add latest 2024-07-04 23:44:10 +02:00
126944.rs crashes: add latest 2024-07-04 23:44:10 +02:00
126966.rs crashes: add latest 2024-07-04 23:44:10 +02:00
126969.rs crashes: add latest 2024-07-04 23:44:10 +02:00
126982.rs crashes: add latest 2024-07-04 23:44:10 +02:00
127351.rs add more tests 2024-07-21 17:50:57 +02:00
127353.rs add more tests 2024-07-21 17:50:57 +02:00
127628.rs add more tests 2024-07-21 17:50:57 +02:00
127643.rs add more tests 2024-07-21 17:50:57 +02:00
127676.rs add more tests 2024-07-21 17:50:57 +02:00
127737.rs add more tests 2024-07-21 17:50:57 +02:00
127742.rs add more tests 2024-07-21 17:50:57 +02:00
127880.rs add more tests 2024-07-21 17:50:57 +02:00
127916.rs add more tests 2024-07-21 17:50:57 +02:00
127972.rs add more tests 2024-07-21 17:50:57 +02:00
128016.rs add more tests 2024-07-21 17:50:57 +02:00
128094.rs tests: more crashes 2024-08-04 21:25:49 +02:00
128176.rs tests: more crashes 2024-08-04 21:25:49 +02:00
128190.rs tests: more crashes 2024-08-04 21:25:49 +02:00
128327.rs tests: more crashes 2024-08-04 21:25:49 +02:00
128346.rs tests: more crashes 2024-08-04 21:25:49 +02:00
128695.rs crashes: more tests 2024-08-15 22:44:16 +02:00
128848.rs crashes: more tests 2024-08-15 22:44:16 +02:00
128870.rs crashes: more tests 2024-08-15 22:44:16 +02:00
129075.rs crashes: more tests 2024-08-15 22:44:16 +02:00
129095.rs crashes: more tests 2024-08-15 22:44:16 +02:00
129099.rs crashes: more tests 2024-08-15 22:44:16 +02:00
129109.rs crashes: more tests 2024-08-15 22:44:16 +02:00
129127.rs crashes: more tests 2024-08-15 22:44:16 +02:00
README.md crashes: readme: add reminder to add Fixes #abcde to prs to automatically close issues. 2024-04-15 21:44:04 +02:00

README.md

This is serves as a collection of crashes so that accidental ICE fixes are tracked. This was formally done at https://github.com/rust-lang/glacier but doing it inside the rustc testsuite is more convenient.

It is imperative that a test in the suite causes an internal compiler error/panic or makes rustc crash in some other way. A test will "pass" if rustc exits with something other than 1 or 0.

When adding crashes from https://github.com/rust-lang/rust/issues, the issue number should be noted in the file name (12345.rs should suffice) and perhaps also inside the file via //@ known-bug #4321

If you happen to fix one of the crashes, please move it to a fitting subdirectory in tests/ui and give it a meaningful name. Also please add a doc comment at the top of the file explaining why this test exists. :) Adding Fixes #NNNNN Fixes #MMMMM to the description of your pull request will ensure the corresponding tickets will be closed automatically upon merge. The ticket ids can be found in the file name or the known-bug annotation inside the testfile.