mirror of
https://github.com/rust-lang/rust.git
synced 2025-06-04 19:29:07 +00:00
547b3adfe4
Improve non_fmt_panic lint.
This change:
- fixes the span used by this lint in the case the panic argument is a single macro expansion (e.g. `panic!(a!())`);
- adds a suggestion for `panic!(format!(..))` to remove `format!()` instead of adding `"{}", ` or using `panic_any` like it does now; and
- fixes the incorrect suggestion to replace `panic![123]` by `panic_any(123]`.
Fixes #82109.
Fixes #82110.
Fixes #82111.
Example output:
```
warning: panic message is not a string literal
--> src/main.rs:8:12
|
8 | panic!(format!("error: {}", "oh no"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(non_fmt_panic)]` on by default
= note: this is no longer accepted in Rust 2021
= note: the panic!() macro supports formatting, so there's no need for the format!() macro here
help: remove the `format!(..)` macro call
|
8 | panic!("error: {}", "oh no");
| -- --
```
r? `@estebank`
|
||
|---|---|---|
| .. | ||
| nonstandard_style | ||
| array_into_iter.rs | ||
| builtin.rs | ||
| context.rs | ||
| early.rs | ||
| internal.rs | ||
| late.rs | ||
| levels.rs | ||
| lib.rs | ||
| methods.rs | ||
| non_ascii_idents.rs | ||
| non_fmt_panic.rs | ||
| nonstandard_style.rs | ||
| passes.rs | ||
| redundant_semicolon.rs | ||
| traits.rs | ||
| types.rs | ||
| unused.rs | ||