mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-03 21:47:36 +00:00
7f4b270aa4
Supress niches in coroutines to avoid aliasing violations As mentioned [here](https://github.com/rust-lang/rust/issues/63818#issuecomment-2264915918), using niches in fields of coroutines that are referenced by other fields is unsound: the discriminant accesses violate the aliasing requirements of the reference pointing to the relevant field. This issue causes [Miri errors in practice](https://github.com/rust-lang/miri/issues/3780). The "obvious" fix for this is to suppress niches in coroutines. That's what this PR does. However, we have several tests explicitly ensuring that we *do* use niches in coroutines. So I see two options: - We guard this behavior behind a `-Z` flag (that Miri will set by default). There is no known case of these aliasing violations causing miscompilations. But absence of evidence is not evidence of absence... - (What this PR does right now.) We temporarily adjust the coroutine layout logic and the associated tests until the proper fix lands. The "proper fix" here is to wrap fields that other fields can point to in [`UnsafePinned`](https://github.com/rust-lang/rust/issues/125735) and make `UnsafePinned` suppress niches; that would then still permit using niches of *other* fields (those that never get borrowed). However, I know that coroutine sizes are already a problem, so I am not sure if this temporary size regression is acceptable. `@compiler-errors` any opinion? Also who else should be Cc'd here? |
||
|---|---|---|
| .. | ||
| abi.rs | ||
| assoc.rs | ||
| common_traits.rs | ||
| consts.rs | ||
| errors.rs | ||
| implied_bounds.rs | ||
| instance.rs | ||
| layout_sanity_check.rs | ||
| layout.rs | ||
| lib.rs | ||
| needs_drop.rs | ||
| opaque_types.rs | ||
| representability.rs | ||
| sig_types.rs | ||
| structural_match.rs | ||
| ty.rs | ||