mirror of
https://github.com/rust-lang/rust.git
synced 2025-06-21 20:17:55 +00:00
f9fa13f705
Redefine `ErrorKind::Other` and stop using it in std. This implements the idea I shared yesterday in the libs meeting when we were discussing how to handle adding new `ErrorKind`s to the standard library: This redefines `Other` to be for *user defined errors only*, and changes all uses of `Other` in the standard library to a `#[doc(hidden)]` and permanently `#[unstable]` `ErrorKind` that users can not match on. This ensures that adding `ErrorKind`s at a later point in time is not a breaking change, since the user couldn't match on these errors anyway. This way, we use the `#[non_exhaustive]` property of the enum in a more effective way. Open questions: - How do we check this change doesn't cause too much breakage? Will a crate run help and be enough? - How do we ensure we don't accidentally start using `Other` again in the standard library? We don't have a `pub(not crate)` or `#[deprecated(in this crate only)]`. cc https://github.com/rust-lang/rust/pull/79965 cc `@rust-lang/libs` `@ijackson` r? `@dtolnay` |
||
|---|---|---|
| .. | ||
| alloc.rs | ||
| args.rs | ||
| common.rs | ||
| condvar.rs | ||
| env.rs | ||
| fs.rs | ||
| io.rs | ||
| mod.rs | ||
| mutex.rs | ||
| net.rs | ||
| os.rs | ||
| pipe.rs | ||
| process.rs | ||
| rwlock.rs | ||
| stdio.rs | ||
| thread_local_dtor.rs | ||
| thread_local_key.rs | ||
| thread.rs | ||
| time.rs | ||