Matthias Krüger ca28e9554f Rollup merge of #123654 - jieyouxu:question-mark-span, r=Nadrieril ... typeck: fix `?` suggestion span Noticed in <https://github.com/rust-lang/rust/pull/112043#issuecomment-2043565292>, if the ``` use the `?` operator to extract the `Result<(), std::fmt::Error>` value, propagating a `Result::Err` value to the caller ``` suggestion is applied to a macro that comes from a non-local crate (e.g. the stdlib), the suggestion span can become non-local, which will cause newer rustfix versions to fail. This PR tries to remedy the problem by recursively probing ancestors of the expression span, trying to identify the most ancestor span that is (1) still local, and (2) still shares the same syntax context as the expression. This is the same strategy used in https://github.com/rust-lang/rust/pull/112043. The test unfortunately cannot `//@ run-rustfix` because there are two conflicting MaybeIncorrect suggestions that when collectively applied, cause the fixed source file to become non-compilable. Also avoid running `//@ run-rustfix` for `tests/ui/typeck/issue-112007-leaked-writeln-macro-internals.rs` because that also contains conflicting suggestions. cc `@ehuss` who noticed this. This question mark span fix + not running rustfix on the tests containing conflicting MaybeIncorrect suggestions should hopefully unblock rustfix from updating.		2024-04-12 21:46:57 +02:00
..
src	Rollup merge of #123654 - jieyouxu:question-mark-span, r=Nadrieril	2024-04-12 21:46:57 +02:00
Cargo.toml	Optimize Symbol::integer by utilizing itoa in-place formatting	2024-03-06 19:39:36 +01:00