mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-14 02:49:40 +00:00
c9cf9c6507
Add Attribute::meta_kind The `AttrItem::meta` function is being called on a lot of places, however almost always the caller is only interested in the `kind` of the result `MetaItem`. Before, the `path` had to be cloned in order to get the kind, now it does not have to be. There is a larger related "problem". In a lot of places, something wants to know contents of attributes. This is accessed through `Attribute::meta_item_list`, which calls `AttrItem::meta` (now `AttrItem::meta_kind`), among other methods. When this function is called, the meta item list has to be recreated from scratch. Everytime something asks a simple question (like is this item/list of attributes `#[doc(hidden)]`?), the tokens of the attribute(s) are cloned, parsed and the results are allocated on the heap. That seems really unnecessary. What would be the best way to cache this? Turn `meta_item_list` into a query perhaps? Related PR: https://github.com/rust-lang/rust/pull/92227 r? rust-lang/rustdoc |
||
|---|---|---|
| .. | ||
| callbacks.rs | ||
| interface.rs | ||
| lib.rs | ||
| passes.rs | ||
| proc_macro_decls.rs | ||
| queries.rs | ||
| tests.rs | ||
| util.rs | ||