mirror of
https://github.com/rust-lang/rust.git
synced 2025-06-05 19:58:32 +00:00
feb32c6546
Add a notion of "some ABIs require certain target features" I think I finally found the right shape for the data and checks that I recently added in https://github.com/rust-lang/rust/pull/133099, https://github.com/rust-lang/rust/pull/133417, https://github.com/rust-lang/rust/pull/134337: we have a notion of "this ABI requires the following list of target features, and it is incompatible with the following list of target features". Both `-Ctarget-feature` and `#[target_feature]` are updated to ensure we follow the rules of the ABI. This removes all the "toggleability" stuff introduced before, though we do keep the notion of a fully "forbidden" target feature -- this is needed to deal with target features that are actual ABI switches, and hence are needed to even compute the list of required target features. We always explicitly (un)set all required and in-conflict features, just to avoid potential trouble caused by the default features of whatever the base CPU is. We do this *before* applying `-Ctarget-feature` to maintain backward compatibility; this poses a slight risk of missing some implicit feature dependencies in LLVM but has the advantage of not breaking users that deliberately toggle ABI-relevant target features. They get a warning but the feature does get toggled the way they requested. For now, our logic supports x86, ARM, and RISC-V (just like the previous logic did). Unsurprisingly, RISC-V is the nicest. ;) As a side-effect this also (unstably) allows *enabling* `x87` when that is harmless. I used the opportunity to mark SSE2 as required on x86-64, to better match the actual logic in LLVM and because all x86-64 chips do have SSE2. This infrastructure also prepares us for requiring SSE on x86-32 when we want to use that for our ABI (and for float semantics sanity), see https://github.com/rust-lang/rust/issues/133611, but no such change is happening in this PR. r? `@workingjubilee` |
||
|---|---|---|
| .. | ||
| auxiliary | ||
| aarch64-neon-works.rs | ||
| allowed-softfloat-target-feature-attribute.rs | ||
| allowed-softfloat-target-feature-flag-disable.rs | ||
| allowed-softfloat-target-feature-flag-disable.stderr | ||
| asm-implied-features-issue-128125.rs | ||
| feature-hierarchy.aarch64-sve2.stderr | ||
| feature-hierarchy.rs | ||
| forbidden-hardfloat-target-feature-attribute.rs | ||
| forbidden-hardfloat-target-feature-attribute.stderr | ||
| forbidden-hardfloat-target-feature-cfg.rs | ||
| forbidden-hardfloat-target-feature-flag-disable-implied.rs | ||
| forbidden-hardfloat-target-feature-flag-disable-implied.stderr | ||
| forbidden-hardfloat-target-feature-flag-disable-neon.rs | ||
| forbidden-hardfloat-target-feature-flag-disable-neon.stderr | ||
| forbidden-hardfloat-target-feature-flag-disable.rs | ||
| forbidden-hardfloat-target-feature-flag-disable.stderr | ||
| forbidden-target-feature-attribute.rs | ||
| forbidden-target-feature-attribute.stderr | ||
| forbidden-target-feature-cfg.rs | ||
| forbidden-target-feature-flag-disable.rs | ||
| forbidden-target-feature-flag-disable.stderr | ||
| forbidden-target-feature-flag.rs | ||
| forbidden-target-feature-flag.stderr | ||
| gate.rs | ||
| gate.stderr | ||
| implicit-features-cli.rs | ||
| implicit-features.rs | ||
| implied-features.rs | ||
| invalid-attribute.rs | ||
| invalid-attribute.stderr | ||
| missing-plusminus-2.rs | ||
| missing-plusminus-2.stderr | ||
| missing-plusminus.rs | ||
| missing-plusminus.stderr | ||
| no-llvm-leaks.rs | ||
| rust-specific-name-no-warnings.rs | ||
| similar-feature-suggestion.rs | ||
| similar-feature-suggestion.stderr | ||
| tied-features-cli.one.stderr | ||
| tied-features-cli.rs | ||
| tied-features-cli.three.stderr | ||
| tied-features-cli.two.stderr | ||
| tied-features-no-implication-1.paca.stderr | ||
| tied-features-no-implication-1.pacg.stderr | ||
| tied-features-no-implication-1.rs | ||
| tied-features-no-implication.paca.stderr | ||
| tied-features-no-implication.pacg.stderr | ||
| tied-features-no-implication.rs | ||
| tied-features.rs | ||
| tied-features.stderr | ||
| unstable-feature.rs | ||
| unstable-feature.stderr | ||
| using-target-feature-unstable.rs | ||
| wasm-disable-simd.rs | ||
| wasm-relaxed-simd.rs | ||
| wasm-safe.rs | ||