mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-14 02:49:40 +00:00
e9df0b6b40
coverage: Fix inconsistent handling of function signature spans While doing some more cleanup of `spans`, I noticed a strange inconsistency in how function signatures are handled. Normally the function signature span is treated as though it were executable as part of the start of the function, but in some cases the signature span disappears entirely from coverage, for no obvious reason. This is caused by the fact that spans created by `CoverageSpan::for_fn_sig` don't add the span to their `merged_spans` field (unlike normal statement/terminator spans). In cases where the span-processing code looks at those merged spans, it thinks the signature span is no longer visible and deletes it. Adding the signature span to `merged_spans` resolves the inconsistency. (Prior to #116409 this wouldn't have been possible, because there was no case in the old `CoverageStatement` enum representing a signature. Now that `merged_spans` is just a list of spans, that's no longer an obstacle.) |
||
|---|---|---|
| .. | ||
| spans | ||
| test_macros | ||
| counters.rs | ||
| graph.rs | ||
| mod.rs | ||
| query.rs | ||
| spans.rs | ||
| tests.rs | ||