Matthias Krüger 2066002b86 Rollup merge of #128852 - folkertdev:multipart-suggestion-stable-sort, r=compiler-errors ... use stable sort to sort multipart diagnostics I think a stable sort should be used to sort the different parts of a multipart selection. The current unstable sort uses the text of the suggestion as a tie-breaker. That just doesn't seem right, and the order of the input is a better choice I think, because it gives the diagnostic author more control. This came up when I was building a suggestion where ```rust fn foo() {} ``` must be turned into an unsafe function, and an attribute must be added ```rust #[target_feature(enable = "...")] unsafe fn foo() {} ``` In this example, the two suggestions occur at the same position, but the order is extremely important: unsafe must come after the attribute. But the situation changes if there is a pub/pub(crate), and if the unsafe is already present. It just out that because of the suggestion text, there is no way for me to order the suggestions correctly. This change probably should be tested, but are there tests of the diagnostics code itself in the tests? r? ```@estebank```		2024-08-09 18:24:58 +02:00
..
src	Rollup merge of #128852 - folkertdev:multipart-suggestion-stable-sort, r=compiler-errors	2024-08-09 18:24:58 +02:00
Cargo.toml	Use fold instead of flat_map	2024-07-29 19:03:25 +00:00
messages.ftl	Implement diagnostic translation for expected lifetime parameter message	2023-07-07 15:56:01 +09:00