mirror of
https://github.com/rust-lang/rust.git
synced 2024-12-03 12:13:43 +00:00
fd91925bce
The starting point for this was identical comments on two different
fields, in `ast::VariantData::Struct` and `hir::VariantData::Struct`:
```
// FIXME: investigate making this a `Option<ErrorGuaranteed>`
recovered: bool
```
I tried that, and then found that I needed to add an `ErrorGuaranteed`
to `Recovered::Yes`. Then I ended up using `Recovered` instead of
`Option<ErrorGuaranteed>` for these two places and elsewhere, which
required moving `ErrorGuaranteed` from `rustc_parse` to `rustc_ast`.
This makes things more consistent, because `Recovered` is used in more
places, and there are fewer uses of `bool` and
`Option<ErrorGuaranteed>`. And safer, because it's difficult/impossible
to set `recovered` to `Recovered::Yes` without having emitted an error.
|
||
|---|---|---|
| .. | ||
| auxiliary | ||
| fluent-messages | ||
| internal-lints | ||
| mod_dir_simple | ||
| session-diagnostic | ||
| stable-mir | ||
| compiler-calls.rs | ||
| deriving-global.rs | ||
| deriving-hygiene.rs | ||
| dropck_tarena_sound_drop.rs | ||
| dropck-tarena-cycle-checked.rs | ||
| dropck-tarena-cycle-checked.stderr | ||
| dropck-tarena-unsound-drop.rs | ||
| dropck-tarena-unsound-drop.stderr | ||
| empty-struct-braces-derive.rs | ||
| hash-stable-is-unstable.rs | ||
| hash-stable-is-unstable.stderr | ||
| lint-pass-macros.rs | ||
| missing-rustc-driver-error.rs | ||
| missing-rustc-driver-error.stderr | ||
| mod_dir_path_canonicalized.rs | ||
| pathless-extern-unstable.rs | ||
| pathless-extern-unstable.stderr | ||
| pprust-expr-roundtrip.rs | ||
| regions-mock-tcx.rs | ||
| rustc_encodable_hygiene.rs | ||