Nadrieril be4f8e2758 Rollup merge of #120490 - nnethercote:Diagnostic-hashing, r=estebank ... Don't hash lints differently to non-lints. `Diagnostic::keys`, which is used for hashing and equating diagnostics, has a surprising behaviour: it ignores children, but only for lints. This was added in #88493 to fix some duplicated diagnostics, but it doesn't seem necessary any more. This commit removes the special case and only four tests have changed output, with additional errors. And those additional errors aren't exact duplicates, they're just similar. For example, in src/tools/clippy/tests/ui/same_name_method.rs we currently have this error: ``` error: method's name is the same as an existing method in a trait --> $DIR/same_name_method.rs:75:13 | LL | fn foo() {} | ^^^^^^^^^^^ | note: existing `foo` defined here --> $DIR/same_name_method.rs:79:9 | LL | impl T1 for S {} | ^^^^^^^^^^^^^^^^ ``` and with this change we also get this error: ``` error: method's name is the same as an existing method in a trait --> $DIR/same_name_method.rs:75:13 | LL | fn foo() {} | ^^^^^^^^^^^ | note: existing `foo` defined here --> $DIR/same_name_method.rs:81:9 | LL | impl T2 for S {} | ``` I think printing this second argument is reasonable, possibly even preferable to hiding it. And the other cases are similar. r? `@estebank`		2024-01-31 12:10:52 +01:00
..
rustc	Clean up rustc_*/Cargo.toml.	2023-10-30 08:46:02 +11:00
rustc_abi	Fix rustc_abi build on stable	2024-01-16 21:15:31 +01:00
rustc_arena	Fix Stable trait and its impls to work with the new with_tables	2024-01-19 09:42:51 +00:00
rustc_ast	Rollup merge of #120329 - nnethercote:3349-precursors, r=fee1-dead	2024-01-26 14:43:31 +01:00
rustc_ast_lowering	Rollup merge of #120428 - petrochenkov:somehir2, r=compiler-errors	2024-01-29 12:56:54 +00:00
rustc_ast_passes	Stop using String for error codes.	2024-01-29 07:41:41 +11:00
rustc_ast_pretty	Auto merge of #120227 - nnethercote:further-improve-space_between, r=petrochenkov	2024-01-31 02:01:43 +00:00
rustc_attr	Stop using String for error codes.	2024-01-29 07:41:41 +11:00
rustc_baked_icu_data	Bump cfg(bootstrap)s	2023-11-15 19:41:28 -05:00
rustc_borrowck	Auto merge of #119101 - compiler-errors:outlives, r=lcnr	2024-01-30 19:22:04 +00:00
rustc_builtin_macros	Rollup merge of #120342 - oli-obk:track_errors6, r=nnethercote	2024-01-30 16:57:49 +01:00
rustc_codegen_cranelift	Merge commit '3e50cf65025f96854d6597e80449b0d64ad89589' into sync_cg_clif-2024-01-26	2024-01-26 18:33:45 +00:00
rustc_codegen_gcc	Remove the lifetime from DiagnosticArgValue.	2024-01-30 18:46:06 +11:00
rustc_codegen_llvm	add missing potential_query_instability for keys and values in hashmap	2024-01-30 12:43:10 +08:00
rustc_codegen_ssa	Rollup merge of #120485 - chenyukang:yukang-add-query-instability-check, r=michaelwoerister	2024-01-30 16:57:51 +01:00
rustc_const_eval	Rollup merge of #120488 - nnethercote:diag-lifetimes, r=oli-obk	2024-01-30 11:19:20 +01:00
rustc_data_structures	Remove unused features	2024-01-25 14:01:33 +00:00
rustc_driver	Bump cfg(bootstrap)s	2023-11-15 19:41:28 -05:00
rustc_driver_impl	Stop using String for error codes.	2024-01-29 07:41:41 +11:00
rustc_error_codes	Stop using String for error codes.	2024-01-29 07:41:41 +11:00
rustc_error_messages	Remove unused features	2024-01-25 14:01:33 +00:00
rustc_errors	Don't hash lints differently to non-lints.	2024-01-31 08:25:29 +11:00
rustc_expand	Rollup merge of #120342 - oli-obk:track_errors6, r=nnethercote	2024-01-30 16:57:49 +01:00
rustc_feature	Add feature gate	2024-01-24 23:52:03 +01:00
rustc_fluent_macro	annotate-snippets: update to 0.10	2024-01-07 16:53:32 +03:00
rustc_fs_util	Clean up rustc_*/Cargo.toml.	2023-10-30 08:46:02 +11:00
rustc_graphviz	remove unused pub fn	2023-11-23 14:11:02 +03:00
rustc_hir	hir: Use InferArg in ArrayLen::Infer	2024-01-28 02:04:39 +03:00
rustc_hir_analysis	Auto merge of #120346 - petrochenkov:ownodes, r=oli-obk	2024-01-31 05:37:49 +00:00
rustc_hir_pretty	hir: Use InferArg in ArrayLen::Infer	2024-01-28 02:04:39 +03:00
rustc_hir_typeck	Rollup merge of #120485 - chenyukang:yukang-add-query-instability-check, r=michaelwoerister	2024-01-30 16:57:51 +01:00
rustc_incremental	hir: Simplify hir_owner_nodes query	2024-01-30 15:00:52 +03:00
rustc_index	Auto merge of #120024 - Mark-Simulacrum:fast-union-merge, r=cjgillot	2024-01-27 22:26:37 +00:00
rustc_index_macros	Restrict access to the private field of newtype indexes	2024-01-19 15:38:47 +00:00
rustc_infer	Auto merge of #120346 - petrochenkov:ownodes, r=oli-obk	2024-01-31 05:37:49 +00:00
rustc_interface	Remove unused features	2024-01-25 14:01:33 +00:00
rustc_lexer	Use unescape_unicode for raw C string literals.	2024-01-25 12:28:11 +11:00
rustc_lint	Auto merge of #120346 - petrochenkov:ownodes, r=oli-obk	2024-01-31 05:37:49 +00:00
rustc_lint_defs	Rollup merge of #119948 - asquared31415:unsafe_op_in_unsafe_fn_fix, r=TaKO8Ki	2024-01-22 16:13:28 +01:00
rustc_llvm	Revert "Auto merge of #113923 - DianQK:restore-no-builtins-lto, r=pnkfelix"	2024-01-12 18:23:04 +08:00
rustc_log	rustc_log: provide a way to init logging based on the values, not names, of the env vars	2023-11-11 15:24:33 +01:00
rustc_macros	Rollup merge of #120475 - Nilstrieb:cargo-build-my-a-, r=michaelwoerister	2024-01-30 16:57:50 +01:00
rustc_metadata	Remove the lifetime from DiagnosticArgValue.	2024-01-30 18:46:06 +11:00
rustc_middle	Auto merge of #120346 - petrochenkov:ownodes, r=oli-obk	2024-01-31 05:37:49 +00:00
rustc_mir_build	Auto merge of #120346 - petrochenkov:ownodes, r=oli-obk	2024-01-31 05:37:49 +00:00
rustc_mir_dataflow	Remove unused features	2024-01-25 14:01:33 +00:00
rustc_mir_transform	Auto merge of #120346 - petrochenkov:ownodes, r=oli-obk	2024-01-31 05:37:49 +00:00
rustc_monomorphize	Remove unused features	2024-01-25 14:01:33 +00:00
rustc_next_trait_solver	Remove movability from TyKind::Coroutine	2023-12-28 16:35:01 +00:00
rustc_parse	Rollup merge of #120460 - nnethercote:fix-120397, r=compiler-errors	2024-01-30 11:19:19 +01:00
rustc_parse_format	Rename the unescaping functions.	2024-01-25 12:28:11 +11:00
rustc_passes	Rollup merge of #120472 - Nilstrieb:die, r=compiler-errors	2024-01-31 12:10:52 +01:00
rustc_pattern_analysis	Separate PlaceCtxt from UsefulnessCtxt	2024-01-30 17:07:06 +01:00
rustc_privacy	Stop using String for error codes.	2024-01-29 07:41:41 +11:00
rustc_query_impl	Remove unused features	2024-01-25 14:01:33 +00:00
rustc_query_system	Stop using String for error codes.	2024-01-29 07:41:41 +11:00
rustc_resolve	Rollup merge of #118533 - chenyukang:yukang-fix-118455, r=petrochenkov	2024-01-30 16:57:46 +01:00
rustc_serialize	Remove unused features	2024-01-25 14:01:33 +00:00
rustc_session	Remove the lifetime from DiagnosticArgValue.	2024-01-30 18:46:06 +11:00
rustc_smir	Do not normalize closure signature when building FnOnce shim	2024-01-22 16:50:30 +00:00
rustc_span	Rollup merge of #120434 - fmease:revert-speeder, r=petrochenkov	2024-01-30 16:57:49 +01:00
rustc_symbol_mangling	Auto merge of #118636 - h1467792822:dev, r=michaelwoerister	2024-01-27 02:32:30 +00:00
rustc_target	Revert "Add the wasm32-wasi-preview2 target"	2024-01-28 02:02:50 +01:00
rustc_trait_selection	Rollup merge of #120469 - estebank:issue-40120, r=TaKO8Ki	2024-01-31 12:10:51 +01:00
rustc_traits	Remove unused features	2024-01-25 14:01:33 +00:00
rustc_transmute	Remove unused features	2024-01-25 14:01:33 +00:00
rustc_ty_utils	Stop using String for error codes.	2024-01-29 07:41:41 +11:00
rustc_type_ir	Restrict access to the private field of newtype indexes	2024-01-19 15:38:47 +00:00
stable_mir	Remove unused features	2024-01-25 14:01:33 +00:00