rust/compiler
bors 7b21c18fe4 Auto merge of #126996 - oli-obk:do_not_count_errors, r=nnethercote
Automatically taint InferCtxt when errors are emitted

r? `@nnethercote`

Basically `InferCtxt::dcx` now returns a `DiagCtxt` that refers back to the `Cell<Option<ErrorGuaranteed>>` of the `InferCtxt` and thus when invoking `Diag::emit`, and the diagnostic is an error, we taint the `InferCtxt` directly.

That change on its own has no effect at all, because `InferCtxt` already tracks whether errors have been emitted by recording the global error count when it gets opened, and checking at the end whether the count changed. So I removed that error count check, which had a bit of fallout that I immediately fixed by invoking `InferCtxt::dcx` instead of `TyCtxt::dcx` in a bunch of places.

The remaining new errors are because an error was reported in another query, and never bubbled up. I think they are minor enough for this to be ok, and sometimes it actually improves diagnostics, by not silencing useful diagnostics anymore.

fixes #126485 (cc `@olafes)`

There are more improvements we can do (like tainting in hir ty lowering), but I would rather do that in follow up PRs, because it requires some refactorings.
2024-07-01 06:35:58 +00:00
..
rustc
rustc_abi Auto merge of #126326 - eggyal:ununsafe-StableOrd, r=michaelwoerister 2024-06-25 15:51:35 +00:00
rustc_arena Use tidy to sort crate attributes for all compiler crates. 2024-06-12 15:49:10 +10:00
rustc_ast Tighten spans for async blocks 2024-06-27 15:19:08 -04:00
rustc_ast_ir Use tidy to sort crate attributes for all compiler crates. 2024-06-12 15:49:10 +10:00
rustc_ast_lowering implement new effects desugaring 2024-06-28 10:57:35 +00:00
rustc_ast_passes Rollup merge of #127106 - spastorino:improve-unsafe-extern-blocks-diagnostics, r=compiler-errors 2024-06-29 22:10:57 +02:00
rustc_ast_pretty Tighten spans for async blocks 2024-06-27 15:19:08 -04:00
rustc_attr Use a dedicated type instead of a reference for the diagnostic context 2024-06-18 15:42:11 +00:00
rustc_baked_icu_data Use tidy to sort crate attributes for all compiler crates. 2024-06-12 15:49:10 +10:00
rustc_borrowck Auto merge of #126996 - oli-obk:do_not_count_errors, r=nnethercote 2024-07-01 06:35:58 +00:00
rustc_builtin_macros Tighten spans for async blocks 2024-06-27 15:19:08 -04:00
rustc_codegen_cranelift Merge commit '49cd5dd454d0115cfbe9e39102a8b3ba4616aa40' into sync_cg_clif-2024-06-30 2024-06-30 11:28:14 +00:00
rustc_codegen_gcc Remove type_i1 and type_struct from cg_ssa 2024-06-21 19:30:26 +00:00
rustc_codegen_llvm Rollup merge of #123237 - bjorn3:debuginfo_refactor, r=compiler-errors 2024-06-29 22:10:55 +02:00
rustc_codegen_ssa Rollup merge of #123237 - bjorn3:debuginfo_refactor, r=compiler-errors 2024-06-29 22:10:55 +02:00
rustc_const_eval Auto merge of #120639 - fee1-dead-contrib:new-effects-desugaring, r=oli-obk 2024-06-29 20:08:10 +00:00
rustc_data_structures rustc_data_structures: Explicitly check for 64-bit atomics support 2024-06-28 10:26:45 +02:00
rustc_driver Use tidy to sort crate attributes for all compiler crates. 2024-06-12 15:49:10 +10:00
rustc_driver_impl Auto merge of #126834 - bjorn3:interface_refactor, r=michaelwoerister 2024-06-25 09:35:53 +00:00
rustc_error_codes Auto merge of #126319 - workingjubilee:rollup-lendnud, r=workingjubilee 2024-06-12 11:10:50 +00:00
rustc_error_messages Use tidy to sort crate attributes for all compiler crates. 2024-06-12 15:49:10 +10:00
rustc_errors Auto merge of #126996 - oli-obk:do_not_count_errors, r=nnethercote 2024-07-01 06:35:58 +00:00
rustc_expand Rollup merge of #126928 - nnethercote:124141-pre, r=oli-obk 2024-06-27 02:06:19 -04:00
rustc_feature implement new effects desugaring 2024-06-28 10:57:35 +00:00
rustc_fluent_macro Use tidy to sort crate attributes for all compiler crates. 2024-06-12 15:49:10 +10:00
rustc_fs_util Remove useless tidy-alphabetical markers. 2024-06-20 09:23:20 +10:00
rustc_graphviz Use tidy to sort crate attributes for all compiler crates. 2024-06-12 15:49:10 +10:00
rustc_hir address review comments 2024-06-28 15:44:20 +00:00
rustc_hir_analysis Make feature(effects) require -Znext-solver 2024-06-30 17:08:10 +00:00
rustc_hir_pretty implement new effects desugaring 2024-06-28 10:57:35 +00:00
rustc_hir_typeck Auto merge of #126996 - oli-obk:do_not_count_errors, r=nnethercote 2024-07-01 06:35:58 +00:00
rustc_incremental Use tidy to sort crate attributes for all compiler crates. 2024-06-12 15:49:10 +10:00
rustc_index Use tidy to sort crate attributes for all compiler crates. 2024-06-12 15:49:10 +10:00
rustc_index_macros rustc_span: Minor improvements 2024-06-16 14:08:25 +03:00
rustc_infer Auto merge of #126996 - oli-obk:do_not_count_errors, r=nnethercote 2024-07-01 06:35:58 +00:00
rustc_interface Updated diagnostic messages 2024-06-27 22:24:36 +02:00
rustc_lexer Use tidy to sort crate attributes for all compiler crates. 2024-06-12 15:49:10 +10:00
rustc_lint Rollup merge of #126018 - nnethercote:rm-box_pointers-lint, r=lcnr 2024-06-30 18:25:31 +02:00
rustc_lint_defs sudo CI=green && Review changes <3 2024-06-25 18:06:22 +02:00
rustc_llvm Auto merge of #126907 - glaubitz:sparc-fixes, r=nagisa 2024-06-27 05:44:47 +00:00
rustc_log Bump tracing-tree and allow rendering lines again 2024-06-12 10:11:41 +00:00
rustc_macros Remove redundant argument from subdiagnostic method 2024-06-18 15:42:11 +00:00
rustc_metadata Auto merge of #120639 - fee1-dead-contrib:new-effects-desugaring, r=oli-obk 2024-06-29 20:08:10 +00:00
rustc_middle Auto merge of #120639 - fee1-dead-contrib:new-effects-desugaring, r=oli-obk 2024-06-29 20:08:10 +00:00
rustc_mir_build Replace a magic boolean with enum ScheduleDrops 2024-06-30 19:02:25 +10:00
rustc_mir_dataflow Auto merge of #126996 - oli-obk:do_not_count_errors, r=nnethercote 2024-07-01 06:35:58 +00:00
rustc_mir_transform Auto merge of #126996 - oli-obk:do_not_count_errors, r=nnethercote 2024-07-01 06:35:58 +00:00
rustc_monomorphize Use a dedicated type instead of a reference for the diagnostic context 2024-06-18 15:42:11 +00:00
rustc_next_trait_solver Auto merge of #120639 - fee1-dead-contrib:new-effects-desugaring, r=oli-obk 2024-06-29 20:08:10 +00:00
rustc_parse Rollup merge of #127103 - compiler-errors:tighten-trait-bound-parsing, r=fmease 2024-06-29 09:14:59 +02:00
rustc_parse_format Use tidy to sort crate attributes for all compiler crates. 2024-06-12 15:49:10 +10:00
rustc_passes Rollup merge of #127118 - surechen:fix_126789, r=jieyouxu 2024-06-29 22:10:59 +02:00
rustc_pattern_analysis Replace f16 and f128 pattern matching stubs with real implementations 2024-06-23 04:28:42 -05:00
rustc_privacy Do not ICE in privacy when type inference fails. 2024-06-17 10:09:27 +00:00
rustc_query_impl Allow tracing through item_bounds query invocations on opaques 2024-06-19 08:47:55 +00:00
rustc_query_system Auto merge of #126326 - eggyal:ununsafe-StableOrd, r=michaelwoerister 2024-06-25 15:51:35 +00:00
rustc_resolve Tighten spans for async blocks 2024-06-27 15:19:08 -04:00
rustc_sanitizers Split out IntoIterator and non-Iterator constructors for AliasTy/AliasTerm/TraitRef/projection 2024-06-24 11:28:21 -04:00
rustc_serialize Use tidy to sort crate attributes for all compiler crates. 2024-06-12 15:49:10 +10:00
rustc_session Rollup merge of #124741 - nebulark:patchable-function-entries-pr, r=estebank,workingjubilee 2024-06-28 08:34:07 +02:00
rustc_smir implement new effects desugaring 2024-06-28 10:57:35 +00:00
rustc_span address review comments 2024-06-28 15:44:20 +00:00
rustc_symbol_mangling Use a dedicated type instead of a reference for the diagnostic context 2024-06-18 15:42:11 +00:00
rustc_target rustc_target: Build sparc_unknown_linux_gnu with -mcpu=v9 and -m32 2024-06-24 17:58:21 +02:00
rustc_trait_selection Auto merge of #126996 - oli-obk:do_not_count_errors, r=nnethercote 2024-07-01 06:35:58 +00:00
rustc_traits Use tidy to sort crate attributes for all compiler crates. 2024-06-12 15:49:10 +10:00
rustc_transmute safe transmute: support non-ZST, variantful, uninhabited enums 2024-06-14 21:11:08 +00:00
rustc_ty_utils address review comments 2024-06-28 15:44:20 +00:00
rustc_type_ir Auto merge of #120639 - fee1-dead-contrib:new-effects-desugaring, r=oli-obk 2024-06-29 20:08:10 +00:00
rustc_type_ir_macros
stable_mir Add method to get all attributes on a definition 2024-06-28 13:24:41 +08:00