nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-12-04 04:39:16 +00:00
Code Issues Packages Projects Releases Wiki Activity
b49140295c
rust/tests/ui/closures
History
bors 790309b102 Auto merge of #115315 - RalfJung:field-capture-packed-alignment, r=oli-obk 
closure field capturing: don't depend on alignment of packed fields

This fixes the closure field capture part of https://github.com/rust-lang/rust/issues/115305: field capturing always stops at projections into packed structs, no matter the alignment of the field. This means changing a private field type from `u8` to `u64` can never change how closures capture fields, which is probably what we want.

Here's an example where, before this PR, changing the type of a private field in a repr(Rust) struct can change the output of a program:

```rust
#![allow(dead_code)]

mod m {
    // before patch
    #[derive(Default)]
    pub struct S1(u8);
    // after patch
    #[derive(Default)]
    pub struct S2(u64);
}

struct NoisyDrop;
impl Drop for NoisyDrop {
    fn drop(&mut self) {
        eprintln!("dropped!");
    }
}

#[repr(packed)]
struct MyType {
    field: m::S1, // output changes when this becomes S2
    other_field: NoisyDrop,
    third_field: Vec<()>,
}

fn test(r: MyType) {
    let c = || {
        let _val = std::ptr::addr_of!(r.field);
        let _val = r.third_field;
    };
    drop(c);
    eprintln!("before dropping");
}

fn main() {
    test(MyType {
        field: Default::default(),
        other_field: NoisyDrop,
        third_field: Vec::new(),
    });
}
```

Of course this is a breaking change for the same reason that doing field capturing in the first place was a breaking change. Packed fields are relatively rare and depending on drop order is relatively rare, so I don't expect this to have much impact, but it's hard to be sure and even a crater run will only tell us so much.

Also see the [nomination comment](https://github.com/rust-lang/rust/pull/115315#issuecomment-1702807825).

Cc `@rust-lang/wg-rfc-2229` `@ehuss`
2023-09-16 05:29:23 +00:00
..
2229_closure_analysis Auto merge of #115315 - RalfJung:field-capture-packed-alignment, r=oli-obk 2023-09-16 05:29:23 +00:00
binder refactor(rustc_middle): Substs -> GenericArg 2023-07-14 13:27:35 +01:00
closure-expected-type Move /src/test to /tests 2023-01-11 09:32:08 +00:00
print refactor(rustc_middle): Substs -> GenericArg 2023-07-14 13:27:35 +01:00
add_semicolon_non_block_closure.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
add_semicolon_non_block_closure.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
cannot-call-unsized-via-ptr-2.rs Always register sized obligation for argument 2023-06-15 03:18:21 +00:00
cannot-call-unsized-via-ptr-2.stderr Always register sized obligation for argument 2023-06-15 03:18:21 +00:00
cannot-call-unsized-via-ptr.rs Always register sized obligation for argument 2023-06-15 03:18:21 +00:00
cannot-call-unsized-via-ptr.stderr Always register sized obligation for argument 2023-06-15 03:18:21 +00:00
closure_cap_coerce_many_fail.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure_cap_coerce_many_fail.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure_no_cap_coerce_many_check_pass.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure_no_cap_coerce_many_run_pass.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure_no_cap_coerce_many_unsafe_0.mir.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure_no_cap_coerce_many_unsafe_0.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure_no_cap_coerce_many_unsafe_0.thir.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure_no_cap_coerce_many_unsafe_1.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure_promotion.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-array-break-length.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-array-break-length.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-bounds-cant-promote-superkind-in-struct.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-bounds-cant-promote-superkind-in-struct.stderr Revert "Suggest using Arc on !Send/!Sync types" 2023-08-28 03:16:48 -07:00
closure-bounds-static-cant-capture-borrowed.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-bounds-static-cant-capture-borrowed.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-bounds-subtype.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-bounds-subtype.stderr Revert "Suggest using Arc on !Send/!Sync types" 2023-08-28 03:16:48 -07:00
closure-expected.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-expected.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-immutable-outer-variable.fixed Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-immutable-outer-variable.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-immutable-outer-variable.rs.fixed Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-immutable-outer-variable.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-move-sync.rs update failing ui tests 2023-06-20 19:46:01 -04:00
closure-move-sync.stderr Revert "Suggest using Arc on !Send/!Sync types" 2023-08-28 03:16:48 -07:00
closure-no-fn-1.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-no-fn-1.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-no-fn-2.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-no-fn-2.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-no-fn-3.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-no-fn-3.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-no-fn-4.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-no-fn-4.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-no-fn-5.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-no-fn-5.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-referencing-itself-issue-25954.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-referencing-itself-issue-25954.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-reform-bad.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-reform-bad.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-return-type-mismatch.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-return-type-mismatch.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-return-type-must-be-sized.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-return-type-must-be-sized.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-wrong-kind.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
closure-wrong-kind.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
coerce-unsafe-closure-to-unsafe-fn-ptr.mir.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
coerce-unsafe-closure-to-unsafe-fn-ptr.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
coerce-unsafe-closure-to-unsafe-fn-ptr.thir.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
coerce-unsafe-to-closure.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
coerce-unsafe-to-closure.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
deeply-nested_closures.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
diverging-closure.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-868.rs Move tests 2023-05-08 17:58:01 -03:00
issue-6801.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-6801.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-10398.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-10398.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-11873.rs Move tests 2023-08-28 17:47:37 -03:00
issue-11873.stderr Move tests 2023-08-28 17:47:37 -03:00
issue-23012-supertrait-signature-inference.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-25439.rs Move tests 2023-08-28 17:47:37 -03:00
issue-25439.stderr Move tests 2023-08-28 17:47:37 -03:00
issue-41366.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-42463.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-46742.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-48109.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-52437.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-52437.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-67123.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-67123.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-68025.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-72408-nested-closures-exponential.rs Ignore tests that hang in new solver 2023-06-09 21:57:37 +00:00
issue-78720.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-78720.stderr Modify primary span label for E0308 2023-01-30 20:12:19 +00:00
issue-80313-mutable-borrow-in-closure.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-80313-mutable-borrow-in-closure.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-80313-mutable-borrow-in-move-closure.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-80313-mutable-borrow-in-move-closure.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-80313-mutation-in-closure.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-80313-mutation-in-closure.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-80313-mutation-in-move-closure.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-80313-mutation-in-move-closure.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-81700-mut-borrow.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-81700-mut-borrow.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-82438-mut-without-upvar.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-82438-mut-without-upvar.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-84044-drop-non-mut.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-84044-drop-non-mut.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-84128.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-84128.stderr Emit a hint for bad call return types due to generic arguments 2023-01-13 13:34:55 +09:00
issue-87461.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-87461.stderr Emit a hint for bad call return types due to generic arguments 2023-01-13 13:34:55 +09:00
issue-87814-1.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-87814-2.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-90871.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-90871.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-97607.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-99565.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-99565.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-101696.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-102089-multiple-opaque-cast.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
issue-109188.rs Return equal for two identical projections 2023-03-21 15:28:11 +08:00
issue-109188.stderr Return equal for two identical projections 2023-03-21 15:28:11 +08:00
issue-111932.rs diagnostics: do not suggest type name tweaks on type-inferred closure args 2023-06-05 19:05:15 -07:00
issue-111932.stderr diagnostics: do not suggest type name tweaks on type-inferred closure args 2023-06-05 19:05:15 -07:00
issue-113087.rs don't suggest move for borrows that aren't closures 2023-06-28 23:56:58 +02:00
issue-113087.stderr don't suggest move for borrows that aren't closures 2023-06-28 23:56:58 +02:00
local-type-mix.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
local-type-mix.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
multiple-fn-bounds.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
multiple-fn-bounds.stderr reword message to be less vague 2023-06-28 17:51:01 +00:00
old-closure-arg-call-as.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
old-closure-arg.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
old-closure-explicit-types.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
old-closure-expr-precedence.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
old-closure-expr-precedence.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
old-closure-expression-remove-semicolon.fixed Move /src/test to /tests 2023-01-11 09:32:08 +00:00
old-closure-expression-remove-semicolon.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
old-closure-expression-remove-semicolon.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
old-closure-fn-coerce.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
old-closure-iter-1.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
old-closure-iter-2.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
once-move-out-on-heap.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
self-supertrait-bounds.rs Broken tests 2023-04-11 17:45:42 +00:00
semistatement-in-lambda.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
static-closures-with-nonstatic-return.rs add known-bug test for unsound issue 84366 2023-04-22 00:47:07 -04:00
supertrait-hint-cycle-2.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
supertrait-hint-cycle-3.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
supertrait-hint-cycle.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
supertrait-hint-references-assoc-ty.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
thir-unsafeck-issue-85871.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00